From 2312d07bb59b55a4efe0739d2176988a9bebb68c Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Wed, 5 Jan 2022 16:46:03 +0000 Subject: [PATCH] Removed old book sort permission test Permission handling now done via other means with more extensive permissions testing in SortTest class. --- tests/Permissions/EntityPermissionsTest.php | 45 --------------------- 1 file changed, 45 deletions(-) diff --git a/tests/Permissions/EntityPermissionsTest.php b/tests/Permissions/EntityPermissionsTest.php index 96d4792b9..abd5065f5 100644 --- a/tests/Permissions/EntityPermissionsTest.php +++ b/tests/Permissions/EntityPermissionsTest.php @@ -670,51 +670,6 @@ class EntityPermissionsTest extends TestCase $this->actingAs($this->user)->get($firstBook->getUrl('/sort')); } - public function test_book_sort_permission() - { - /** @var Book $firstBook */ - $firstBook = Book::query()->first(); - /** @var Book $secondBook */ - $secondBook = Book::query()->find(2); - - $this->setRestrictionsForTestRoles($firstBook, ['view', 'update']); - $this->setRestrictionsForTestRoles($secondBook, ['view']); - - $firstBookChapter = $this->newChapter(['name' => 'first book chapter'], $firstBook); - $secondBookChapter = $this->newChapter(['name' => 'second book chapter'], $secondBook); - - // Create request data - $reqData = [ - [ - 'id' => $firstBookChapter->id, - 'sort' => 0, - 'parentChapter' => false, - 'type' => 'chapter', - 'book' => $secondBook->id, - ], - ]; - - // Move chapter from first book to a second book - $this->actingAs($this->user)->put($firstBook->getUrl() . '/sort', ['sort-tree' => json_encode($reqData)]) - ->assertRedirect('/'); - $this->get('/')->assertSee('You do not have permission'); - - $reqData = [ - [ - 'id' => $secondBookChapter->id, - 'sort' => 0, - 'parentChapter' => false, - 'type' => 'chapter', - 'book' => $firstBook->id, - ], - ]; - - // Move chapter from second book to first book - $this->actingAs($this->user)->put($firstBook->getUrl() . '/sort', ['sort-tree' => json_encode($reqData)]) - ->assertRedirect('/'); - $this->get('/')->assertSee('You do not have permission'); - } - public function test_can_create_page_if_chapter_has_permissions_when_book_not_visible() { /** @var Book $book */