webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-30 04:23:11 +03:00
Code Activity

PWA Manifest: Tweaks during review of PR #4430

Browse Source 
- Updated to go through HomeController with the builder as a helper
  class.
- Extracted some reapeated items into variables in manifest.
- Updated background color to match those used by BookStack.
- Removed reference of icon.ico since its not intended to be used.
- Added tests to cover functionality.

Review of #4430
This commit is contained in:
Dan Brown
2023-10-02 15:54:39 +01:00
parent 287ed4ff3b
commit 1d91b4d8a6
5 changed files with 98 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
tests/PwaManifestTest.php Normal file
View File

@ -0,0 +1,72 @@
<?php
namespace Tests;
class PwaManifestTest extends TestCase
{
public function test_manifest_access_and_format()
{
$this->setSettings(['app-color' => '#00ACED']);
$resp = $this->get('/manifest.json');
$resp->assertOk();
$resp->assertJson([
'name' => setting('app-name'),
'launch_handler' => [
'client_mode' => 'focus-existing'
],
'theme_color' => '#00ACED',
]);
}
public function test_pwa_meta_tags_in_head()
{
$html = $this->asViewer()->withHtml($this->get('/'));
// crossorigin attribute is required to send cookies with the manifest,
// so it can react correctly to user preferences (dark/light mode).
$html->assertElementExists('head link[rel="manifest"][href$="manifest.json"][crossorigin="use-credentials"]');
$html->assertElementExists('head meta[name="mobile-web-app-capable"][content="yes"]');
}
public function test_manifest_uses_configured_icons_if_existing()
{
$resp = $this->get('/manifest.json');
$resp->assertJson([
'icons' => [[
"src" => 'http://localhost/icon-32.png',
"sizes" => "32x32",
"type" => "image/png"
]]
]);
$galleryFile = $this->files->uploadedImage('my-app-icon.png');
$this->asAdmin()->call('POST', '/settings/customization', [], [], ['app_icon' => $galleryFile], []);
$customIconUrl = setting()->get('app-icon-32');
$this->assertStringContainsString('my-app-icon', $customIconUrl);
$resp = $this->get('/manifest.json');
$resp->assertJson([
'icons' => [[
"src" => $customIconUrl,
"sizes" => "32x32",
"type" => "image/png"
]]
]);
}
public function test_manifest_changes_to_user_preferences()
{
$lightUser = $this->users->viewer();
$darkUser = $this->users->editor();
setting()->putUser($darkUser, 'dark-mode-enabled', 'true');
$resp = $this->actingAs($lightUser)->get('/manifest.json');
$resp->assertJson(['background_color' => '#F2F2F2']);
$resp = $this->actingAs($darkUser)->get('/manifest.json');
$resp->assertJson(['background_color' => '#111111']);
}
}