webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Tweaked custom command registration, Added StyleCI fixes

Browse Source 
Old command registration method was interfering with default commands,
causing only a limited subset of commands to show overall.
This change follows the method the frameworks uses when loading in from a
directory to prevent issues with run/load order.
This commit is contained in:
Dan Brown
2021-11-22 22:22:31 +00:00
parent c6e196989e
commit 1bf59f434b
5 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/ThemeTest.php
View File

@ -210,7 +210,7 @@ class ThemeTest extends TestCase
public function test_register_command_allows_provided_command_to_be_usable_via_artisan()
{
Theme::registerCommand(new MyCustomCommand);
Theme::registerCommand(new MyCustomCommand());
Artisan::call('bookstack:test-custom-command', []);
$output = Artisan::output();
@ -233,9 +233,12 @@ class ThemeTest extends TestCase
}
}
class MyCustomCommand extends Command {
class MyCustomCommand extends Command
{
protected $signature = 'bookstack:test-custom-command';
public function handle() {
public function handle()
{
$this->line('Command ran!');
}
}
}