From 1b29d44689bbcf40fc79ef9b4257fc387d4b64be Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Mon, 31 Aug 2015 17:59:45 +0100 Subject: [PATCH] Improved empty lists. Fixes #10. --- app/User.php | 2 +- resources/assets/sass/styles.scss | 6 ++- resources/views/books/index.blade.php | 27 +++++++---- resources/views/books/show.blade.php | 48 +++++++++++-------- resources/views/chapters/show.blade.php | 9 +++- resources/views/home.blade.php | 19 +++++--- .../views/pages/sidebar-tree-list.blade.php | 1 + .../views/partials/activity-list.blade.php | 2 + 8 files changed, 75 insertions(+), 39 deletions(-) diff --git a/app/User.php b/app/User.php index 37e40437a..cfc20453f 100644 --- a/app/User.php +++ b/app/User.php @@ -24,7 +24,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon * * @var array */ - protected $fillable = ['name', 'email']; + protected $fillable = ['name', 'email', 'password']; /** * The attributes excluded from the model's JSON form. diff --git a/resources/assets/sass/styles.scss b/resources/assets/sass/styles.scss index 33b82e006..68b1c0125 100644 --- a/resources/assets/sass/styles.scss +++ b/resources/assets/sass/styles.scss @@ -296,7 +296,9 @@ h1, h2, h3, h4, h5, h6 { } } - +.book-tree { + margin-top: $-xl; +} .book-tree h4 { padding: $-m $-s 0 $-s; i { @@ -309,7 +311,7 @@ h1, h2, h3, h4, h5, h6 { .book-tree .sidebar-page-list { list-style: none; margin: 0; - margin-top: $-xl; + margin-top: $-xs; border-left: 5px solid $color-book; li a { display: block; diff --git a/resources/views/books/index.blade.php b/resources/views/books/index.blade.php index aec475a51..4a06a19c4 100644 --- a/resources/views/books/index.blade.php +++ b/resources/views/books/index.blade.php @@ -18,16 +18,25 @@ - -
-

Books

- @foreach($books as $book) -
-

{{$book->name}}

-

{{$book->description}}

+
+
+
+

Books

+ @if(count($books) > 0) + @foreach($books as $book) +
+

{{$book->name}}

+

{{$book->description}}

+
+
+ @endforeach + @else +

No books have been created.

+ Create one now + @endif
-
- @endforeach +
+
@stop \ No newline at end of file diff --git a/resources/views/books/show.blade.php b/resources/views/books/show.blade.php index cc915f39c..b44cd8505 100644 --- a/resources/views/books/show.blade.php +++ b/resources/views/books/show.blade.php @@ -36,27 +36,37 @@

- @foreach($book->children() as $childElement) -
-

- - {{ $childElement->name }} - -

-

- {{$childElement->getExcerpt()}} -

+ @if(count($book->children()) > 0) + @foreach($book->children() as $childElement) +
+

+ + {{ $childElement->name }} + +

+

+ {{$childElement->getExcerpt()}} +

- @if($childElement->isA('chapter') && count($childElement->pages) > 0) -
- @foreach($childElement->pages as $page) -

{{$page->name}}

- @endforeach -
- @endif -
+ @if($childElement->isA('chapter') && count($childElement->pages) > 0) +
+ @foreach($childElement->pages as $page) +

{{$page->name}}

+ @endforeach +
+ @endif +
+
+ @endforeach + @else +

No pages or chapters have been created for this book.

+

+ Create a new page +   -or-    + Add a chapter +


- @endforeach + @endif

diff --git a/resources/views/chapters/show.blade.php b/resources/views/chapters/show.blade.php index 56b946497..9eb27f225 100644 --- a/resources/views/chapters/show.blade.php +++ b/resources/views/chapters/show.blade.php @@ -56,7 +56,14 @@ @endforeach

@else -

No pages are in this chapter

+
+

No pages are currently in this chapter.

+

+ Create a new page +   -or-    + Sort the current book +

+
@endif

diff --git a/resources/views/home.blade.php b/resources/views/home.blade.php index 746ac406f..de6414044 100644 --- a/resources/views/home.blade.php +++ b/resources/views/home.blade.php @@ -7,13 +7,18 @@

Books

- @foreach($books as $book) -
-

{{$book->name}}

-

{{$book->description}}

-
-
- @endforeach + @if(count($books) > 0) + @foreach($books as $book) +
+

{{$book->name}}

+

{{$book->description}}

+
+
+ @endforeach + @else +

No books have been created.

+ Create one now + @endif
 
diff --git a/resources/views/pages/sidebar-tree-list.blade.php b/resources/views/pages/sidebar-tree-list.blade.php index 7783431d6..ed439e62c 100644 --- a/resources/views/pages/sidebar-tree-list.blade.php +++ b/resources/views/pages/sidebar-tree-list.blade.php @@ -1,5 +1,6 @@
+
Book Navigation
@endforeach
+@else +

New activity will show up here.

@endif \ No newline at end of file