webapp/bookstack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00
Code Activity

Updated update-url command to handle array values

Browse Source 
Also added message to clear the cache after running.
For #2546
This commit is contained in:
Dan Brown
2021-02-11 23:14:37 +00:00
parent c09300c06f
commit 1a4797abc4
2 changed files with 50 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/Commands/UpdateUrlCommandTest.php
View File

@ -6,7 +6,7 @@ use Tests\TestCase;
class UpdateUrlCommandTest extends TestCase
{
public function test_update_url_command_updates_page_content()
public function test_command_updates_page_content()
{
$page = Page::query()->first();
$page->html = '<a href="https://example.com/donkeys"></a>';
@ -22,7 +22,7 @@ class UpdateUrlCommandTest extends TestCase
]);
}
public function test_update_url_command_requires_valid_url()
public function test_command_requires_valid_url()
{
$badUrlMessage = "The given urls are expected to be full urls starting with http:// or https://";
$this->artisan('bookstack:update-url //example.com https://cats.example.com')->expectsOutput($badUrlMessage);
@ -33,14 +33,27 @@ class UpdateUrlCommandTest extends TestCase
$this->artisan('bookstack:update-url https://cats.example.com');
}
public function test_update_url_command_updates_settings()
public function test_command_updates_settings()
{
setting()->put('my-custom-item', 'https://example.com/donkey/cat');
$this->artisan('bookstack:update-url https://example.com https://cats.example.com')
->expectsQuestion("This will search for \"https://example.com\" in your database and replace it with \"https://cats.example.com\".\nAre you sure you want to proceed?", 'y')
->expectsQuestion("This operation could cause issues if used incorrectly. Have you made a backup of your existing database?", 'y');
$this->runUpdate('https://example.com', 'https://cats.example.com');
$settingVal = setting('my-custom-item');
$this->assertEquals('https://cats.example.com/donkey/cat', $settingVal);
}
public function test_command_updates_array_settings()
{
setting()->put('my-custom-array-item', [['name' => 'a https://example.com/donkey/cat url']]);
$this->runUpdate('https://example.com', 'https://cats.example.com');
$settingVal = setting('my-custom-array-item');
$this->assertEquals('a https://cats.example.com/donkey/cat url', $settingVal[0]['name']);
}
protected function runUpdate(string $oldUrl, string $newUrl)
{
$this->artisan("bookstack:update-url {$oldUrl} {$newUrl}")
->expectsQuestion("This will search for \"{$oldUrl}\" in your database and replace it with \"{$newUrl}\".\nAre you sure you want to proceed?", 'y')
->expectsQuestion("This operation could cause issues if used incorrectly. Have you made a backup of your existing database?", 'y');
}
}