mirror of
https://github.com/BookStackApp/BookStack.git
synced 2025-06-07 04:22:06 +03:00
Applied latest StyleCI changes
This commit is contained in:
parent
a3ead5062a
commit
04f37e21e2
@ -85,7 +85,7 @@ class ActivityLogger
|
|||||||
protected function dispatchWebhooks(string $type, $detail): void
|
protected function dispatchWebhooks(string $type, $detail): void
|
||||||
{
|
{
|
||||||
$webhooks = Webhook::query()
|
$webhooks = Webhook::query()
|
||||||
->whereHas('trackedEvents', function(Builder $query) use ($type) {
|
->whereHas('trackedEvents', function (Builder $query) use ($type) {
|
||||||
$query->where('event', '=', $type)
|
$query->where('event', '=', $type)
|
||||||
->orWhere('event', '=', 'all');
|
->orWhere('event', '=', 'all');
|
||||||
})
|
})
|
||||||
|
@ -109,5 +109,4 @@ class ActivityQueries
|
|||||||
|
|
||||||
return $newActivity;
|
return $newActivity;
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
@ -17,7 +17,10 @@ use Illuminate\Support\Facades\Log;
|
|||||||
|
|
||||||
class DispatchWebhookJob implements ShouldQueue
|
class DispatchWebhookJob implements ShouldQueue
|
||||||
{
|
{
|
||||||
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
use Dispatchable;
|
||||||
|
use InteractsWithQueue;
|
||||||
|
use Queueable;
|
||||||
|
use SerializesModels;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @var Webhook
|
* @var Webhook
|
||||||
|
@ -2,7 +2,6 @@
|
|||||||
|
|
||||||
namespace BookStack\Http\Controllers;
|
namespace BookStack\Http\Controllers;
|
||||||
|
|
||||||
use Activity;
|
|
||||||
use BookStack\Actions\ActivityQueries;
|
use BookStack\Actions\ActivityQueries;
|
||||||
use BookStack\Actions\View;
|
use BookStack\Actions\View;
|
||||||
use BookStack\Entities\Models\Book;
|
use BookStack\Entities\Models\Book;
|
||||||
|
@ -24,6 +24,7 @@ class WebhookController extends Controller
|
|||||||
->orderBy('name', 'desc')
|
->orderBy('name', 'desc')
|
||||||
->with('trackedEvents')
|
->with('trackedEvents')
|
||||||
->get();
|
->get();
|
||||||
|
|
||||||
return view('settings.webhooks.index', ['webhooks' => $webhooks]);
|
return view('settings.webhooks.index', ['webhooks' => $webhooks]);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -53,6 +54,7 @@ class WebhookController extends Controller
|
|||||||
$webhook->updateTrackedEvents(array_values($validated['events']));
|
$webhook->updateTrackedEvents(array_values($validated['events']));
|
||||||
|
|
||||||
$this->logActivity(ActivityType::WEBHOOK_CREATE, $webhook);
|
$this->logActivity(ActivityType::WEBHOOK_CREATE, $webhook);
|
||||||
|
|
||||||
return redirect('/settings/webhooks');
|
return redirect('/settings/webhooks');
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -89,6 +91,7 @@ class WebhookController extends Controller
|
|||||||
$webhook->updateTrackedEvents($validated['events']);
|
$webhook->updateTrackedEvents($validated['events']);
|
||||||
|
|
||||||
$this->logActivity(ActivityType::WEBHOOK_UPDATE, $webhook);
|
$this->logActivity(ActivityType::WEBHOOK_UPDATE, $webhook);
|
||||||
|
|
||||||
return redirect('/settings/webhooks');
|
return redirect('/settings/webhooks');
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -99,6 +102,7 @@ class WebhookController extends Controller
|
|||||||
{
|
{
|
||||||
/** @var Webhook $webhook */
|
/** @var Webhook $webhook */
|
||||||
$webhook = Webhook::query()->findOrFail($id);
|
$webhook = Webhook::query()->findOrFail($id);
|
||||||
|
|
||||||
return view('settings.webhooks.delete', ['webhook' => $webhook]);
|
return view('settings.webhooks.delete', ['webhook' => $webhook]);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -114,6 +118,7 @@ class WebhookController extends Controller
|
|||||||
$webhook->delete();
|
$webhook->delete();
|
||||||
|
|
||||||
$this->logActivity(ActivityType::WEBHOOK_DELETE, $webhook);
|
$this->logActivity(ActivityType::WEBHOOK_DELETE, $webhook);
|
||||||
|
|
||||||
return redirect('/settings/webhooks');
|
return redirect('/settings/webhooks');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -7,7 +7,6 @@ use Illuminate\Database\Eloquent\Factories\Factory;
|
|||||||
|
|
||||||
class WebhookFactory extends Factory
|
class WebhookFactory extends Factory
|
||||||
{
|
{
|
||||||
|
|
||||||
protected $model = Webhook::class;
|
protected $model = Webhook::class;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -2,6 +2,7 @@
|
|||||||
|
|
||||||
namespace Tests\Actions;
|
namespace Tests\Actions;
|
||||||
|
|
||||||
|
use function app;
|
||||||
use BookStack\Actions\Activity;
|
use BookStack\Actions\Activity;
|
||||||
use BookStack\Actions\ActivityLogger;
|
use BookStack\Actions\ActivityLogger;
|
||||||
use BookStack\Actions\ActivityType;
|
use BookStack\Actions\ActivityType;
|
||||||
@ -11,9 +12,8 @@ use BookStack\Entities\Models\Page;
|
|||||||
use BookStack\Entities\Repos\PageRepo;
|
use BookStack\Entities\Repos\PageRepo;
|
||||||
use BookStack\Entities\Tools\TrashCan;
|
use BookStack\Entities\Tools\TrashCan;
|
||||||
use Carbon\Carbon;
|
use Carbon\Carbon;
|
||||||
use Tests\TestCase;
|
|
||||||
use function app;
|
|
||||||
use function config;
|
use function config;
|
||||||
|
use Tests\TestCase;
|
||||||
|
|
||||||
class AuditLogTest extends TestCase
|
class AuditLogTest extends TestCase
|
||||||
{
|
{
|
||||||
|
@ -15,7 +15,6 @@ use Tests\TestCase;
|
|||||||
|
|
||||||
class WebhookCallTest extends TestCase
|
class WebhookCallTest extends TestCase
|
||||||
{
|
{
|
||||||
|
|
||||||
public function test_webhook_listening_to_all_called_on_event()
|
public function test_webhook_listening_to_all_called_on_event()
|
||||||
{
|
{
|
||||||
$this->newWebhook([], ['all']);
|
$this->newWebhook([], ['all']);
|
||||||
@ -73,8 +72,9 @@ class WebhookCallTest extends TestCase
|
|||||||
|
|
||||||
$this->runEvent(ActivityType::PAGE_UPDATE, $page, $editor);
|
$this->runEvent(ActivityType::PAGE_UPDATE, $page, $editor);
|
||||||
|
|
||||||
Http::assertSent(function(Request $request) use ($editor, $page, $webhook) {
|
Http::assertSent(function (Request $request) use ($editor, $page, $webhook) {
|
||||||
$reqData = $request->data();
|
$reqData = $request->data();
|
||||||
|
|
||||||
return $request->isJson()
|
return $request->isJson()
|
||||||
&& $reqData['event'] === 'page_update'
|
&& $reqData['event'] === 'page_update'
|
||||||
&& $reqData['text'] === ($editor->name . ' updated page "' . $page->name . '"')
|
&& $reqData['text'] === ($editor->name . ' updated page "' . $page->name . '"')
|
||||||
@ -88,7 +88,6 @@ class WebhookCallTest extends TestCase
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
protected function runEvent(string $event, $detail = '', ?User $user = null)
|
protected function runEvent(string $event, $detail = '', ?User $user = null)
|
||||||
{
|
{
|
||||||
if (is_null($user)) {
|
if (is_null($user)) {
|
||||||
@ -112,5 +111,4 @@ class WebhookCallTest extends TestCase
|
|||||||
|
|
||||||
return $webhook;
|
return $webhook;
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
@ -8,7 +8,6 @@ use Tests\TestCase;
|
|||||||
|
|
||||||
class WebhookManagementTest extends TestCase
|
class WebhookManagementTest extends TestCase
|
||||||
{
|
{
|
||||||
|
|
||||||
public function test_index_view()
|
public function test_index_view()
|
||||||
{
|
{
|
||||||
$webhook = $this->newWebhook([
|
$webhook = $this->newWebhook([
|
||||||
@ -39,7 +38,7 @@ class WebhookManagementTest extends TestCase
|
|||||||
'name' => 'My first webhook',
|
'name' => 'My first webhook',
|
||||||
'endpoint' => 'https://example.com/webhook',
|
'endpoint' => 'https://example.com/webhook',
|
||||||
'events' => ['all'],
|
'events' => ['all'],
|
||||||
'active' => 'true'
|
'active' => 'true',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$resp->assertRedirect('/settings/webhooks');
|
$resp->assertRedirect('/settings/webhooks');
|
||||||
@ -82,7 +81,7 @@ class WebhookManagementTest extends TestCase
|
|||||||
'name' => 'My updated webhook',
|
'name' => 'My updated webhook',
|
||||||
'endpoint' => 'https://example.com/updated-webhook',
|
'endpoint' => 'https://example.com/updated-webhook',
|
||||||
'events' => [ActivityType::PAGE_CREATE, ActivityType::PAGE_UPDATE],
|
'events' => [ActivityType::PAGE_CREATE, ActivityType::PAGE_UPDATE],
|
||||||
'active' => 'true'
|
'active' => 'true',
|
||||||
]);
|
]);
|
||||||
$resp->assertRedirect('/settings/webhooks');
|
$resp->assertRedirect('/settings/webhooks');
|
||||||
|
|
||||||
@ -169,5 +168,4 @@ class WebhookManagementTest extends TestCase
|
|||||||
|
|
||||||
return $webhook;
|
return $webhook;
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
@ -407,7 +407,7 @@ class EntitySearchTest extends TestCase
|
|||||||
{
|
{
|
||||||
$this->newPage([
|
$this->newPage([
|
||||||
'name' => 'Test Page',
|
'name' => 'Test Page',
|
||||||
'html' => '<p>На мен ми трябва нещо добро test</p>'
|
'html' => '<p>На мен ми трябва нещо добро test</p>',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$search = $this->asEditor()->get('/search?term=' . urlencode('На мен ми трябва нещо добро'));
|
$search = $this->asEditor()->get('/search?term=' . urlencode('На мен ми трябва нещо добро'));
|
||||||
|
Loading…
x
Reference in New Issue
Block a user