1
0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-07-28 17:02:04 +03:00

Fixed side-effect in binary LDAP handling

- Was not stripping prefix when sending value to LDAP server in search.
- Updated test to cover.
This commit is contained in:
Dan Brown
2020-02-15 22:35:15 +00:00
parent 54a4c6e678
commit 01b95d91ba
2 changed files with 8 additions and 1 deletions

View File

@ -45,6 +45,13 @@ class LdapService extends ExternalAuthService
$ldapConnection = $this->getConnection();
$this->bindSystemUser($ldapConnection);
// Clean attributes
foreach ($attributes as $index => $attribute) {
if (strpos($attribute, 'BIN;') === 0) {
$attributes[$index] = substr($attribute, strlen('BIN;'));
}
}
// Find user
$userFilter = $this->buildFilter($this->config['user_filter'], ['user' => $userName]);
$baseDn = $this->config['base_dn'];