Martin Prikryl
693f5da37c
Removing CFileException MFC class
...
Originally because it seemed that it was causing problems with 64-bit build, which wasn't true in the end. But it's a good move anyway.
Source commit: 2d2d341d8e98f31692c1beca8445899e289ee0cb
2026-04-18 01:11:47 +02:00
Martin Prikryl
afbaf8f9ea
Shared BOM declaration
...
Source commit: cba15f59434ab48b2f30e93d304e8e3fcffd0463
2026-01-22 14:53:05 +01:00
Martin Prikryl
a2119a7eac
Types and casts safe in respect to pointer size for forward 64-bit compatibility
...
Also GetWindowLongPtr and GWLP_USERDATA
https://winscp.net/tracker/618
Source commit: c85fdf15e50ce8a6f35b1c4d2a0125a0b9c4f1f0
2026-01-22 14:51:13 +01:00
Martin Prikryl
efe94d6c08
Using actual types and functions instead of WinAPI and Unicode/Ansi macros
...
Source commit: b7fec4d069296b58bb43e7a4a97dd85d558212b7
2025-12-21 01:34:21 +01:00
Martin Prikryl
f2eed0002d
Replacing CTimeSpan with VCL functions and removing some more unused MFC time code
...
Source commit: 6e54884137f0c5f45e32dcec5d756947a4f845d5
2025-12-21 01:25:39 +01:00
Martin Prikryl
63a9eb579a
Getting rid of MFC string loading code
...
Source commit: 3c7399548535aeb9ebb738e2fdde52431d0ba83f
2025-12-19 07:35:02 +01:00
Martin Prikryl
092180d4a7
Getting rid of MFC Ansi-Unicode conversion code
...
Source commit: f290d70e75fd2de0ae4c45e8480e766c2a8af5d0
2025-12-19 01:20:41 +01:00
Martin Prikryl
e5efed8955
Refactoring old-style casts
...
Source commit: 3c37b3a958525c595ad44b081b2e0f3b288b8eb0
2025-12-18 01:20:33 +01:00
Martin Prikryl
bd0dd77ab7
Using SysErrorMessage
...
Source commit: 8077c7969e90f7848bf30eb18da4fd492e5f1a76
2025-12-11 14:43:24 +01:00
Martin Prikryl
6963f08ffd
Enabling all warnings in all projects and only selectively disabling those that are needed
...
with aim to eventually update the code to need as little warnings disabled as needed.
Some code updates (and even fixes) to avoid warning done already
Source commit: 5c45a6f56c52e7b0c5034ed9980cd65259a7372b
2025-12-04 01:16:16 +01:00
David Bures
f22f2758e4
send host into InitSSLConnection so it's used as SNI in data channel same way is in control channel, Filezilla3 uses it this way, and some servers need the info to be able to map control channel when going thru different front end servers when load balancing
2025-11-03 14:23:27 +01:00
Martin Prikryl
1654eab67d
Non-conflicting method name
...
GetCurrentTime is re-defined as GetTickCount in winbase.h
Using unique method name instead not to cause problems, when headers are included in different order
Source commit: cc34b034c1386125d55894b7f2ac1e4ca1c776bf
2025-08-28 01:00:33 +02:00
Martin Prikryl
3817bbd736
Preparing for separate pre-compiled header file required by Clang
...
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang
Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
2025-08-22 15:43:55 +02:00
Martin Prikryl
178d063da0
Issue 2395 – Incomplete FTP upload when the source stream/stdin reads less than requested
...
https://winscp.net/tracker/2395
Source commit: 2577e5f6685b0dc1d31130283bbe94e82514f71b
2025-08-02 01:23:25 +02:00
Martin Prikryl
88a03b9736
Removing redundancy in FTP upload code
...
Source commit: 212ac959f61d892841f843c0c4cc821b888fe080
2025-08-02 01:20:22 +02:00
Martin Prikryl
066362a213
Removing unused FTP zlib code
...
Source commit: 4ea7071a5f9183b107d23c42caf36d96d266442b
2025-08-02 01:08:29 +02:00
Martin Prikryl
a23e73c987
Further removal of unused MFC code
...
(Neither CTime nor CString throws any CException)
Source commit: d4432854a7b73218a52cd92a9542d7f18e02ea27
2025-07-29 13:21:42 +02:00
Martin Prikryl
fc1ad2eea0
Reimplementing CString using UnicodeString and replacing CStringA with RawByteString
...
Source commit: 5232a4e3833b8e9dac4ebaa3c12151ff981ac6cf
2025-07-29 01:00:19 +02:00
Martin Prikryl
f7f00c631e
Clang imposed changes that should be noop and have no effect on classic compiler
...
Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
Source commit: 5c1338d95bd275082288dd1e773a033df6e379cd
2025-03-13 16:39:24 +01:00
Martin Prikryl
4019b56ffb
Code errors identified by Clang
...
Notably:
Bug fix: Monospace font is not remembered if SSH banners are administratively forced
Change: Bug fix: In XML log, filename tag was included in stat tag, although explicitly documented not to
Source commit: 693ecd9b083f1460dc4d1ae1ff49e625989f8a50
2025-03-13 06:36:08 +01:00
Martin Prikryl
3188e64164
Bug fix: Reported transfer size is rarely incorrect during FTP downloads
...
Source commit: 5d6040cb98588d23bb4c87e14967b8222ccc2a8d
2024-01-10 18:56:30 +01:00
Martin Prikryl
1995f0c7b0
Links update
...
(cherry picked from commit c1c38aeae7 )
Source commit: 92d41c4d8be74c9628bfb3f81082e1280ca2313d
2022-10-22 08:26:59 +02:00
Martin Prikryl
361e4ae191
Bug 1945: Streaming support in .NET assembly for FTP protocol
...
https://winscp.net/tracker/1945
(cherry picked from commit 9370bfd17f )
Source commit: 9602b495c733729c7e1c180cb05001f5d5af4104
2022-04-29 16:29:15 +02:00
Martin Prikryl
63243511ec
Bug 597: Bytes transferred are recorded in XML log and available in .NET assembly API + Bug fix: When size of a file downloaded with FTP protocol changes (or when ASCII mode is used) the logged size did not reflect the actual transfer size
...
https://winscp.net/tracker/597
(cherry picked from commit 3442fc2b6c )
Source commit: 06eea0dc71a88d9a4109cbf702e81232ea3e791d
2021-11-25 01:08:02 +01:00
Martin Prikryl
f7e1c07cd8
Limiting scope of Bug 2030 (Timeout while uploading files to some FTP servers using TLS 1.3) to affected servers only
...
https://winscp.net/tracker/2030
(cherry picked from commit 12a3508797 )
Source commit: 559e8094923f8493b5611d53a2d934f123f6640a
2021-10-11 15:35:25 +02:00
Martin Prikryl
3e3284eae4
Bug 1982: Automatically resume transfer when TLS re-key fails
...
https://winscp.net/tracker/1982
(cherry picked from commit 64a802c4fa )
Source commit: d1ffdbb01832674697cfec09a946c41ec0633def
2021-05-06 11:45:37 +02:00
Martin Prikryl
f8522e8ff6
Bug 1976: Failure when retrieving a directory listing from an FTP server when the data are transmitted in huge amount of tiny chunks
...
https://winscp.net/tracker/1976
(cherry picked from commit a7e68c3d79 )
Source commit: bb81c2f7ac97257137ef402bcbfaadb2d5683a86
2021-04-15 00:52:25 +02:00
Martin Prikryl
37f99ed652
Bug fix: Canceled or failed FTP transfer caused connection loss
...
Caused by Bug 1878.
Source commit: 06642136cb284bbae9b6ebcecd86ad190aa98ba0
2021-03-04 00:49:19 +01:00
Martin Prikryl
e757f7b77b
Bug 1950: Parsing of multiline VMS FTP listing entries is broken
...
https://winscp.net/tracker/1950
(cherry picked from commit 517fac5f1f )
Source commit: febffea48ab19ac8e1990db3118903013814fb42
2021-02-04 00:59:09 +01:00
Martin Prikryl
db8ea994f3
Correcting MLST parsing (from fa0ed3c5)
...
Is probably noop, but previous version was badly designed at least
(cherry picked from commit a8bd2dad09 )
Source commit: bf49e61b95478685b6b3d36d71ef0820080956fc
2021-02-04 00:54:09 +01:00
Martin Prikryl
bd8d7041c0
Bug 958: Local ports for active FTP mode can be limited
...
https://winscp.net/tracker/958
(cherry picked from commit a00bcd5188 )
Source commit: 1c1245fcc1a0939a34931061e926889f8e14cecb
2020-11-26 16:02:45 +01:00
Martin Prikryl
551eedd209
Bug 1895: Support for SNI with FTP (2nd)
...
https://winscp.net/tracker/1895
(cherry picked from commit a25c55a621 )
Source commit: 9397e51855c8dab4b8fd3574ca1c21e89acb509c
2020-11-26 14:21:59 +01:00
Martin Prikryl
f921e2ad35
Improving logging of FTP transfer failures (2nd)
...
(cherry picked from commit 18d386923d )
Source commit: 3a6a4261f0dfc3cdd159a03659c44927dc10cbfb
2020-11-26 12:46:41 +01:00
Martin Prikryl
2d626d6534
Improving logging of FTP transfer failures
...
(cherry picked from commit 14add145f2 )
Source commit: 17f61db7a947101d4e24ccd933b77fc3d930e26d
2020-11-26 12:45:16 +01:00
Martin Prikryl
e78c2485a0
Bug 1834: FTP file uploads are interrupting with TLS 1.3
...
https://winscp.net/tracker/1834
Source commit: ed1a795deeb85606fa2ebb3cb265a407b5abfbef
2020-04-23 01:15:22 +02:00
Martin Prikryl
0e4e2e6bc8
It is possible to configure TLS 1.3 restrictions
...
(+ reusing SetupSsl for FTP)
Source commit: 426bf5c70861f8a2964967d32ef5b5e36bbb1ac6
2020-02-12 00:52:11 +01:00
Martin Prikryl
4f3ee319b8
Link update in comments
...
Source commit: 82a98dd088b33b9bb3b1e8ae6297fcf3c3548054
2019-07-08 08:08:00 +02:00
Martin Prikryl
e360e03db6
Comment about socket closing
...
Source commit: 3a6334b18550a892ae2723145c078428af9bd840
2018-11-27 02:22:35 +01:00
Martin Prikryl
c7a55143cb
Bug 1637: Low logging level
...
https://winscp.net/tracker/1637
Source commit: 77c4bd8361dc2604b244964b6b60240465ece323
2018-04-21 03:36:35 +02:00
Martin Prikryl
92266b35e9
https:// for stackoverflow.com
...
Source commit: 5d2ea7d20a5e5b92bf630944aca400829baae47f
2018-01-28 06:59:52 +01:00
Martin Prikryl
504f283ff4
Updating links
...
Source commit: 59d3a5c87219b542c6b43bd992db5b0f1cd94f87
2018-01-28 01:37:03 +01:00
Martin Prikryl
6b6719a101
Consistently logging opening and closing of the data connection
...
Source commit: 482d3dbf98738ebb468d6374ce322e7339ce8c6c
2018-01-27 10:22:28 +01:00
Martin Prikryl
24bf353294
Dynamically increase TCP send buffer on fast connections.
...
Source commit: 083f53ecc08259d4a013cfe78c6a41f9968243de
2018-01-26 01:22:14 +01:00
Martin Prikryl
e0bd20b332
Factoring out CTransferSocket::Start()
...
Source commit: 0711e83bc1bd60d92ea53ac972685b8e1035c198
2018-01-25 11:14:39 +01:00
Martin Prikryl
7bf7521607
Unused field
...
Source commit: 8c0767ef4255e750d3b3a5ffce27ded766d917fc
2018-01-25 11:13:41 +01:00
Martin Prikryl
5d0ad2154c
Bug 1381: Timeout when uploading to FTP over TLS and proxy when the FTP server responds with 1xy before proxy connection is processed
...
https://winscp.net/tracker/1381
Source commit: cea0dcc3302c3601f8306fb7309c8127f1f04b06
2018-01-25 11:12:43 +01:00
Martin Prikryl
dbeed2fa5e
Simplifying interface for configuring proxy layer
...
Source commit: 2c0ccd46e4797935e248fcfcaa52b34bd39bcb5c
2018-01-25 10:58:26 +01:00
Martin Prikryl
f761b2e828
Replacing FileZilla's VERIFY with ours DebugCheck
...
Source commit: 92cd01cbb66c748924d215611d719e27177145fa
2018-01-25 10:54:29 +01:00
Martin Prikryl
b55e9565da
Function call-line syntax for DebugFail + Replacing all DebugAssert(false) with DebugFail
...
Source commit: 358df59fa46a04bd1b2a141b826fa5c499303ae6
2018-01-24 20:47:51 +01:00
Martin Prikryl
c2f3ec506b
Using our asserts in FileZilla code
...
Source commit: a294b54252528b1b33b5d205336bb321584dcf95
2018-01-24 20:46:52 +01:00