Martin Prikryl
5a8c4cdaea
Using "username" and "hostname" as one word
...
Source commit: d86c0d6704a14fff6e3dca57868548df1f80cdd7
2026-05-29 01:15:26 +02:00
Martin Prikryl
7e83e14f24
Removing code for listening over proxy, which is never used (and part of it is not 64-bit ready)
...
Source commit: 6b69572a80001b9aa5e425c6a360989740c17ad7
2026-03-07 01:07:38 +01:00
Martin Prikryl
a2119a7eac
Types and casts safe in respect to pointer size for forward 64-bit compatibility
...
Also GetWindowLongPtr and GWLP_USERDATA
https://winscp.net/tracker/618
Source commit: c85fdf15e50ce8a6f35b1c4d2a0125a0b9c4f1f0
2026-01-22 14:51:13 +01:00
Martin Prikryl
4645876213
Refactoring UTF conversion in FTP with use of UTF8String
...
Source commit: 39bbfdb678746abe00f95f7e9385c155ae2882ff
2026-01-07 01:17:36 +01:00
Martin Prikryl
efe94d6c08
Using actual types and functions instead of WinAPI and Unicode/Ansi macros
...
Source commit: b7fec4d069296b58bb43e7a4a97dd85d558212b7
2025-12-21 01:34:21 +01:00
Martin Prikryl
f2eed0002d
Replacing CTimeSpan with VCL functions and removing some more unused MFC time code
...
Source commit: 6e54884137f0c5f45e32dcec5d756947a4f845d5
2025-12-21 01:25:39 +01:00
Martin Prikryl
9cf851dcfa
Replacing MFC CFile::IsValid with FileExists
...
Source commit: 48c7984e36261a8cee5f6eb09c896a8bf4ae0caa
2025-12-20 12:29:55 +01:00
Martin Prikryl
63a9eb579a
Getting rid of MFC string loading code
...
Source commit: 3c7399548535aeb9ebb738e2fdde52431d0ba83f
2025-12-19 07:35:02 +01:00
Martin Prikryl
092180d4a7
Getting rid of MFC Ansi-Unicode conversion code
...
Source commit: f290d70e75fd2de0ae4c45e8480e766c2a8af5d0
2025-12-19 01:20:41 +01:00
Martin Prikryl
996c687ddc
Factoring out PORT/PASV parsing and formatting + As a result, directory listing falls back to the other active/passive mode, consistently with file transfers
...
Source commit: 13a0a73f7378b2aea644de0b8f71d7c8d240c368
2025-12-19 01:18:06 +01:00
Martin Prikryl
90a35fe550
Removing nonsense code
...
Source commit: e63f03cc795d2dc2af025cb566007b927b98d506
2025-12-18 01:30:48 +01:00
Martin Prikryl
e5efed8955
Refactoring old-style casts
...
Source commit: 3c37b3a958525c595ad44b081b2e0f3b288b8eb0
2025-12-18 01:20:33 +01:00
Martin Prikryl
bd0dd77ab7
Using SysErrorMessage
...
Source commit: 8077c7969e90f7848bf30eb18da4fd492e5f1a76
2025-12-11 14:43:24 +01:00
Martin Prikryl
a5dcb5f03c
Using std::size instead of custom macro
...
Source commit: 1a89c80dd42426351f261526b617534bab664208
2025-12-07 01:17:54 +01:00
Martin Prikryl
6963f08ffd
Enabling all warnings in all projects and only selectively disabling those that are needed
...
with aim to eventually update the code to need as little warnings disabled as needed.
Some code updates (and even fixes) to avoid warning done already
Source commit: 5c45a6f56c52e7b0c5034ed9980cd65259a7372b
2025-12-04 01:16:16 +01:00
Martin Prikryl
99b57046b3
Bug fix: After FTP data connection fails to open further use of the session is broken
...
Source commit: 8f36620525c1756e8e4593f5be689ed695580079
2025-10-07 15:37:59 +02:00
Martin Prikryl
1654eab67d
Non-conflicting method name
...
GetCurrentTime is re-defined as GetTickCount in winbase.h
Using unique method name instead not to cause problems, when headers are included in different order
Source commit: cc34b034c1386125d55894b7f2ac1e4ca1c776bf
2025-08-28 01:00:33 +02:00
Martin Prikryl
3817bbd736
Preparing for separate pre-compiled header file required by Clang
...
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang
Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
2025-08-22 15:43:55 +02:00
Martin Prikryl
88a03b9736
Removing redundancy in FTP upload code
...
Source commit: 212ac959f61d892841f843c0c4cc821b888fe080
2025-08-02 01:20:22 +02:00
Martin Prikryl
8c5837e5bc
Removing parameter unused since ac251a73
...
Source commit: 89421b9dfbcae17e87f07ddbe798740411eb18a0
2025-08-02 01:11:39 +02:00
Martin Prikryl
066362a213
Removing unused FTP zlib code
...
Source commit: 4ea7071a5f9183b107d23c42caf36d96d266442b
2025-08-02 01:08:29 +02:00
Martin Prikryl
a23e73c987
Further removal of unused MFC code
...
(Neither CTime nor CString throws any CException)
Source commit: d4432854a7b73218a52cd92a9542d7f18e02ea27
2025-07-29 13:21:42 +02:00
Martin Prikryl
fc1ad2eea0
Reimplementing CString using UnicodeString and replacing CStringA with RawByteString
...
Source commit: 5232a4e3833b8e9dac4ebaa3c12151ff981ac6cf
2025-07-29 01:00:19 +02:00
Martin Prikryl
f7f00c631e
Clang imposed changes that should be noop and have no effect on classic compiler
...
Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
Source commit: 5c1338d95bd275082288dd1e773a033df6e379cd
2025-03-13 16:39:24 +01:00
Martin Prikryl
4019b56ffb
Code errors identified by Clang
...
Notably:
Bug fix: Monospace font is not remembered if SSH banners are administratively forced
Change: Bug fix: In XML log, filename tag was included in stat tag, although explicitly documented not to
Source commit: 693ecd9b083f1460dc4d1ae1ff49e625989f8a50
2025-03-13 06:36:08 +01:00
Mikhail Lukashov
a8e6220b88
fix typos
2024-01-05 10:37:32 +01:00
Martin Prikryl
46bd5c5396
Bug 2224: Recognize IP addresses starting with zero in FTP PASV response as unroutable
...
https://winscp.net/tracker/2224
Source commit: ad239582183c57611fbb6a66f7bd32caecee80ed
2023-09-29 01:01:48 +02:00
Martin Prikryl
266b470cf8
Using tolower and towupper
...
Source commit: 9679e092efa1a4683538eb9b46374f90b5699ab3
2023-08-19 01:13:29 +02:00
Martin Prikryl
1577b39b76
Bug 2194: Support for ProFTPD command OPTS REST STOR to query if upload restart is possible
...
https://winscp.net/tracker/2194
Source commit: 6b8e7e9e8d046a5a45f6ae586cb8ad9d5b61f09a
2023-06-08 01:04:28 +02:00
Martin Prikryl
ddd3256919
Bug 2132 ( de072c6e) broke download transfer resume
...
Source commit: a87af8cf7efcabaf15945ef90cd6527224f8f1bf
2022-11-11 13:03:02 +01:00
Martin Prikryl
de072c6ebd
Bug 2132: Do not overwrite existing local file when FTP download fails to start
...
https://winscp.net/tracker/2132
Source commit: f744f31a345e0d1e4c22142fed91cbf3dcb58ea3
2022-11-11 08:37:57 +01:00
Martin Prikryl
ac251a7309
Bug 2084: Do not list remote directory when downloading file using FTP protocol with overwrite confirmations off
...
https://winscp.net/tracker/2084
Source commit: 0c6aef0f33c1ffa0791b3a778648058de4e19500
2022-06-08 01:03:08 +02:00
Martin Prikryl
b62d433c40
Invalid FTP response was incorrectly logged when closing transfer connection (caused by cee1be5d)
...
Source commit: 058b686e4addddc869a112d728f849b9c151fafd
2022-06-08 00:59:22 +02:00
Martin Prikryl
52a5598429
Indentation
...
Source commit: 22ec7577a3991c09782813017d7a90500bf2a744
2022-06-08 00:57:32 +02:00
Martin Prikryl
cee1be5d62
Bug 2077: Improve error message when FTP server returns malformed response
...
https://winscp.net/tracker/2077
Source commit: fcf4ac3e67bfc4f877167881157278f1e28650db
2022-05-21 00:54:21 +02:00
Martin Prikryl
85b1e9cb3d
Optimizing use of USES_CONVERSION
...
Source commit: 41bec5877bfdf64a71ff054abe8849b94744330f
2022-05-17 12:29:49 +02:00
Martin Prikryl
cded95d85c
Uninitialized variable (from 9370bfd1)
...
Source commit: 34d32304fe796f5f9bf2426e61b7b58de380cf89
2022-05-02 12:28:10 +02:00
Martin Prikryl
37b2fd0ee0
Typo in a comment
...
Source commit: d2c068498e9fa84947bab56f8ffe96e37f8be091
2022-04-29 16:25:26 +02:00
Martin Prikryl
9370bfd17f
Bug 1945: Streaming support in .NET assembly for FTP protocol
...
https://winscp.net/tracker/1945
Source commit: 01274024eff31ef3f5794f3521689b4c2229acbb
2022-04-29 16:21:05 +02:00
Martin Prikryl
c9ff66a226
Factoring out CheckOverwriteFileAndCreateTarget and FileTransferHandleDirectoryListing
...
Source commit: 0d9d7f19f748e6cffb0931db05fcd314814af3cb
2022-04-28 00:58:45 +02:00
Martin Prikryl
b89afec307
Bug 2069: Improve compatibility with MVS systems (2nd)
...
https://winscp.net/tracker/2069
Source commit: 325a57bef47a52ab2c8ff8d7dda1e346a9921c9f
2022-04-26 01:05:05 +02:00
Martin Prikryl
191729720a
Bug 2065 – Scripting command "ls" in FTP session displays timestamps without year even if the server (notably IIS) provided the year, if it did not provide seconds
...
https://winscp.net/tracker/2065
Source commit: 4d719f707f54a5ce7d1ff2ad327a1159ccb3fefe
2022-03-26 01:07:27 +01:00
Martin Prikryl
eea7456b1d
Removing unused parts of MFC and replacing rarely used parts with other implementations
...
(cherry picked from commit 3f3d21f04b )
Source commit: 5f6ae0ffac016bd6749aab42cdc81d5ef8fcbd46
2022-01-20 17:19:10 +01:00
Martin Prikryl
81337cdcc5
Bug 2034: Custom certificate store file
...
https://winscp.net/tracker/2034
(cherry picked from commit e70fd8fa51 )
Source commit: 95c530928c9871191cf4f67478bf35b171e94643
2021-11-26 14:31:01 +01:00
Martin Prikryl
b045f97c36
Bug fix: FTP keepalive command was sometime sent right after the transfer finished
...
(cherry picked from commit 76d5949248 )
Source commit: adb4c0f69d8ba4f80f6b90263732d48a10bea264
2021-11-23 15:43:24 +01:00
Martin Prikryl
f7e1c07cd8
Limiting scope of Bug 2030 (Timeout while uploading files to some FTP servers using TLS 1.3) to affected servers only
...
https://winscp.net/tracker/2030
(cherry picked from commit 12a3508797 )
Source commit: 559e8094923f8493b5611d53a2d934f123f6640a
2021-10-11 15:35:25 +02:00
Martin Prikryl
3d2acab1f1
Logging failed/complete was logged reversed
...
(cherry picked from commit 1d5793c336 )
Source commit: ae0bab68a4c879d338301694dd94090d0464be56
2021-10-05 00:53:33 +02:00
Martin Prikryl
f46416fe9f
Links updates (tools.ietf.org => datatracker.ietf.org)
...
Source commit: 8647458b07e32ff872d96e60326ce65a261a6a59
2021-05-24 08:54:32 +02:00
Martin Prikryl
58a103fb76
Probably invalid assertion
...
(cherry picked from commit 006d280285 )
Source commit: 993fbb3b9a95cf2cab08bd10cce9ee5b30a911f8
2021-05-20 00:53:42 +02:00
Martin Prikryl
3e3284eae4
Bug 1982: Automatically resume transfer when TLS re-key fails
...
https://winscp.net/tracker/1982
(cherry picked from commit 64a802c4fa )
Source commit: d1ffdbb01832674697cfec09a946c41ec0633def
2021-05-06 11:45:37 +02:00