Martin Prikryl
e5efed8955
Refactoring old-style casts
...
Source commit: 3c37b3a958525c595ad44b081b2e0f3b288b8eb0
2025-12-18 01:20:33 +01:00
Martin Prikryl
a5dcb5f03c
Using std::size instead of custom macro
...
Source commit: 1a89c80dd42426351f261526b617534bab664208
2025-12-07 01:17:54 +01:00
Martin Prikryl
b13e2e7c2b
#pragma package(smart_init) is not useful out of packages
...
Source commit: 7635ac3b532214f27ea2b6fe6aa80398c857cfcd
2025-08-23 01:06:48 +02:00
Martin Prikryl
3817bbd736
Preparing for separate pre-compiled header file required by Clang
...
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang
Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
2025-08-22 15:43:55 +02:00
Martin Prikryl
f2c842e29e
Updating jump list only when running with GUI
...
Source commit: 524789d7ad0487c5adac0dffa69f0a095714b4e8
2025-08-20 01:14:07 +02:00
Martin Prikryl
dc67883c8e
Logging startup
...
Source commit: 7db6239e04346dced18df1b2758bb99a5495b1c6
2025-08-20 01:10:59 +02:00
Martin Prikryl
74fdf539de
Clang imposed changes that should be noop and have no effect on classic compiler (2nd after 92ba1e3f0 + preceding commits)
...
Mostly
– explicit static global variables
– const, sign and down casts safety
– same-named variables in nested scopes
– incorrectly identified uninitialized variables
– semicolon after function implementation
– unused variables, fields, arguments and macros
– exact include filename case
– field initialization order
– typename use
– struct vs class declarations
– incorrectly identified uninitialized variables
– refactoring to solve Clang internal compiler error when using new variable in __finally block
Source commit: 3da995ff5169eefcfe3b3b7cc0d019c660096c07
2025-06-24 16:32:34 +02:00
Martin Prikryl
89849132f6
Issue 2382 – Prevent hang when new device is attached or removed while some mapped network drive is not available
...
https://winscp.net/tracker/2382
Source commit: 70ab5c4162ee0e1f845cc78c1a703c62edf80c48
2025-06-13 13:23:30 +02:00
Martin Prikryl
9fe6c68712
Consistently calling command to open window with specific directory Explore, instead of sometimes Browse
...
Source commit: 92b4ed8c0495c1e8b8ad9817639438047f5028df
2025-03-07 01:03:11 +01:00
Martin Prikryl
dfad6d225a
"In background"
...
Note that the caption in Copy.dfm is actually not used
Source commit: b2343b4cef72c1f0d2286e54908167cc0875acb5
2025-02-15 00:59:57 +01:00
Martin Prikryl
3dcb30ca22
Issue 2342 – Command-line interface for installing public key into server
...
https://winscp.net/tracker/2342
Source commit: 4dee00b059312367058fa5bcccac2cc187ad14a3
2025-01-25 01:04:17 +01:00
Martin Prikryl
b0f03a87ba
But fix: On Windows 11, Windows 10 version was logged
...
As part of refactoring, calling GetProductInfo unconditionally as it should be supported on all Windows version we support
Also querying ProductName from 64-bit key, as JCL does (does not help with Windows 11 though)
Source commit: f5f6c075df730b9e5283d6490647bf0c11b23629
2024-11-28 01:03:15 +01:00
Martin Prikryl
64b618621c
Fixing ThemeDefaultFontSize counter after DefaultFont change in e55f27da
...
Source commit: c427a006cabb5892ff981110bc8769e495aca3d2
2024-11-21 13:52:45 +01:00
Martin Prikryl
1bd51d52d1
Updating DPI scaling to BCB11
...
– Control's Canvas does not have Font updated when painting, so it needs to be set explicitly in some places
– Page control drawing was not only incompatible, but broken in general, so it was refactored – giving up on trying to make it 100% mimic system drawing
– CM_DPICHANGED replaced with OnAfterMonitorDpiChanged for form-level scaling. Not really necessary, just for style. Though it is not called for initial resize (at least when starting on primary monitor with temporary non-system DPI)
– OnResize is not called for DPI change, so in some instances, some OnResize call was duplicated in OnAfterMonitorDpiChanged/CM_DPICHANGED
– Scaling of thirdparty box still does not work correctly (but Updates box works??)
– Scaling on primary monitor with temporary non-system DPI is bad
– TTreeView enabled DPI scaling when using Images that is not Scaled
– Discaring obsolete FSiteButtonsPadding workaround
– Controls programmatically added to form are automatically scaled to the form's DPI (relevant for message boxes)
Source commit: a86dddbfada30a5bc409687489bdcd12842050af
2024-11-08 10:55:22 +01:00
Martin Prikryl
e09e95ee43
Upgrade to C++ Builder 11
...
Comments:
- .res files seem to be linked automatically, so explicit entries in project files caused duplicates
- JCL updated for compatibility with BCB11 (jcld28win32.inc obtained by running JCJ installer [uninstalled afterwards])
Source commit: ec28d10a0bbb346ed2bb3940aed37e777342e663
2024-10-08 07:18:18 +02:00
Martin Prikryl
b30dc66c22
With /rawconfig, session is never opened in an existing instance
...
This "fixes" bug that causes opening session in an existing instance with /rawconfig preceding session url to fail, e.g.:
/rawconfig Interface\interface=1 /ini=nul user@example.com
Source commit: a2650dadde75a84ac165f87e4c9a0ca7d7515932
2024-06-30 00:59:24 +02:00
Martin Prikryl
5ec4b5f3e2
MsXmlInstalled counter
...
Source commit: 84cc0cfcdc172732da503134aee8faa67e62add0
2024-04-16 01:06:04 +02:00
Martin Prikryl
a76fa3af6d
Adding two more startup sequence counter steps between U and O and O and I
...
Source commit: 110ec6ba43bbf8270d36e06cde23053a31a76369
2023-10-04 01:05:09 +02:00
Martin Prikryl
d8afea474b
Bug 2211: Allow browsing a source folder/file instead of downloading when handling a download URL + Do not browse a source folders when download dialog is canceled
...
https://winscp.net/tracker/2211
This reimplements some functionality from 9015d810 , which was implemented in suspiciously complicate way for reasons I do not remember.
Source commit: e82be7ff99f61c1a7bdd4722fc9f47e533d7c2bc
2023-08-09 01:08:43 +02:00
Martin Prikryl
a3c314f69a
Without /newinstance, /rawsettings were ignored
...
Caused by Bug 2203
Source commit: 97e9fc7225b7e0aabc94d6d423cb1604531a7480
2023-08-08 01:07:01 +02:00
Martin Prikryl
a861304c62
Bug 2203: Handling download URL does not work when another idle instance is running
...
https://winscp.net/tracker/2203
Source commit: 93e13a59b293a22a2f9ba15e4dedbe880fa3a564
2023-07-01 01:08:34 +02:00
Martin Prikryl
247565d23b
Optimization in anticipation of having to parse commandline URL one more time
...
Source commit: bf2531704d0091b8015811da8ef58374c7516d71
2023-07-01 01:03:57 +02:00
Martin Prikryl
1b9b0ae27f
Memory leak (in console mode)
...
Source commit: aba7a64e81ddd7640fa68da889a1e459183118d6
2023-06-06 01:32:01 +02:00
Martin Prikryl
9dcaa8a7f3
Refactoring TTerminal::ReadFile + Adding TTerminal::TryReadFile + Solving memory leak on the way
...
Source commit: 4a5c5634006d2bd9a1c6c4831d0e528b91ecd9ae
2023-03-24 00:54:30 +01:00
Martin Prikryl
afe45263b1
Factoring out ConsumeParam
...
Source commit: a8d04d33391fed2ba6bf981426874a725bcdb3bf
2023-03-04 01:03:19 +01:00
Martin Prikryl
772e6a841f
Comment on possible optimization of FindOtherInstances
...
Source commit: 8d02d08992d111c7a63a90c90fe0877efac8bfd1
2023-02-02 00:58:26 +01:00
Martin Prikryl
75dd266823
Bug 83: MSI installation package
...
https://winscp.net/tracker/83
Source commit: 599e90f2406250f67542a77f1594218f68a7ac67
2022-11-11 08:03:59 +01:00
Martin Prikryl
4415c0b245
Pure virtual function call caused by 348396c1 (2nd)
...
Source commit: ab8c3743625999de60622fed053c2c5a971df12e
2022-10-21 08:17:29 +02:00
Martin Prikryl
01c3658c00
Pure virtual function call caused by 348396c1
...
Source commit: ed456191dc0c86ca12ab3387359c06f0ba794d46
2022-10-21 07:06:10 +02:00
Martin Prikryl
348396c188
StartupSecondsLastReal statistics
...
Source commit: e2ab2a3a8091faf710078834d0621a1237f187ee
2022-10-20 00:54:20 +02:00
Martin Prikryl
102cceafa4
Revert "Experimentally reading Store license"
...
This reverts commit fa1ac850da .
# Conflicts:
# source/windows/Setup.cpp
Source commit: f513d528028c9a0f64dc552f08023f1ea96a3781
2022-08-24 00:53:29 +02:00
Martin Prikryl
fa1ac850da
Experimentally reading Store license
...
Source commit: 01aed66d8e5d9169dce2416f1aa1a036cc959c05
2022-08-07 12:00:00 +02:00
Martin Prikryl
accd1bd7b0
Simplifying OpenSessionInPutty interface
...
Source commit: f557bf0896df48509e8dd443fe85fc7df186e261
2022-05-25 00:57:33 +02:00
Martin Prikryl
bd9060caee
RunsWithoutSession and SessionOpens counters
...
Source commit: a49a871dfdc90e9e9b9716ae16a987b4713bf3ec
2022-04-16 00:52:46 +02:00
Martin Prikryl
d284d93a83
Merge branch 'master' into dev
...
# Conflicts:
# source/forms/ScpCommander.cpp
# source/windows/WinConfiguration.h
Source commit: 6303fe6c4c5929ade1127007af6321e256f6940d
2022-03-30 01:23:44 +02:00
Martin Prikryl
15897f2339
Bug 2066: In .NET assembly or scripting with "nul" configuration, when WinSCP registry key does not exist, do not write statistics to INI file
...
https://winscp.net/tracker/2066
Source commit: 51f067850f46e2ad633d336b20183fa0955b33e0
2022-03-26 01:09:37 +01:00
Martin Prikryl
219bab96c7
Bug 2044: Provide private key as string in .NET assembly
...
https://winscp.net/tracker/2044
(cherry picked from commit 1018b272ea )
Source commit: 0c40d1ef172d932508fd1b89887ad2eefc5fbd26
2022-01-07 17:05:01 +01:00
Martin Prikryl
1018b272ea
Bug 2044: Provide private key as string in .NET assembly
...
https://winscp.net/tracker/2044
Source commit: f305e417f5775d6acfbd1d6ffb7580eefa52dbe3
2022-01-07 17:02:48 +01:00
Martin Prikryl
768c9c434f
StartupSequenceLast "counter"
...
(cherry picked from commit 620c75395e )
# Conflicts:
# source/forms/CustomScpExplorer.cpp
# source/forms/ScpCommander.cpp
Source commit: dab0d400d93273f4ed128511301ae4d91036a2d8
2021-12-23 00:51:32 +01:00
Martin Prikryl
620c75395e
StartupSequenceLast "counter"
...
Source commit: 3a063269a5737d209ba9f64472b73473191f5848
2021-12-23 00:48:46 +01:00
Martin Prikryl
958a9949c6
Bug 2052: File masks relative to the root of an operation
...
https://winscp.net/tracker/2052
(cherry picked from commit c5a60526ed )
Source commit: d1db6dd6b43b56565709801383e235ce4c6a1005
2021-12-15 01:11:42 +01:00
Martin Prikryl
c5a60526ed
Bug 2052: File masks relative to the root of an operation
...
https://winscp.net/tracker/2052
Source commit: 6c037285152e369af4f530849a09848f0b9be880
2021-12-15 01:01:06 +01:00
Martin Prikryl
efc0b60ad3
PackageName counter
...
(cherry picked from commit 0b71a67a0c )
Source commit: 851f47cdeb66f5b34162331cbbf566283d0c97c6
2021-11-30 00:53:45 +01:00
Martin Prikryl
0b71a67a0c
PackageName counter
...
Source commit: 22aab48a9c1c0e1c5ba681d98d9a161d0b6e33ce
2021-11-30 00:51:34 +01:00
Martin Prikryl
5084a88c9b
Reporting .NET Core and PowerShell Core versions
...
(cherry picked from commit acf90ead19 )
Source commit: 2bde644159225f28e26bdfc49cbd369cc8f83e22
2021-11-25 15:31:41 +01:00
Martin Prikryl
6afcf21ba4
Bug 2011: Use Documents folder when the last used local directory in Explorer interface does not exist anymore
...
https://winscp.net/tracker/2011
(cherry picked from commit 6f7bfc25c2 )
# Conflicts:
# source/forms/CustomScpExplorer.h
# source/forms/ScpCommander.h
Source commit: 34187d79c111047365d54103ddaffa7ed82f8d26
2021-07-28 00:55:32 +02:00
Martin Prikryl
6f7bfc25c2
Bug 2011: Use Documents folder when the last used local directory in Explorer interface does not exist anymore
...
https://winscp.net/tracker/2011
Source commit: 6606343f40107514e219d62ae31da10bea2452f1
2021-07-28 00:52:49 +02:00
Martin Prikryl
acf90ead19
Reporting .NET Core and PowerShell Core versions
...
Source commit: bc6c0efb5babfdfb95f78ee7cffcb38f4576ed14
2021-06-25 00:49:57 +02:00
Martin Prikryl
4c71ffa503
Bug fix: When "Keep remote directory up to date" function was started from command-line, disconnects were not detected. + Bug fix: When connection was lost, the "Keep remote directory up to date" window was not closed.
...
(cherry picked from commit 659e762068 )
Source commit: 4c29a0b6a90abac8dabfc04564cce64157665593
2021-06-16 14:38:28 +02:00
Martin Prikryl
659e762068
Bug fix: When "Keep remote directory up to date" function was started from command-line, disconnects were not detected. + Bug fix: When connection was lost, the "Keep remote directory up to date" window was not closed.
...
Source commit: 86d5431ba95c7f6d6682c219dd410b6ffa865d9d
2021-06-16 14:32:11 +02:00