Martin Prikryl
b13e2e7c2b
#pragma package(smart_init) is not useful out of packages
...
Source commit: 7635ac3b532214f27ea2b6fe6aa80398c857cfcd
2025-08-23 01:06:48 +02:00
Martin Prikryl
3817bbd736
Preparing for separate pre-compiled header file required by Clang
...
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang
Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
2025-08-22 15:43:55 +02:00
Martin Prikryl
94172541ab
Unused code
...
Source commit: 77715db778b119a33d8ac6c3fdfe407f6b22d5b0
2025-04-17 00:58:53 +02:00
Martin Prikryl
7b54dde3a6
Clang identifies some functions as "noreturn" + one noexcept(false)
...
Source commit: fc0c35fdddcd50a10d9ca13fc515164885325f81
2025-03-14 16:15:03 +01:00
Martin Prikryl
f7f00c631e
Clang imposed changes that should be noop and have no effect on classic compiler
...
Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
Source commit: 5c1338d95bd275082288dd1e773a033df6e379cd
2025-03-13 16:39:24 +01:00
Martin Prikryl
4019b56ffb
Code errors identified by Clang
...
Notably:
Bug fix: Monospace font is not remembered if SSH banners are administratively forced
Change: Bug fix: In XML log, filename tag was included in stat tag, although explicitly documented not to
Source commit: 693ecd9b083f1460dc4d1ae1ff49e625989f8a50
2025-03-13 06:36:08 +01:00
Martin Prikryl
e202af0bdc
Issue 2353 – Display and modify S3 file/object tags
...
https://winscp.net/tracker/2353
Source commit: 2193f9e58d66031ce58013da6a509090582addbe
2025-03-04 15:13:03 +01:00
Michael Lukashov
400bee57cf
minor: Fix typos ( #59 )
...
Fix various minor typos
2024-12-25 11:25:35 +01:00
Martin Prikryl
f93e07ca05
Removing some workarounds that are no longer needed in BCB11
...
- Not sure if the "push -vi" workaround was obsoleted by BCB11, but it does not seem to be needed anymore
- TCustomPathLabel.CMStyleChanged workaround was obsoleted by change in TCustomLabel.CMStyleChanged
- status bar scaling is not implemented in TCustomStatusBar.ChangeScale
Source commit: 7de59e2226d9d96aecb0fc78cef01a6bd6fce1d6
2024-11-27 00:56:18 +01:00
Martin Prikryl
156747a433
Issue 2307 – Preserve timestamp when duplicating remote file using SFTP extension copy-data (OpenSSH)
...
https://winscp.net/tracker/2307
Source commit: 2a1090a9bf935dfcd27605c77b241dff67b9dc2b
2024-08-15 01:23:20 +02:00
Martin Prikryl
7aa82b90fc
Issue 2247 – Limiting SFTP version to 3 with non-well-known SFTP servers as a workaround for interoperability issues
...
https://winscp.net/tracker/2247
Source commit: e8d26c68291db0390bae63e57c01f81200caff04
2024-07-23 00:55:30 +02:00
Martin Prikryl
ac41e22f0f
Typo in a comment
...
Source commit: c3daa22d88e613fc801d93075dca6814a8c7f83c
2024-03-23 01:07:55 +01:00
Martin Prikryl
ffb2a2baea
Issue 2277 – Fallback to nonresumable transfer when temporary target file cannot be created
...
https://winscp.net/tracker/2277
Source commit: 5dc9cbb007023bfc69566ca35d509d302b88e13b
2024-03-22 09:58:30 +01:00
Martin Prikryl
85f0e92ca6
Timeout* counters
...
Source commit: ac2610bb1cafef757caed4ecc5b46c9065e6c719
2024-03-21 12:43:55 +01:00
Martin Prikryl
da41b4f5c7
Unused parameter
...
Source commit: 9877cc4afa7299ddd6063d9180dacdf1c3a72857
2024-03-19 16:17:39 +01:00
Martin Prikryl
2103d78e54
Inlining function
...
Source commit: da7fbd11ff699b3c19438b19df3356827a3a02b0
2024-03-19 16:15:51 +01:00
Martin Prikryl
7ae34b8957
Limited SFTP upload queue length to avoid networking congestion
...
When uploading to ProFTPD mod_sftp in local Docker, the queue could be as long as 3000 requests, the TCP window as reported by Wireshark constantly full and re-transmitting, and eventually the server stops responding.
Source commit: 9ba6fd4a52c547db84da99b49779271b75fb0968
2024-03-19 16:13:39 +01:00
Martin Prikryl
0890a5d8cd
Issue 2272 – Workaround for SFTP servers (Cisco) which omit message field from status response
...
https://winscp.net/tracker/2272
Source commit: 05a580e1b0838268feddb314a93064a6d218bc2c
2024-03-09 01:26:43 +01:00
Martin Prikryl
ac633b2adf
Comment on possible use of SSH_FXF_RENAME_ATOMIC
...
Source commit: 2ecd6c6158c970b02a94775281d273806f62694e
2024-02-20 01:21:30 +01:00
Martin Prikryl
c96dcb4cfc
Issue 2259 – Badly encoded SFTP packet when renaming a file using SFTP version 5 and newer
...
https://winscp.net/tracker/2259
Source commit: 620f63fa2e340200805dd485fd863df808862731
2024-02-20 01:18:58 +01:00
Martin Prikryl
6368c3f192
Invalid assertion, caused by Issue 2235
...
Source commit: d92c8a0952390a65d49a2f2e61ebdea8e814b5ca
2024-02-20 01:16:23 +01:00
Martin Prikryl
3be9a70b6d
Preparing for Issue 2231 – Support for posix-rename@openssh.com SFTP extension
...
https://winscp.net/tracker/2231
Source commit: 4772cb75a566c3b93d175950806028a1ba56e9aa
2024-01-17 16:59:54 +01:00
Martin Prikryl
b333dd88af
There's no such comment
...
Source commit: e0e64482d0cd7b0a9ccb30f17257bba587e36404
2024-01-11 14:57:28 +01:00
Mikhail Lukashov
a8e6220b88
fix typos
2024-01-05 10:37:32 +01:00
Martin Prikryl
d23fa11d89
Dead link
...
Source commit: b4c4d1f085fc7b4b65129461583b9c657b466954
2023-12-07 01:05:07 +01:00
Martin Prikryl
9a06496936
Bug fix: When S3 or WebDAV server did not provide file timestamp, downloaded file was set to oldest possible timestamp
...
Source commit: cfb2d3d552d1c7d4192a6d152a9c4fd105f22484
2023-11-24 01:19:20 +01:00
Martin Prikryl
f320d89edd
Workaround for sudden internal compiler errors
...
Source commit: cade67a84eacc3608c6c0825543dc08dbb1e2a0b
2023-11-09 14:33:01 +01:00
Martin Prikryl
c824c40024
Code formatting
...
Source commit: 398e14a5ece1e453dc9a3182ab14b9265f0a965a
2023-11-07 01:54:08 +01:00
Martin Prikryl
ddca779622
Bug 2235: Failure when connection is lost while reading remote directory with SFTP protocol
...
https://winscp.net/tracker/2235
Source commit: fe8a892f071720efcd0c4e202cbad0cad920427d
2023-10-31 01:23:53 +01:00
Martin Prikryl
700baf45ee
Restoring consistent behavior of failing, between duplicating and moving/renaming files over existing file with WebDAV protocol in scripting and .NET assembly
...
The discrepancy was introduced by Bug 2120 cb021fe3 .
This restores the mv/MoveFile behavior to fail, if the target file exists with WebDAV protocol (but still allows overwrite in the GUI).
The cp/DuplicateFile behavior is unchanged, but the internal API was modified to match that of mv/MoveFile, in anticipation of aligning move/duplicate command behavior in GUI and need to keep current scripting/.NET behavior.
Source commit: 4661a3ea7ec8123231e376aae9913ce8457750dd
2023-10-25 01:43:14 +02:00
Martin Prikryl
c034f6c808
Bug 2222: Allow disabling SFTP extension use
...
https://winscp.net/tracker/2222
Source commit: 46cf6d64305cfb253f6b4c099633eec468c13c7b
2023-09-16 01:11:05 +02:00
Martin Prikryl
7240e942e9
Bug 2218: WinSCP could ask the server to return mode data during SFTP download than it can process
...
https://winscp.net/tracker/2218
Source commit: 5bd9afb1c64da8308dcc27640bd5cadead774709
2023-09-08 10:51:12 +02:00
Martin Prikryl
d8d0adfff6
Unused code
...
Source commit: 92f139605347f063d1c9f983c4ef6e1052ecd167
2023-09-08 10:49:13 +02:00
Martin Prikryl
7ce8405ee4
Bug 2214: Support appending when streaming file contents to remote server
...
https://winscp.net/tracker/2214
Source commit: e51a364e74262694fb8223e33c05354bb19b6315
2023-08-23 01:11:15 +02:00
Martin Prikryl
f2b2e1c80c
Parallel file transfers were not working with more than 2 connections
...
Source commit: d66d41ffd07c57867869e6e1f427f6a97f482ba0
2023-08-04 01:02:10 +02:00
Martin Prikryl
1aee6f1464
Bug 513: Download single large file using multiple SFTP connections
...
https://winscp.net/tracker/513
Source commit: d57dcad76dfe8b333dfedd8419bce984a181280c
2023-07-27 01:02:51 +02:00
Martin Prikryl
f4eb75d6c7
Using constants
...
Source commit: 8dbb493b32d49736f33a9418ea2f2f23595e661c
2023-06-29 01:04:56 +02:00
Martin Prikryl
dc21cb56f5
Using packet size limit announced by OpenSSH limits@openssh.com extension
...
Source commit: 2b73e78df6dea11af6add1f8527318d9803d6d0c
2023-06-10 08:20:15 +02:00
Martin Prikryl
cb89d8c879
Undoing probably unintended change from 263619a4
...
Source commit: 64e2bb1f9e33c10f70feeceeb3b3e3304c99d644
2023-06-06 15:05:47 +02:00
Martin Prikryl
9dcaa8a7f3
Refactoring TTerminal::ReadFile + Adding TTerminal::TryReadFile + Solving memory leak on the way
...
Source commit: 4a5c5634006d2bd9a1c6c4831d0e528b91ecd9ae
2023-03-24 00:54:30 +01:00
Martin Prikryl
8a509c67f0
Using SFTP copy-data extension to duplicate remote files with servers that do not support copy-file extension (OpenSSH)
...
Source commit: dbfe9deefcec50fc7ef5605fa539dabb71af4f2c
2023-02-08 01:08:44 +01:00
Martin Prikryl
4c64df473c
Not logging supported SFTP extensions included directly in SSH_FXP_VERSION response as unknown
...
Source commit: 867981901d8afd91db4d8a9e7c4f4089a5a07946
2023-02-08 01:06:27 +01:00
Martin Prikryl
390246710d
Typos in comments
...
Source commit: 740d9dd055b223ae63fa830787d850a66c02765f
2023-01-31 13:23:38 +01:00
Martin Prikryl
cb021fe3e3
Bug 2120: Consistent behavior across protocols when renaming/moving remote files
...
https://winscp.net/tracker/2120
Source commit: 0f11f96996352d8354d27e06d699e2c3baa4653f
2022-10-01 01:03:37 +02:00
Martin Prikryl
a9611d2185
Typo in session logging
...
Source commit: c2c2a74eaa3560ca37f192ba774aff2c76d19bb2
2022-09-06 14:58:25 +02:00
Martin Prikryl
8994d1f98e
Simplifying CalculateFilesChecksum API
...
There's a small side-effect: The scripting "checksum" command now prints file name only while before it printed the path as it was original specified in the command.
Source commit: 7594ed8befc67e4da3153cc8b1b711ab104db867
2022-07-14 00:57:43 +02:00
Martin Prikryl
1f30e227e9
Redundant calls to AbsolutePath
...
Source commit: b59a83297872509aa55685521ec2a8197e85ae88
2022-07-14 00:55:38 +02:00
Martin Prikryl
03e38c75ae
Refactoring checksum calculation to share more code between FTP and SFTP in anticipation of reusing it for SCP/Shell
...
Source commit: 9a5138737031573ad64085fa64ef8fdd7fca8f77
2022-07-02 01:05:31 +02:00
Martin Prikryl
31c422a290
Improving logging of skipped SFTP packets
...
Source commit: 1d22cd4126af6c7981ad7da922a119825323d1e5
2022-01-13 00:56:32 +01:00
Martin Prikryl
1659fb8b0f
Reseting packet data when dis/reconnecting
...
Source commit: ed6d240a51a4f563466dbdb45445231b728a86f8
2022-01-13 00:54:28 +01:00