1
0
mirror of https://github.com/winscp/winscp.git synced 2026-10-24 02:28:55 +03:00

68 Commits

Author SHA1 Message Date
Martin Prikryl
69edabbe2d Issue 2469 – Failure when using options in button drop down menus on Overwrite confirmation box
https://winscp.net/tracker/2469

Source commit: 51281856e8bae26ce21ae495f726c91a72f5ff03
2026-10-13 00:38:14 +02:00
Martin Prikryl
e13157118a Using themed button drop down menu on Overwrite confirmation box
Source commit: ca02aa76c6041990b5341fecf5f5c25f74a9b2a2
2026-09-30 00:37:29 +02:00
Martin Prikryl
55800c95bd Issue 2463 – Show keyboard accelerators on overwrite confirmation box when keyboard modifier is pressed
https://winscp.net/tracker/2463

Source commit: 493db416a23e77c36621f7443eafbcb685a3512a
2026-09-30 00:35:59 +02:00
Martin Prikryl
4057c84bfa Issue 2360 – Optionally do not show error message when connection is lost while idle
https://winscp.net/tracker/2360

Source commit: f4e51fcf1f07202811e4c5f9d2c5f3e777f71e33
2026-05-29 00:58:33 +02:00
Martin Prikryl
692b9bed5e Obsolete code (since 9db83971)
Source commit: dd5d0f560b5f5977c866ca501e530d8e1816ba3b
2026-05-29 00:53:51 +02:00
Martin Prikryl
b2c2f58d82 Issue 2430 – Some message boxes leak GDI handle
https://winscp.net/tracker/2430

Source commit: 69ea0f0bee6ac5efc8e0450c85152bb7f111bfbe
2026-03-25 01:28:15 +01:00
Martin Prikryl
a2119a7eac Types and casts safe in respect to pointer size for forward 64-bit compatibility
Also GetWindowLongPtr and GWLP_USERDATA

https://winscp.net/tracker/618

Source commit: c85fdf15e50ce8a6f35b1c4d2a0125a0b9c4f1f0
2026-01-22 14:51:13 +01:00
Martin Prikryl
e5efed8955 Refactoring old-style casts
Source commit: 3c37b3a958525c595ad44b081b2e0f3b288b8eb0
2025-12-18 01:20:33 +01:00
Martin Prikryl
a5dcb5f03c Using std::size instead of custom macro
Source commit: 1a89c80dd42426351f261526b617534bab664208
2025-12-07 01:17:54 +01:00
Martin Prikryl
c9ac0c1915 Removed obsolete "Preserve remote timestamp" session settings and other XP compatibility code
Source commit: 7cd7f54aae69fd36ea89a8d9ed043fc509bca5e3
2025-12-05 01:33:47 +01:00
Martin Prikryl
9bf5c52653 Issue 2413 – Message box texts and some control labels are not visible to screen readers + Improving order in which Windows Narrator reads window controls
https://winscp.net/tracker/2413

Source commit: 3d48f7f62c1879f32c0fe2df0f023f17f3847949
2025-11-28 11:15:42 +01:00
Martin Prikryl
632c9173ae Removing obsolete references to PNG
Source commit: 9debc05029a9a1d6c89d9dcced45185b1d8161f0
2025-09-03 16:52:49 +02:00
Martin Prikryl
3817bbd736 Preparing for separate pre-compiled header file required by Clang
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang

Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
2025-08-22 15:43:55 +02:00
Martin Prikryl
74fdf539de Clang imposed changes that should be noop and have no effect on classic compiler (2nd after 92ba1e3f0 + preceding commits)
Mostly
– explicit static global variables
– const, sign and down casts safety
– same-named variables in nested scopes
– incorrectly identified uninitialized variables
– semicolon after function implementation
– unused variables, fields, arguments and macros
– exact include filename case
– field initialization order
– typename use
– struct vs class declarations
– incorrectly identified uninitialized variables
– refactoring to solve Clang internal compiler error when using new variable in __finally block

Source commit: 3da995ff5169eefcfe3b3b7cc0d019c660096c07
2025-06-24 16:32:34 +02:00
Martin Prikryl
4705d456ba Bug fix: Host key prompt did not have the default button
(identified thanks to fixed assertion from 3fd70f41)

Source commit: 93ae375219314c5d4562f89492c47f188b923392
2025-06-24 11:50:39 +02:00
Martin Prikryl
3fd70f410e Minor code errors identified by Clang (2nd after 4019b56f)
Source commit: 904310464d998d3b8f222598c0b7914e6cb7deee
2025-06-24 01:03:19 +02:00
Martin Prikryl
6977f1cc67 Using native Windows dark theme for edits, memos, checkboxes and comboboxes
Buttons done in c1ccbe1e

Might also revert the combobox Style changes in TLoginDialog from a90827e6, if they have some negative side effects.
The dark mode now works without the change, if system theme is dark.

Part of Issue 1696.

Source commit: 2ce0e4b4c87878113010a06de4d51e1caf20df86
2025-05-23 22:08:15 +02:00
Martin Prikryl
c1ccbe1e60 Dark theme for buttons (part of Issue 1696)
https://winscp.net/tracker/1696

Source commit: 5e943294ff8381400e9eb40caf775e5fbc03a8be
2025-05-21 01:16:55 +02:00
Martin Prikryl
907f2ecf4c Dark theme for message boxes (part of Issue 1696)
https://winscp.net/tracker/1696

Source commit: 8922ca214bc7cb6b7f7accf19ec946763681650a
2025-05-08 00:58:16 +02:00
Martin Prikryl
d70637ea00 Bug fix: "Copy key fingerprints to clipboard" command link was scaled incorrectly
Source commit: b286435b157bb40f8523ad2a88b21894428aa1bf
2025-03-27 12:29:45 +01:00
Martin Prikryl
9485cb3f7d Switching to Segoe UI font with slightly larger size (9) as recommended for Windows Vista and newer + All windows are now slightly larger accordingly and their layout was unified
Reverts e55f27da
Fixing some anchors and tab order on the way
Dialogs (and controls with specific width or height) are now about 10% wider

Note that main form already used the Segoe UI:9 by explicitly using UseDesktopFont for most/all of its controls

Layout rules
- follow IDE design guidelines in general
- controls start at 8x8, but at 9x9 in group boxes and 22v if group has title
- right and bottom padding in groupbox is the same as left padding
-for checkboxes the bottom padding of the checkmark is the same as left padding = 10
- buttons are 80x25 by default, with +14v with dropdown
- checkboxes/radiobuttons are +2h
- labels are 15 high, textboxes/comboxes 23
- indentation is controls under checkboxes is +16h

Source commit: 09a558e92af838e142d3624cb433cc052782881c
2025-01-16 16:27:20 +01:00
Martin Prikryl
9345fadc52 Removing redundant Windows XP-compatibility code (BCB11 does not support XP)
Source commit: 6442ebecf7dd5c6f45ffa9ef4ea34b82cf7ac95a
2024-11-28 00:55:43 +01:00
Martin Prikryl
b26744fa73 Unneeded include added in e55f27da but not removed in 1bd51d52
Source commit: c1bfde951aa9031118ce78a856a98079a58cb1c9
2024-11-22 09:19:29 +01:00
Martin Prikryl
31d349b029 Correcting scaling of update panels
(download progress and donate pledge)

Source commit: 3b541cc28d62695ad886e7011e3dc2d62b589b8f
2024-11-14 00:58:31 +01:00
Martin Prikryl
1bd51d52d1 Updating DPI scaling to BCB11
– Control's Canvas does not have Font updated when painting, so it needs to be set explicitly in some places
– Page control drawing was not only incompatible, but broken in general, so it was refactored – giving up on trying to make it 100% mimic system drawing
– CM_DPICHANGED replaced with OnAfterMonitorDpiChanged for form-level scaling. Not really necessary, just for style. Though it is not called for initial resize (at least when starting on primary monitor with temporary non-system DPI)
– OnResize is not called for DPI change, so in some instances, some OnResize call was duplicated in OnAfterMonitorDpiChanged/CM_DPICHANGED
– Scaling of thirdparty box still does not work correctly (but Updates box works??)
– Scaling on primary monitor with temporary non-system DPI is bad
– TTreeView enabled DPI scaling when using Images that is not Scaled
– Discaring obsolete FSiteButtonsPadding workaround
– Controls programmatically added to form are automatically scaled to the form's DPI (relevant for message boxes)

Source commit: a86dddbfada30a5bc409687489bdcd12842050af
2024-11-08 10:55:22 +01:00
Martin Prikryl
e55f27dab3 Temporary reverting font to Tahoma:8 (from default BCB 11's Segoe UI:9) to match the windows layout
Source commit: 815a497dffe349865a283f50ec0cd4af92cb3489
2024-10-08 15:54:52 +02:00
Martin Prikryl
e3fe05fcbb Bug 2217: Make it harder to mis-click "never show this again" checkboxes
https://winscp.net/tracker/2217

Source commit: 7157c1f4fe74785f34861fd9f24c4c03042e4588
2023-09-21 01:10:05 +02:00
Martin Prikryl
e78ae6176e Bug 2125: Displaying current version on the New version notification + Contents of About dialog can be copied to the clipboard using Ctrl+C
https://winscp.net/tracker/2125

Source commit: 50ae66db19efb1f756ea809faad22a8067d53bff
2022-11-02 00:56:38 +01:00
Martin Prikryl
2a76666746 Logging copying message to the clipboard
Source commit: 4a090df405fad6dd77ac78a2137fab9147f0e92d
2022-10-04 00:56:56 +02:00
Martin Prikryl
40610fe53a Reusing IsWin7
Source commit: 80b1b3d54407fc8a48f75eca48aaff0c65f43a2f
2022-09-15 00:57:18 +02:00
Martin Prikryl
b9a9cfa50c Merge branch 'master' into dev
Source commit: 46d31327b2f29f54055605f32465a7d39dcc65ab
2020-05-01 01:31:50 +02:00
Martin Prikryl
5f7c2dd1d6 Set Parent before Name
Might help with:
https://winscp.net/forum/viewtopic.php?p=97914#97914
Emails with Harrison Uhl

Source commit: 6d9914af386132f3613e33694e468a81359d5fab
2020-04-30 01:47:42 +02:00
Martin Prikryl
1fe119535a Bug 1842: Support SHA-256 fingerprints of TLS/SSL certificates
https://winscp.net/tracker/1842

Source commit: 66b808783a0b67b0277fff65af905cb132573175
2020-03-31 02:25:42 +02:00
Martin Prikryl
71f6619a22 Removing NO_RESOURCES conditional block
(used for Salamander only)

Source commit: 84fceaacd30a1740e2d6bba49b9e9f2fc57574f4
2019-11-19 01:01:35 +01:00
Martin Prikryl
e6f20b672c Making more space for long donate/buy pledges
(cherry picked from commit 99972dbf76)

Source commit: bc5991492c37419b30bff81cf894f8e975ce6204
2019-04-12 16:11:52 +02:00
Martin Prikryl
ec5977ba27 Improved design of About window
Source commit: 68b9244ac13c1cbdce21302eba27d774983358b6
2018-09-04 01:27:18 +02:00
Martin Prikryl
93719a3d7b Unused variable
Source commit: 69349feeb0f4701111b42e3132b0ffdd69ba75db
2018-01-28 17:34:47 +01:00
Martin Prikryl
e3dc7f5d84 Commands to copy hostkey/certificate fingerprint to clipboard hs a form of a link, instead of a message button + Changed appearance of background confirmation options link
Source commit: f879203973f823de535a1b7f4ed3c30b79fc6f93
2018-01-28 17:29:01 +01:00
Martin Prikryl
868ef381ee Bug 1563: Allow verifying SSH host key by pasting the expected key or its fingerprint from the clipboard
https://winscp.net/tracker/1563

Source commit: 3205dd4eb285e9cd5a7dbaaf9dc9f46dcd0e94dc
2018-01-28 13:49:52 +01:00
Martin Prikryl
eafabd97e5 Bug 1524: Option to open downloaded file on operation completion confirmation when transferring file from command-line/URL + Logging destination file + Bug fix: When opening local folder in explorer fails, error message ID was shown instead of actual message. + Refactored ShowExtendedExceptionEx
https://winscp.net/tracker/1524

Source commit: ba2f26e59a60311bf483a9456324cbdd5494e3dc
2018-01-28 06:22:06 +01:00
Martin Prikryl
07617815a6 Bug 1521: Provisional implementation of per-monitor DPI awareness
https://winscp.net/tracker/1521

Source commit: 9d436d711a74909662530049c1de501edb91ab3a
2018-01-28 06:03:34 +01:00
Martin Prikryl
d61db8bd36 Updating links
Source commit: 0c2068c7fa3a816e230addb18fc900a699c9256b
2018-01-28 01:51:32 +01:00
Martin Prikryl
4095f2711a Failure when showing error message before configuration is even created
Source commit: 2116eb044dbf6857dcb21e686aaf74804745c330
2018-01-28 00:47:56 +01:00
Martin Prikryl
28c6413f64 Bug 1476: Do not popup Authentication window when reconnecting while the application is minimized
https://winscp.net/tracker/1476

Source commit: 352bca46e366fa729a9f88416e9e30a786df4104
2018-01-27 22:35:43 +01:00
Martin Prikryl
4c3afd30d8 Re-implementing language autodetection for the "Translations" subfolder + Unless user customizes language, automatically using the best language match each run + Including all translation (30% at least) in installation, but automatically using only those that are complete (80% at least) + Marking the default, incomplete and invalid languages in Preferences dialog + Using applied language, instead of configured language in URLs and counters
Source commit: ad428b3c09a9e0081b84b8090100d62d1edf39f4
2018-01-27 09:53:25 +01:00
Martin Prikryl
30d153f788 The OK button on debug log information message was not "cancel" button
Source commit: f14c93c89770f8b49e0315eea2f198194a3f12b8
2018-01-25 18:51:23 +01:00
Martin Prikryl
8e3c6db001 Displaying information about tracing and reporting and exploring the log file when the application closes
Source commit: 167b90f73ae34a7fbc3be33c6b88c158991c3163
2018-01-25 16:22:12 +01:00
Martin Prikryl
35f19fc795 Factoring out LocaleHex
Source commit: 7e8eeba7ccaacd0d0b3b07f0d9c05bf089c6594c
2018-01-25 13:12:04 +01:00
Martin Prikryl
b46c67a818 Bug fix: Too long automatic bug reports were rejected
Source commit: 4c8d01d3d93424803453cd44f0ebb8ec0fd3735a
2018-01-25 11:51:23 +01:00
Martin Prikryl
b55e9565da Function call-line syntax for DebugFail + Replacing all DebugAssert(false) with DebugFail
Source commit: 358df59fa46a04bd1b2a141b826fa5c499303ae6
2018-01-24 20:47:51 +01:00