- regarding the ILINK_LibraryPath for Cfg_1_Win32 (Debug):
Win32\Debug (not only Win32c\Debug) needs to be before Win32c\Release, as win32c does not include debug builds of Pascal code - so without that VCL debugging won't work
- IDE insist on adding CC_Suffix to all projects once switched to Clang, although it is only used in WinSCP.cbproj
- UNICODE define: Not needed for build (it's implicit), but CodeInsight does not know it it somehow
Source commit: da06d73eb86caff5ca9cac0185bed54da0da8f07
- Once doing that, including more headers to PCH, not just vcl.h
- Clang won't need explicit include, but we will probably keep it anyway.
- #pragma hdrstop has no effect in Clang
Source commit: adc8a268b6907c5337ccaa430cca7526793a3019
Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
Source commit: 5c1338d95bd275082288dd1e773a033df6e379cd
Master password encryption was broken ever since it was introduced by PuTTY snapshot 6c924ba
For the time being, postponing repimplementation of master password for new PuTTY API until later
Source commit: ecf245f37434ff7adc84e4ebed818c9195df0e75
What is pending:
- AES is now again compiled using Borland compiler (previously by VS)
- Add support for HW SHA
What is lost and needs to be re-implemented:
- Custom fixes for vulnerabilities fixed in PuTTY 0.71 (will be added implicitly, once merge of PuTTY 0.71 is complete)
- callback.c is now locked more heavily - should be optimized.
Note: Or would-be thread-safety changes to callback.c were obviously not thread safe as they would call callbacks for other sessions from thread for another session (as there's only one callback queue) - This needs to be solved
# Conflicts:
# source/putty/WINDOWS/wingss.c
# source/putty/WINDOWS/winhsock.c
# source/putty/WINDOWS/winnet.c
# source/putty/callback.c
# source/putty/proxy.c
# source/putty/putty.h
# source/putty/ssh.c
# source/putty/ssh.h
# source/putty/sshaes.c
# source/putty/sshdh.c
# source/putty/sshpubk.c
# source/putty/sshrsa.c
# source/putty/sshsh256.c
# source/putty/version.h
# source/putty/x11fwd.c
Source commit: d7d9798d5b0c01f4a797d0a2ace8856e32909158
