Martin Prikryl
3f4e41fee0
Clang imposed changes that should be noop and have no effect on classic compiler
...
Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
(cherry picked from commit f7f00c631e
2025-03-13 16:46:26 +01:00
Martin Prikryl
8cd48fd0e5
Code errors identified by Clang
...
Notably:
Bug fix: Monospace font is not remembered if SSH banners are administratively forced
Change: Bug fix: In XML log, filename tag was included in stat tag, although explicitly documented not to
(cherry picked from commit 4019b56ffb
2025-03-13 06:42:18 +01:00
Mikhail Lukashov
a8e6220b88
fix typos
2024-01-05 10:37:32 +01:00
Martin Prikryl
46bd5c5396
Bug 2224: Recognize IP addresses starting with zero in FTP PASV response as unroutable
...
https://winscp.net/tracker/2224
Source commit: ad239582183c57611fbb6a66f7bd32caecee80ed
2023-09-29 01:01:48 +02:00
Martin Prikryl
266b470cf8
Using tolower and towupper
...
Source commit: 9679e092efa1a4683538eb9b46374f90b5699ab3
2023-08-19 01:13:29 +02:00
Martin Prikryl
1577b39b76
Bug 2194: Support for ProFTPD command OPTS REST STOR to query if upload restart is possible
...
https://winscp.net/tracker/2194
Source commit: 6b8e7e9e8d046a5a45f6ae586cb8ad9d5b61f09a
2023-06-08 01:04:28 +02:00
Martin Prikryl
ddd3256919
Bug 2132 ( de072c6e) broke download transfer resume
...
Source commit: a87af8cf7efcabaf15945ef90cd6527224f8f1bf
2022-11-11 13:03:02 +01:00
Martin Prikryl
de072c6ebd
Bug 2132: Do not overwrite existing local file when FTP download fails to start
...
https://winscp.net/tracker/2132
Source commit: f744f31a345e0d1e4c22142fed91cbf3dcb58ea3
2022-11-11 08:37:57 +01:00
Martin Prikryl
ac251a7309
Bug 2084: Do not list remote directory when downloading file using FTP protocol with overwrite confirmations off
...
https://winscp.net/tracker/2084
Source commit: 0c6aef0f33c1ffa0791b3a778648058de4e19500
2022-06-08 01:03:08 +02:00
Martin Prikryl
b62d433c40
Invalid FTP response was incorrectly logged when closing transfer connection (caused by cee1be5d)
...
Source commit: 058b686e4addddc869a112d728f849b9c151fafd
2022-06-08 00:59:22 +02:00
Martin Prikryl
52a5598429
Indentation
...
Source commit: 22ec7577a3991c09782813017d7a90500bf2a744
2022-06-08 00:57:32 +02:00
Martin Prikryl
cee1be5d62
Bug 2077: Improve error message when FTP server returns malformed response
...
https://winscp.net/tracker/2077
Source commit: fcf4ac3e67bfc4f877167881157278f1e28650db
2022-05-21 00:54:21 +02:00
Martin Prikryl
85b1e9cb3d
Optimizing use of USES_CONVERSION
...
Source commit: 41bec5877bfdf64a71ff054abe8849b94744330f
2022-05-17 12:29:49 +02:00
Martin Prikryl
cded95d85c
Uninitialized variable (from 9370bfd1)
...
Source commit: 34d32304fe796f5f9bf2426e61b7b58de380cf89
2022-05-02 12:28:10 +02:00
Martin Prikryl
37b2fd0ee0
Typo in a comment
...
Source commit: d2c068498e9fa84947bab56f8ffe96e37f8be091
2022-04-29 16:25:26 +02:00
Martin Prikryl
9370bfd17f
Bug 1945: Streaming support in .NET assembly for FTP protocol
...
https://winscp.net/tracker/1945
Source commit: 01274024eff31ef3f5794f3521689b4c2229acbb
2022-04-29 16:21:05 +02:00
Martin Prikryl
c9ff66a226
Factoring out CheckOverwriteFileAndCreateTarget and FileTransferHandleDirectoryListing
...
Source commit: 0d9d7f19f748e6cffb0931db05fcd314814af3cb
2022-04-28 00:58:45 +02:00
Martin Prikryl
b89afec307
Bug 2069: Improve compatibility with MVS systems (2nd)
...
https://winscp.net/tracker/2069
Source commit: 325a57bef47a52ab2c8ff8d7dda1e346a9921c9f
2022-04-26 01:05:05 +02:00
Martin Prikryl
191729720a
Bug 2065 – Scripting command "ls" in FTP session displays timestamps without year even if the server (notably IIS) provided the year, if it did not provide seconds
...
https://winscp.net/tracker/2065
Source commit: 4d719f707f54a5ce7d1ff2ad327a1159ccb3fefe
2022-03-26 01:07:27 +01:00
Martin Prikryl
eea7456b1d
Removing unused parts of MFC and replacing rarely used parts with other implementations
...
(cherry picked from commit 3f3d21f04b
2022-01-20 17:19:10 +01:00
Martin Prikryl
81337cdcc5
Bug 2034: Custom certificate store file
...
https://winscp.net/tracker/2034
(cherry picked from commit e70fd8fa51
2021-11-26 14:31:01 +01:00
Martin Prikryl
b045f97c36
Bug fix: FTP keepalive command was sometime sent right after the transfer finished
...
(cherry picked from commit 76d5949248
2021-11-23 15:43:24 +01:00
Martin Prikryl
f7e1c07cd8
Limiting scope of Bug 2030 (Timeout while uploading files to some FTP servers using TLS 1.3) to affected servers only
...
https://winscp.net/tracker/2030
(cherry picked from commit 12a3508797
2021-10-11 15:35:25 +02:00
Martin Prikryl
3d2acab1f1
Logging failed/complete was logged reversed
...
(cherry picked from commit 1d5793c336
2021-10-05 00:53:33 +02:00
Martin Prikryl
f46416fe9f
Links updates (tools.ietf.org => datatracker.ietf.org)
...
Source commit: 8647458b07e32ff872d96e60326ce65a261a6a59
2021-05-24 08:54:32 +02:00
Martin Prikryl
58a103fb76
Probably invalid assertion
...
(cherry picked from commit 006d280285
2021-05-20 00:53:42 +02:00
Martin Prikryl
3e3284eae4
Bug 1982: Automatically resume transfer when TLS re-key fails
...
https://winscp.net/tracker/1982
(cherry picked from commit 64a802c4fa
2021-05-06 11:45:37 +02:00
Martin Prikryl
f8522e8ff6
Bug 1976: Failure when retrieving a directory listing from an FTP server when the data are transmitted in huge amount of tiny chunks
...
https://winscp.net/tracker/1976
(cherry picked from commit a7e68c3d79
2021-04-15 00:52:25 +02:00
Martin Prikryl
37f99ed652
Bug fix: Canceled or failed FTP transfer caused connection loss
...
Caused by Bug 1878.
Source commit: 06642136cb284bbae9b6ebcecd86ad190aa98ba0
2021-03-04 00:49:19 +01:00
Martin Prikryl
e757f7b77b
Bug 1950: Parsing of multiline VMS FTP listing entries is broken
...
https://winscp.net/tracker/1950
(cherry picked from commit 517fac5f1f
2021-02-04 00:59:09 +01:00
Martin Prikryl
db8ea994f3
Correcting MLST parsing (from fa0ed3c5)
...
Is probably noop, but previous version was badly designed at least
(cherry picked from commit a8bd2dad09
2021-02-04 00:54:09 +01:00
Martin Prikryl
80bfb0d992
Bug 1921: Allow forcing use of LIST command to retrieve file information in scripting for FTP servers that has broken support for MDTM/SIZE commands
...
https://winscp.net/tracker/1921
(cherry picked from commit 7e78952092
2020-11-26 16:45:53 +01:00
Martin Prikryl
8bd1803937
Removing unused code to select local port of outgoing FTP control connections
...
(cherry picked from commit 2cfd5c8f92
2020-11-26 15:59:38 +01:00
Martin Prikryl
880cbc8054
Logging FTP control connection reading
...
(cherry picked from commit 464cb98038
2020-11-26 15:30:41 +01:00
Martin Prikryl
a9a3bb04e4
Logging successful FTP connection
...
(cherry picked from commit afa2cd3344
2020-11-26 15:11:58 +01:00
Martin Prikryl
551eedd209
Bug 1895: Support for SNI with FTP (2nd)
...
https://winscp.net/tracker/1895
(cherry picked from commit a25c55a621
2020-11-26 14:21:59 +01:00
Martin Prikryl
253fb4dcd5
Bug 1878: Resume transfer when FTP data connection disconnects
...
https://winscp.net/tracker/1878
(cherry picked from commit 022dcddf97
2020-11-26 13:06:20 +01:00
Martin Prikryl
2863974af7
Fixing logging of FTP transfer failures from b0fc69f9
...
(cherry picked from commit 0f172d36c3
2020-11-26 13:04:56 +01:00
Martin Prikryl
55cf8d758c
Improving logging of FTP transfer failures (4th)
...
(cherry picked from commit b0fc69f930
2020-11-26 12:56:34 +01:00
Martin Prikryl
6b5f1cf732
Improving logging of FTP transfer failures (3rd)
...
(cherry picked from commit 15fe4d914c
2020-11-26 12:55:11 +01:00
Martin Prikryl
e0f57ad80e
Whitespace
...
(cherry picked from commit 9d63dc6289
2020-11-26 12:48:03 +01:00
Martin Prikryl
f921e2ad35
Improving logging of FTP transfer failures (2nd)
...
(cherry picked from commit 18d386923d
2020-11-26 12:46:41 +01:00
Martin Prikryl
2d626d6534
Improving logging of FTP transfer failures
...
(cherry picked from commit 14add145f2
2020-11-26 12:45:16 +01:00
Martin Prikryl
0e4e2e6bc8
It is possible to configure TLS 1.3 restrictions
...
(+ reusing SetupSsl for FTP)
Source commit: 426bf5c70861f8a2964967d32ef5b5e36bbb1ac6
2020-02-12 00:52:11 +01:00
Martin Prikryl
270d8018f4
Bug 1796: Allow empty password authentication with FTP servers that prompt for empty passwords
...
https://winscp.net/tracker/1796
Source commit: de30b2df2f7765dc01f9dbd551264240d1e0ce37
2019-10-08 01:28:05 +02:00
Martin Prikryl
53752ef745
Bug 1546: On VMS servers, do not use absolute paths with DELE command + OpenedSessionsFTPVMS counter
...
https://winscp.net/tracker/1546
Source commit: 8b06f73b41fd969cfd5bc9abe7bacb23d8cfb4aa
2018-01-28 08:13:23 +01:00
Martin Prikryl
50ceaef542
Bug 1535: Do not terminate path with slash in CWD FTP command for better compatibility with VMS systems
...
https://winscp.net/tracker/1535
Source commit: 788d6278bdb6323693356499051b92dcb7cf4dd1
2018-01-28 07:15:34 +01:00
Martin Prikryl
b3ce6ef286
Removing wrong comment that should already have been deleted in 2f04f171e5 (Bug 1520: Resuming file upload in active FTP mode does not work on some servers)
...
Source commit: dc2ceffe437a6e2d2d7dc1de94b4569687c11630
2018-01-28 06:26:03 +01:00
Martin Prikryl
2f04f171e5
Bug 1520: Resuming file upload in active FTP mode does not work on some servers
...
https://winscp.net/tracker/1520
Source commit: afc9ffb1285b87147aaa223a89c65b26fbd0af0f
2018-01-28 05:56:58 +01:00
Martin Prikryl
ce37006614
Bug 1518: Do not verify that final path after CWD FTP command matches requested path to allow better compatibility with atypical FTP servers
...
https://winscp.net/tracker/1518
Source commit: 8f557d4d2b693052bb9ba7e533699e26e20e6c68
2018-01-28 05:42:46 +01:00
