Mostly:
– incorrectly identified uninitialized variables
– explicit static global variables
– const, sign and down casts and safety
– typename use
– semicolon after function implementation
– unused variables, fields, arguments and macros
– field initialization order
– exact include filename case
– redundant in code macros already defined at project level
(cherry picked from commit f7f00c631e)
Source commit: 90ad9390853aba308abe73cf02e0281238c53c87
Master password encryption was broken ever since it was introduced by PuTTY snapshot 6c924ba
For the time being, postponing repimplementation of master password for new PuTTY API until later
Source commit: ecf245f37434ff7adc84e4ebed818c9195df0e75
What is pending:
- AES is now again compiled using Borland compiler (previously by VS)
- Add support for HW SHA
What is lost and needs to be re-implemented:
- Custom fixes for vulnerabilities fixed in PuTTY 0.71 (will be added implicitly, once merge of PuTTY 0.71 is complete)
- callback.c is now locked more heavily - should be optimized.
Note: Or would-be thread-safety changes to callback.c were obviously not thread safe as they would call callbacks for other sessions from thread for another session (as there's only one callback queue) - This needs to be solved
# Conflicts:
# source/putty/WINDOWS/wingss.c
# source/putty/WINDOWS/winhsock.c
# source/putty/WINDOWS/winnet.c
# source/putty/callback.c
# source/putty/proxy.c
# source/putty/putty.h
# source/putty/ssh.c
# source/putty/ssh.h
# source/putty/sshaes.c
# source/putty/sshdh.c
# source/putty/sshpubk.c
# source/putty/sshrsa.c
# source/putty/sshsh256.c
# source/putty/version.h
# source/putty/x11fwd.c
Source commit: d7d9798d5b0c01f4a797d0a2ace8856e32909158
