1
0
mirror of https://github.com/winscp/winscp.git synced 2026-10-24 02:28:55 +03:00

Code errors identified by Clang

Notably:
Bug fix: Monospace font is not remembered if SSH banners are administratively forced
Change: Bug fix: In XML log, filename tag was included in stat tag, although explicitly documented not to

(cherry picked from commit 4019b56ffb)

Source commit: 8f8d10bc0c9f4ca626dceda1d3e9889dc22f4394
This commit is contained in:
Martin Prikryl
2025-03-12 16:08:19 +00:00
parent ee99cb926e
commit 8cd48fd0e5
17 changed files with 34 additions and 25 deletions

View File

@@ -1858,7 +1858,8 @@ static _di_IXMLNode S3NeedNode(const _di_IXMLNodeList & NodeList, const UnicodeS
//---------------------------------------------------------------------------
#define COPY_BUCKET_CONTEXT(BucketContext) \
{ BucketContext.hostName, BucketContext.bucketName, BucketContext.protocol, BucketContext.uriStyle, \
BucketContext.accessKeyId, BucketContext.secretAccessKey, BucketContext.securityToken, BucketContext.authRegion }
BucketContext.accessKeyId, BucketContext.secretAccessKey, BucketContext.securityToken, BucketContext.authRegion, \
BucketContext.service }
//---------------------------------------------------------------------------
bool TS3FileSystem::DoLoadFileProperties(
const UnicodeString & AFileName, const TRemoteFile * File, TS3FileProperties & Properties, bool LoadTags)
@@ -2155,7 +2156,7 @@ void __fastcall TS3FileSystem::LoadFileProperties(const UnicodeString AFileName,
Data.Result = DoLoadFileProperties(AFileName, File, Properties, Data.LoadTags);
if (Data.Result)
{
bool AdditionalRights;
bool AdditionalRights = false;
unsigned short Permissions = 0;
for (int Index = 0; Index < Properties.AclGrantCount; Index++)
{