sysutils/winscp
1
0
Fork 0
mirror of https://github.com/winscp/winscp.git synced 2026-10-24 02:28:55 +03:00
Code Activity

Bug 2155: Warn when user selects too verbose logging level that degrades performance

Browse Source 
https://winscp.net/tracker/2155

Source commit: 4c143ba2ead19b56d281ab2549cbb0ff46a3a13f
This commit is contained in:
Martin Prikryl
2023-01-06 15:06:15 +00:00
parent 24ba10777f
commit 8250abd12d
3 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/forms/Preferences.cpp
View File

@@ -1450,6 +1450,8 @@ void __fastcall TPreferencesDialog::UpdateControls()
EnableControl(ActionsLogFileNameEdit, EnableActionsLoggingCheck->Checked);
EnableControl(ActionsLogFileNameHintText, ActionsLogFileNameEdit->Enabled);
LogProtocolHintLabel->Visible = (LogProtocolCombo2->ItemIndex - BelowNormalLogLevels >= 2);
// interface
InterfaceChangeLabel->Visible =
!CustomWinConfiguration->CanApplyInterfaceImmediately &&

16
source/forms/Preferences.dfm
View File

@@ -55,7 +55,7 @@ object PreferencesDialog: TPreferencesDialog
Top = 0
Width = 413
Height = 432
ActivePage = PreferencesSheet
ActivePage = LogSheet
Align = alClient
MultiLine = True
Style = tsButtons
@@ -271,6 +271,18 @@ object PreferencesDialog: TPreferencesDialog
DesignSize = (
405
422)
object LogProtocolHintLabel: TLabel
Left = 8
Top = 303
Width = 389
Height = 33
AutoSize = False
Caption =
'The selected logging level severely degrades performance. Use it' +
' when troubleshooting only.'
ShowAccelChar = False
WordWrap = True
end
object LoggingGroup: TGroupBox
Left = 8
Top = 8
@@ -505,7 +517,7 @@ object PreferencesDialog: TPreferencesDialog
422)
object InterfaceChangeLabel: TLabel
Left = 8
Top = 280
Top = 282
Width = 177
Height = 13
Caption = 'Changes will apply on the next start.'

1
source/forms/Preferences.h
View File

@@ -341,6 +341,7 @@ __published:
TUpDownEdit *LocalPortNumberMinEdit;
TUpDownEdit *LocalPortNumberMaxEdit;
TCheckBox *AlwaysSortDirectoriesByNameCheck;
TLabel *LogProtocolHintLabel;
void __fastcall FormShow(TObject *Sender);
void __fastcall ControlChange(TObject *Sender);
void __fastcall EditorFontButtonClick(TObject *Sender);