sysutils/winscp
1
0
Fork 0
mirror of https://github.com/winscp/winscp.git synced 2026-10-24 02:28:55 +03:00
Code Activity

Resolving version of pwsh installed with MSIX

Browse Source 
Source commit: c40566cc3ef7398359718b7a2cd50d709e844544
This commit is contained in:
Martin Prikryl
2026-07-24 14:44:13 +00:00
parent b9307ef5f8
commit 648b6c0a97
1 changed files with 79 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
source/windows/Setup.cpp
View File

@@ -21,6 +21,7 @@
#include <Web.HTTPApp.hpp>
#include <WinApi.h>
#include <System.NetEncoding.hpp>
#include <appmodel.h>
//---------------------------------------------------------------------------
#define KEY L"SYSTEM\\CurrentControlSet\\Control\\Session Manager\\Environment"
// when the PATH registry key is over aprox 2048 characters,
@@ -2369,28 +2370,90 @@ UnicodeString GetPowerShellCoreVersionStr()
{
if (PowerShellCoreVersionStr.IsEmpty())
{
PowerShellCoreVersionStr = L"0"; // not to retry on failure
UnicodeString UnknownVersion = L"0";
PowerShellCoreVersionStr = UnknownVersion; // not to retry on failure
unsigned int Access = KEY_READ | KEY_WOW64_64KEY;
std::unique_ptr<TRegistry> Registry(new TRegistry(Access));
Registry->RootKey = HKEY_LOCAL_MACHINE;
UnicodeString RootKey(L"SOFTWARE\\Microsoft\\PowerShellCore\\InstalledVersions");
if (Registry->OpenKeyReadOnly(RootKey))
UnicodeString FamilyNamePrefix = "Microsoft.PowerShell";
UnicodeString FamilyNameSuffix = "8wekyb3d8bbwe";
wchar_t Sep = L'_';
UnicodeString FamilyName = FamilyNamePrefix + Sep + FamilyNameSuffix;
UnicodeString Prefix = FamilyNamePrefix + Sep;
UnicodeString Suffix = UnicodeString(Sep) + FamilyNameSuffix;
UINT32 Count = 0;
UINT32 BufferLength = 0;
LONG Res = GetPackagesByPackageFamily(FamilyName.c_str(), &Count, nullptr, &BufferLength, nullptr);
if ((Res == ERROR_INSUFFICIENT_BUFFER) && (Count > 0))
{
std::unique_ptr<TStringList> Keys(new TStringList());
Registry->GetKeyNames(Keys.get());
Registry->CloseKey();
for (int Index = 0; Index < Keys->Count; Index++)
std::vector<PWSTR> FullNames(Count);
std::vector<WCHAR> Buffer(BufferLength);
Res = GetPackagesByPackageFamily(FamilyName.c_str(), &Count, FullNames.data(), &BufferLength, Buffer.data());
if (Res == ERROR_SUCCESS)
{
UnicodeString Key = RootKey + L"\\" + Keys->Strings[Index];
if (Registry->OpenKeyReadOnly(Key))
// While there can be multiple packages, they either be 32 and 64 versions of the same repeease,
// or temporarily two releases, the moment upgrade is taking place. Either is not worth dealing with.
PWSTR FullName = FullNames[0];
UINT32 PathLength = 0;
Res = GetPackagePathByFullName(FullName, &PathLength, nullptr);
if (Res == ERROR_INSUFFICIENT_BUFFER)
{
UnicodeString VersionStr = Registry->ReadString(L"SemanticVersion");
if (!VersionStr.IsEmpty() && (CompareVersion(VersionStr, PowerShellCoreVersionStr) > 0))
std::vector<WCHAR> PathBuffer(PathLength);
Res = GetPackagePathByFullName(FullName, &PathLength, PathBuffer.data());
if (Res == ERROR_SUCCESS)
{
PowerShellCoreVersionStr = VersionStr;
UnicodeString PackageName = ExtractFileName(UnicodeString(PathBuffer.data()));
if (StartsStr(Prefix, PackageName) &&
EndsStr(Suffix, PackageName))
{
UnicodeString Release = PackageName.SubString(Prefix.Length() + 1, PackageName.Length() - Prefix.Length() - Suffix.Length());
UnicodeString Version = CutToChar(Release, Sep, false);
if (!Version.IsEmpty())
{
bool IsVersion = true;
for (int Index = 1; Index <= Version.Length(); Index++)
{
wchar_t C = Version[Index];
if (!IsNumber(C) && (C != L'.'))
{
IsVersion = false;
}
}
if (IsVersion)
{
PowerShellCoreVersionStr = TrimVersion(Version);
}
}
}
}
}
}
}
if (PowerShellCoreVersionStr == UnknownVersion)
{
unsigned int Access = KEY_READ | KEY_WOW64_64KEY;
std::unique_ptr<TRegistry> Registry(new TRegistry(Access));
Registry->RootKey = HKEY_LOCAL_MACHINE;
UnicodeString RootKey(L"SOFTWARE\\Microsoft\\PowerShellCore\\InstalledVersions");
if (Registry->OpenKeyReadOnly(RootKey))
{
std::unique_ptr<TStringList> Keys(new TStringList());
Registry->GetKeyNames(Keys.get());
Registry->CloseKey();
for (int Index = 0; Index < Keys->Count; Index++)
{
UnicodeString Key = RootKey + L"\\" + Keys->Strings[Index];
if (Registry->OpenKeyReadOnly(Key))
{
UnicodeString VersionStr = Registry->ReadString(L"SemanticVersion");
if (!VersionStr.IsEmpty() && (CompareVersion(VersionStr, PowerShellCoreVersionStr) > 0))
{
PowerShellCoreVersionStr = VersionStr;
}
Registry->CloseKey();
}
Registry->CloseKey();
}
}
}