I also had some chores pending which were trivial individually, I opted
to incorporate them here as well.
* In JSDocs, use the nullable syntax as it's more concise and familiar
from TypeScript usage.
* discord → Discord (proper nouns should match capitalization)
* Use actions/checkout v4 instead of v2
Visual regressions tests will give us more confidence in SVGO stability.
Test cases are downloaded from w3.org, screenshooted with playwright and
compared with pixelmatch.
Added Typescript support via JSDoc comments for some files.
The code has really outdated type signatures, so in order to fully type the codebase the changes need to be incremental.
To check the types run:
npx tsc
* Path intersection was not checking paths with circles.
As an optimization the path intersection was checking the paths had three or more elements, caliming that otherwise there was nothing to fill. However a semi circle would actually contain 2 points.
Fixes#1048.
This adds a simplified test case for the 2 offending files reported in the issue.
* Add issue templates
We add issue templates for:
- Bug Reports
- Feature Requests
- Plugin Requests
- Pull Requests
- Questions
* Add Github issue templates
Fixes#1364, but is is missing the template for pull requests see
https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository
* fix
* Use "New plugin" label
Co-authored-by: Bogdan Chadkin <trysound@yandex.ru>
