sysutils/svgo
1
0
Fork 0
mirror of https://github.com/svg/svgo.git synced 2025-08-09 02:22:08 +03:00
Code Activity

When minify:false cleanupIds deletes too many ids

Browse Source 
when running cleanupIds with minify:false option it does not save a reference to all ids and removes ids that shouldn't be removed.
This fix adds a var that keeps a ref to the original id even if minify is not defined
This commit is contained in:
Tom Bigelajzen
2016-08-19 18:38:23 +03:00
committed by GitHub
parent 7302d4d8cc
commit 4865892f6e
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/cleanupIDs.js
View File

@@ -121,12 +121,12 @@ exports.fn = function(data, params) {
return data; return data;
} }
var idKey;
for (var k in referencesIDs) { for (var k in referencesIDs) {
if (IDs[k]) { if (IDs[k]) {
idKey = k;
// replace referenced IDs with the minified ones // replace referenced IDs with the minified ones
if (params.minify) { if (params.minify) {
currentIDstring = getIDstring(currentID = generateID(currentID), params); currentIDstring = getIDstring(currentID = generateID(currentID), params);
IDs[k].attr('id').value = currentIDstring; IDs[k].attr('id').value = currentIDstring;
@@ -137,11 +137,11 @@ exports.fn = function(data, params) {
.replace(k + '.', currentIDstring + '.'); .replace(k + '.', currentIDstring + '.');
}); });
idKey = idPrefix + k;
} }
// don't remove referenced IDs // don't remove referenced IDs
delete IDs[idPrefix + k]; delete IDs[idKey];
} }
} }