sysutils/svgo
1
0
Fork 0
mirror of https://github.com/svg/svgo.git synced 2025-07-29 20:21:14 +03:00
Code Activity

Replace removeAttr with delete operator (#1432)

Browse Source 
delete operator is more explicit and not much harder to use.
This commit is contained in:
Bogdan Chadkin
2021-03-17 21:40:06 +03:00
committed by GitHub
parent 8098ab7fb6
commit 07928fc77e
24 changed files with 138 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
plugins/cleanupEnableBackground.js
View File

@ -30,23 +30,23 @@ exports.fn = function (data) {
function checkEnableBackground(item) {
if (
item.isElem(elems) &&
item.hasAttr('enable-background') &&
item.hasAttr('width') &&
item.hasAttr('height')
item.attributes['enable-background'] != null &&
item.attributes.width != null &&
item.attributes.height != null
) {
var match = item
.attr('enable-background')
.value.match(regEnableBackground);
var match = item.attributes['enable-background'].match(
regEnableBackground
);
if (match) {
if (
item.attr('width').value === match[1] &&
item.attr('height').value === match[3]
item.attributes.width === match[1] &&
item.attributes.height === match[3]
) {
if (item.isElem('svg')) {
item.removeAttr('enable-background');
delete item.attributes['enable-background'];
} else {
item.attr('enable-background').value = 'new';
item.attributes['enable-background'] = 'new';
}
}
}
@ -79,8 +79,10 @@ exports.fn = function (data) {
return hasFilter
? firstStep
: monkeys(firstStep, function (item) {
//we don't need 'enable-background' if we have no filters
item.removeAttr('enable-background');
: monkeys(firstStep, (item) => {
if (item.type === 'element') {
//we don't need 'enable-background' if we have no filters
delete item.attributes['enable-background'];
}
});
};