diff --git a/configure.ac b/configure.ac index ffc0d5e..1b121d9 100644 --- a/configure.ac +++ b/configure.ac @@ -244,37 +244,11 @@ if test "$gl_gcc_warnings" = yes; then nw= # This, $nw, is the list of warnings we disable. nw="$nw -Wdeclaration-after-statement" # too useful to forbid - nw="$nw -Waggregate-return" # anachronistic - nw="$nw -Wlong-long" # C90 is anachronistic (lib/gethrxtime.h) - nw="$nw -Wc++-compat" # We don't care about C++ compilers - nw="$nw -Wundef" # Warns on '#if GNULIB_FOO' etc in gnulib - nw="$nw -Wtraditional" # Warns on #elif which we use often - nw="$nw -Wcast-qual" # Too many warnings for now - nw="$nw -Wconversion" # Too many warnings for now nw="$nw -Wsystem-headers" # Don't let system headers trigger warnings nw="$nw -Wsign-conversion" # Too many warnings for now - nw="$nw -Wtraditional-conversion" # Too many warnings for now - nw="$nw -Wunreachable-code" # Too many warnings for now - nw="$nw -Wpadded" # Our structs are not padded - nw="$nw -Wredundant-decls" # openat.h declares e.g., mkdirat - nw="$nw -Wlogical-op" # Too many warnings until GCC 4.8.0 nw="$nw -Wformat-nonliteral" # who.c and pinky.c strftime uses nw="$nw -Wvla" # warnings in gettext.h - nw="$nw -Wnested-externs" # use of XARGMATCH/verify_function__ - nw="$nw -Wswitch-enum" # Too many warnings for now nw="$nw -Wswitch-default" # Too many warnings for now - nw="$nw -Wstack-protector" # not worth working around - # things I might fix soon: - nw="$nw -Wfloat-equal" # sort.c, seq.c - nw="$nw -Wmissing-format-attribute" # copy.c - nw="$nw -Wunsafe-loop-optimizations" # a few src/*.c - nw="$nw -Winline" # system.h's readdir_ignoring_dot_and_dotdot - nw="$nw -Wsuggest-attribute=format" # warns about copy.c and factor.c - - # Using -Wstrict-overflow is a pain, but the alternative is worse. - # For an example, see the code that provoked this report: - # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33498 - # Code like that still infloops with gcc-4.6.0 and -O2. Scary indeed. gl_MANYWARN_ALL_GCC([ws]) gl_MANYWARN_COMPLEMENT([ws], [$ws], [$nw]) @@ -282,13 +256,6 @@ if test "$gl_gcc_warnings" = yes; then gl_WARN_ADD([$w]) done gl_WARN_ADD([-Wno-sign-compare]) # Too many warnings for now - gl_WARN_ADD([-Wno-unused-parameter]) # Too many warnings for now - gl_WARN_ADD([-Wno-format-nonliteral]) - - # Enable this warning only with gcc-4.8 and newer. Before that - # bounds checking as done in truncate.c was incorrectly flagged. - # See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43772 - gl_GCC_VERSION_IFELSE([4], [8], [gl_WARN_ADD([-Wlogical-op])]) # clang is unduly picky about some things. AC_CACHE_CHECK([whether the compiler is clang], [utils_cv_clang], @@ -320,28 +287,10 @@ if test "$gl_gcc_warnings" = yes; then ]) AC_DEFINE([GNULIB_PORTCHECK], [1], [enable some gnulib portability checks]) - # We use a slightly smaller set of warning options for lib/. - # Remove the following and save the result in GNULIB_WARN_CFLAGS. - nw= - nw="$nw -Wstrict-overflow" - nw="$nw -Wuninitialized" - nw="$nw -Wunused-macros" - nw="$nw -Wmissing-prototypes" - nw="$nw -Wold-style-definition" - # FIXME: it may be easy to remove this, since it affects only one file: - # the snprintf call at ftoastr.c:132. - nw="$nw -Wdouble-promotion" - gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) - AC_SUBST([GNULIB_WARN_CFLAGS]) - # For gnulib-tests, the set is slightly smaller still. nw= - nw="$nw -Wstrict-prototypes" - # It's not worth being this picky about test programs. - nw="$nw -Wsuggest-attribute=const" - nw="$nw -Wsuggest-attribute=pure" gl_MANYWARN_COMPLEMENT([GNULIB_TEST_WARN_CFLAGS], - [$GNULIB_WARN_CFLAGS], [$nw]) + [$WARN_CFLAGS], [$nw]) AC_SUBST([GNULIB_TEST_WARN_CFLAGS]) fi