From ab0cfea35c07faa80740e8ca9369ac76855833ac Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Sun, 31 Jul 2016 02:23:37 -0400 Subject: [PATCH] sed: reject 's///e' in --posix mode 's///e' modifier is a gnu extension - reject it in --posix mode. * sed/compile.c: (mark_subst_opt): Exit upon 's///e' in posix mode. * testsuite/posix-mode-s.sh: Adjust tests accordingly. --- sed/compile.c | 2 ++ testsuite/posix-mode-s.sh | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sed/compile.c b/sed/compile.c index ca09e78..36bdec6 100644 --- a/sed/compile.c +++ b/sed/compile.c @@ -603,6 +603,8 @@ mark_subst_opts (struct subst *cmd) break; case 'e': + if (posixicity == POSIXLY_BASIC) + bad_prog(_(UNKNOWN_S_OPT)); cmd->eval = true; break; diff --git a/testsuite/posix-mode-s.sh b/testsuite/posix-mode-s.sh index 243dde4..d284a4d 100644 --- a/testsuite/posix-mode-s.sh +++ b/testsuite/posix-mode-s.sh @@ -19,7 +19,6 @@ print_ver_ sed fail=0 -unset POSIXLY_CORRECT cat <<\EOF >exp-err || framework_failure_ sed: -e expression #1, char 7: unknown option to `s' @@ -48,9 +47,13 @@ printf "hello\n" >exp-gnu-e || framework_failure_ sed 's/./printf hello/e' in1 > out-gnu-e || fail=1 compare exp-gnu-e out-gnu-e || fail=1 -#TODO: this is not supposed to work in posix mode -#returns_ 1 sed --posix 's/./printf hello/e' in1 2>err-posix-e || fail=1 +# s///e rejected in POSIX mode +cat <<\EOF >exp-err-psx-e || framework_failure_ +sed: -e expression #1, char 10: unknown option to `s' +EOF +returns_ 1 sed --posix 's/./echo/e' in1 2>err-posix-e || fail=1 +compare_ exp-err-psx-e err-posix-e || fail=1 # substitution special commands (e.g \l \L \U \u \E).