From 6187fc0e3a1904eb22aeadef1b805bc85f063dbc Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 5 Dec 2018 19:24:30 -0700 Subject: [PATCH] tests: add text/binary mode tests This test is skipped on most platforms (which do not support O_BINARY and do not differentiate between TEXT and BINARY files). On cygwin, the test is skipped because default cygwin installations do not use O_TEXT/O_BINARY modes (unless file systems are mounted with special options). In practice this test will only run on native Windows (e.g. when compiled with mingw or msvc). Note that almost every other test will fail with such a binary (due to excesssive "\r" in the output). Thus it is recommended to explictly run just this test alone: make check SUBDIRS=. TESTS=testsuite/obinary.sh The script tries to cover all cases mentioned in https://bugs.gnu.org/25459 . See also https://lists.gnu.org/r/sed-devel/2018-10/msg00001.html . * testsuite/obinary.sh: New test. * testsuite/local.mk (TESTS): Add new test. --- testsuite/local.mk | 1 + testsuite/obinary.sh | 111 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 112 insertions(+) create mode 100755 testsuite/obinary.sh diff --git a/testsuite/local.mk b/testsuite/local.mk index b59f028..8213b06 100644 --- a/testsuite/local.mk +++ b/testsuite/local.mk @@ -69,6 +69,7 @@ T = \ testsuite/newline-dfa-bug.sh \ testsuite/normalize-text.sh \ testsuite/nulldata.sh \ + testsuite/obinary.sh \ testsuite/panic-tests.sh \ testsuite/posix-char-class.sh \ testsuite/posix-mode-addr.sh \ diff --git a/testsuite/obinary.sh b/testsuite/obinary.sh new file mode 100755 index 0000000..abf6cd1 --- /dev/null +++ b/testsuite/obinary.sh @@ -0,0 +1,111 @@ +#!/bin/sh +# Test CR/LF behaviour on platforms which support O_BINARY file mode +# (i.e. differentiates between text and binary files). + +# Copyright (C) 2018 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +. "${srcdir=.}/testsuite/init.sh"; path_prepend_ ./sed +print_ver_ sed + +# Test if O_TEXT is enabled by default (i.e. lines terminated with "\r\n"). +# If not, skip the test. +printf a | sed cb > out1 \ + || framework_failure_ "failed to run sed 'cb'" +size=$(wc -c < out1) \ + || framework_failure_ "failed to check size of 'out1'" +case $size in + 2) skip_ "platform does not enable O_TEXT by default" ;; + 3) ;; + *) framework_failure_ "unexpected size '$size'" ;; +esac + + +# files with "\r\n" and with just "\n" +printf 'a\015\12' > inT || framework_failure_ +printf 'a\12' > inB || framework_failure_ +cp inT inplaceT1 || framework_failure_ +cp inT inplaceT2 || framework_failure_ +cp inT inplaceT3 || framework_failure_ +cp inB inplaceB1 || framework_failure_ +cp inB inplaceB2 || framework_failure_ + +printf 'z\015\12' > expT || framework_failure_ +printf 'z\12' > expB || framework_failure_ + + +# First round of tests. These all seem equivalent, +# but older seds had sublte implementation differences +# between STDIN and explicit input files (bug#25459). +# Similarly, also test --inplace type output. +sed 's/a/z/' inT > out1 || fail=1 +sed 's/a/z/' < inT > out2 || fail=1 +cat inT | sed 's/a/z/' > out3 || fail=1 +sed -i 's/a/z/' inplaceT1 || fail=1 + +compare_ expT out1 || fail=1 +compare_ expT out2 || fail=1 +compare_ expT out3 || fail=1 +compare_ expT inplaceT1 || fail=1 + +# Input file with only "\n". Output should contain "\r\n". +sed 's/a/z/' inB > out4 || fail=1 +sed 's/a/z/' < inB > out5 || fail=1 +cat inB | sed 's/a/z/' > out6 || fail=1 +sed -i 's/a/z/' inplaceB1 || fail=1 + +compare_ expT out4 || fail=1 +compare_ expT out5 || fail=1 +compare_ expT out6 || fail=1 +compare_ expT inplaceB1 || fail=1 + +# Input file with only "\n", with "sed -b" should output only "\n". +sed -b 's/a/z/' inB > out7 || fail=1 +sed -b 's/a/z/' < inB > out8 || fail=1 +cat inB | sed -b 's/a/z/' > out9 || fail=1 +sed -b -i 's/a/z/' inplaceB2 || fail=1 + +compare_ expB out7 || fail=1 +compare_ expB out8 || fail=1 +compare_ expB out9 || fail=1 +compare_ expB inplaceB2 || fail=1 + +# End-of-line tests on input file with "\r\n". +# In TEXT mode, "\r\n" is end-of-line, the "y" character will be added prior to +# it. In BINARY mode, "\r" is just another character - the "y" character will +# be added after the "\r". +printf 'ay\015\012' > expTeol || framework_failure_ +printf 'a\015y\012' > expBeol || framework_failure_ + +sed 's/$/y/' inT > out10 || fail=1 +sed 's/$/y/' < inT > out11 || fail=1 +cat inT | sed 's/$/y/' > out12 || fail=1 +sed -i 's/$/y/' inplaceT2 || fail=1 + +sed -b 's/$/y/' inT > out13 || fail=1 +sed -b 's/$/y/' < inT > out14 || fail=1 +cat inT | sed -b 's/$/y/' > out15 || fail=1 +sed -i -b 's/$/y/' inplaceT3 || fail=1 + +compare_ expTeol out10 || fail=1 +compare_ expTeol out11 || fail=1 +compare_ expTeol out12 || fail=1 +compare_ expTeol inplaceT2 || fail=1 + +compare_ expBeol out13 || fail=1 +compare_ expBeol out14 || fail=1 +compare_ expBeol out15 || fail=1 +compare_ expBeol inplaceT3 || fail=1 + +Exit $fail