From 47838d29e1c1b1e5e6f803a297ee8100b78fd577 Mon Sep 17 00:00:00 2001 From: Ash Roberts Date: Tue, 31 Mar 2026 02:34:44 +0100 Subject: [PATCH] sed: do not allow removed 'L' command in compiler * sed/compile.c: Remove cases for 'L' command. * testsuite/compile-errors.sh: remove test for 'L' command in posix mode. The 'L' command was removed in version 4.3, but was still allowed by the compiler (resulting in an internal error when running a script that uses it). Reported in https://bugs.gnu.org/80704 Before, it would print this: $ echo | sed L1 sed: INTERNAL ERROR: Bad cmd L Now, it prints this: sed: -e expression #1, char 1: unknown command: 'L' --- sed/compile.c | 3 +-- testsuite/compile-errors.sh | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/sed/compile.c b/sed/compile.c index 234845a..cf64679 100644 --- a/sed/compile.c +++ b/sed/compile.c @@ -972,7 +972,7 @@ compile_program (struct vector *vector) if (posixicity == POSIXLY_BASIC) switch (ch) { - case 'e': case 'F': case 'v': case 'z': case 'L': + case 'e': case 'F': case 'v': case 'z': case 'Q': case 'T': case 'R': case 'W': bad_prog ("unknown command: '%c'", ch); FALLTHROUGH; @@ -1093,7 +1093,6 @@ compile_program (struct vector *vector) bad_prog ("command only uses one address"); FALLTHROUGH; - case 'L': case 'l': ch = in_nonblank (); if (ISDIGIT (ch) && posixicity != POSIXLY_BASIC) diff --git a/testsuite/compile-errors.sh b/testsuite/compile-errors.sh index c4b81a8..3b942c8 100644 --- a/testsuite/compile-errors.sh +++ b/testsuite/compile-errors.sh @@ -101,7 +101,7 @@ compare_ exp-bad-bang err-bad-bang || fail=1 # # GNU extension commands, not accepted in --posix mode # (bad_command(OPT)) -for opt in e F v z L Q T R W ; +for opt in e F v z Q T R W ; do cat <exp-posix-cmd-$opt || framework_failure_ sed: -e expression #1, char 2: unknown command: '$opt'