Stefan Haller c3a051dcca Use Sprint for text that isn't a format string ...

Two places pass plain text as the format string of TextStyle.Sprintf
without further arguments: the prefix of a disabled menu item's
tooltip, and the key binding entries of the options bar. If the text
contains a "%", for example in a translation or in a key label, it is
mangled into something like "%!(NOVERB)".

go vet doesn't report these calls yet. It will once go.mod says go
1.26, because vet then also finds printf wrappers through interface
methods. TextStyle.Sprintf forwards to the Sprintf method of the
Sprinter interface.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

2026-10-16 07:53:03 +02:00

..

helpers

Use Sprint for text that isn't a format string

2026-10-16 07:53:03 +02:00

attach.go

Copy the selected diff lines from the focused main view

2026-10-05 11:01:24 +02:00

base_controller.go

Copy the selected diff lines from the focused main view

2026-10-05 11:01:24 +02:00

basic_commits_controller.go

Avoid appending to an array literal

2026-08-16 16:35:11 +02:00

bisect_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

branches_controller.go

Lay out the rule below a pull request's header to the main view's width

2026-10-05 16:38:13 +02:00

command_log_controller.go

Remove return value of Focus-related functions

2024-09-06 08:45:48 +02:00

commit_description_controller.go

Fold remaining alt bindings into their main fields

2026-05-25 15:32:47 +02:00

commit_diff_actions.go

Show an error if the commit to discard lines from can't be found

2026-10-10 13:04:41 +02:00

commit_message_controller.go

Convert keybinding fields to Keybinding

2026-05-25 15:32:47 +02:00

commits_files_controller.go

Copy the absolute path of a branch's file from the worktree that has it

2026-10-10 13:58:05 +02:00

common.go

lots of changes

2023-04-30 13:19:53 +10:00

confirmation_controller.go

Rename Key to Keys in Binding, KeybindingsOpts, and MenuItem

2026-05-25 15:18:18 +02:00

context_lines_controller.go

Allow context changes while building a custom patch

2026-10-05 11:44:42 +02:00

custom_patch_options_menu_action.go

Remove the explorer behavior behind the retired panels

2026-10-05 11:44:42 +02:00

diff_copy.go

Move the diff-copy helper out of the explorer controller

2026-10-05 11:44:42 +02:00

diff_paths_test.go

Collapse the paths of a moved directory into the directory itself

2026-08-17 09:32:30 +02:00

diff_paths.go

Show an error if the selected diff lines can't be found in the diff

2026-10-10 13:04:41 +02:00

diffing_menu_action.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

edit_config_action.go

Extract editConfig into a shared EditConfigAction

2026-06-24 22:03:57 +02:00

files_controller.go

Ask before discarding a nested repository if that loses anything

2026-10-15 20:51:34 +02:00

filter_controller.go

Filter a menu by typing into it

2026-08-31 20:41:22 +02:00

filtering_menu_action.go

Handle entering and leaving filtering mode in one place

2026-08-05 17:29:20 +02:00

git_flow_controller.go

Rename Key to Keys in Binding, KeybindingsOpts, and MenuItem

2026-05-25 15:18:18 +02:00

global_controller.go

Add a menu of the diff's files to jump to one directly

2026-10-05 12:14:02 +02:00

jump_to_side_window_controller.go

Stop requiring jumpToBlock to have exactly five entries

2026-06-23 14:15:18 +02:00

list_controller_trait.go

Enable nolintlint linter, and fix warnings

2025-06-30 18:30:11 +02:00

list_controller.go

Scroll the selection into view by default

2026-08-14 08:04:13 +02:00

local_commits_controller_test.go

Drag selected commits to a new position

2026-07-31 08:37:28 +02:00

local_commits_controller.go

Ask one place whether a branch has a pull request

2026-10-05 12:05:39 +02:00

main_view_controller_test.go

Open the selected diff line in the branch's pull request

2026-10-05 12:05:39 +02:00

main_view_controller.go

Restore the terminal if a timer or errgroup function panics

2026-10-14 20:28:53 +02:00

menu_controller.go

Point the note about the menu's essential keys at what it means

2026-08-31 20:41:22 +02:00

menu_key.go

Use a slice of keys for each binding

2026-05-25 15:18:18 +02:00

merge_conflicts_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

options_menu_action.go

Build a custom patch from a commit's diff, and discard lines from it

2026-10-05 11:33:11 +02:00

patch_explorer_controller_test.go

Strip the '+' and '-' characters when copying parts of a diff to the clipboard

2025-04-29 11:33:47 +02:00

prompt_controller.go

Rename Key to Keys in Binding, KeybindingsOpts, and MenuItem

2026-05-25 15:18:18 +02:00

quit_actions.go

Refuse a repo switch while a foreground operation is in flight

2026-07-07 18:09:33 +02:00

reflog_commits_controller.go

Build a custom patch from a commit's diff, and discard lines from it

2026-10-05 11:33:11 +02:00

remote_branches_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

remotes_controller_test.go

feat: add fork remote command

2025-11-16 17:26:00 +01:00

remotes_controller.go

Update comments that still describe the removed blocking refresh mode

2026-07-21 22:23:58 +02:00

rename_similarity_threshold_controller.go

Show renamed files in the custom patch builder

2026-07-04 13:05:09 +02:00

screen_mode_actions.go

Rework the custom pager config (rename to diff renderer)

2026-07-31 08:42:51 +02:00

scroll_off_margin_test.go

Add tests for scroll-off margin of zero

2023-08-21 08:10:28 +02:00

scroll_off_margin.go

Replace min/max helpers with built-in min/max

2024-04-07 23:24:10 +08:00

search_controller.go

Remove error return value from functions that always return nil

2026-08-31 20:41:22 +02:00

search_prompt_controller.go

Remove error return value from functions that always return nil

2026-08-31 20:41:22 +02:00

shell_command_action.go

Strip leading/trailing whitespace from prompt input

2025-11-15 15:38:24 +01:00

side_window_controller.go

Fold remaining alt bindings into their main fields

2026-05-25 15:32:47 +02:00

snake_controller.go

Rename Key to Keys in Binding, KeybindingsOpts, and MenuItem

2026-05-25 15:18:18 +02:00

stash_controller.go

Let the prefix of a render be laid out to the width it renders at

2026-10-05 16:38:13 +02:00

status_controller.go

Rename RunPtyTask to RunDiffRendererTask

2026-09-25 11:31:59 +02:00

sub_commits_controller.go

Build a custom patch from a commit's diff, and discard lines from it

2026-10-05 11:33:11 +02:00

submodules_controller.go

Let the prefix of a render be laid out to the width it renders at

2026-10-05 16:38:13 +02:00

suggestions_controller.go

Drop the highlight fixups the context stack now makes unnecessary

2026-09-03 21:19:04 +02:00

switch_to_diff_files_controller.go

Give the panels showing a commit's diff one voice about it

2026-10-05 11:33:11 +02:00

switch_to_focused_main_view_controller.go

Open file diffs in the focused main view

2026-10-05 11:44:42 +02:00

switch_to_sub_commits_controller.go

Rename Key to Keys in Binding, KeybindingsOpts, and MenuItem

2026-05-25 15:18:18 +02:00

sync_controller.go

Offer to update the branches stacked below the current one when pulling

2026-09-27 11:13:15 +02:00

tags_controller.go

Let the prefix of a render be laid out to the width it renders at

2026-10-05 16:38:13 +02:00

toggle_whitespace_action.go

Remove the staging and patch-building panel shells

2026-10-05 11:44:42 +02:00

undo_controller.go

Capture the commits refresh's inputs on the UI thread

2026-07-07 18:10:45 +02:00

vertical_scroll_controller.go

Read lines based on scroll position instead of a fixed per-notch delta

2026-07-09 09:32:35 +02:00

working_tree_diff_actions.go

Show an error if the selected diff lines can't be found in the diff

2026-10-10 13:04:41 +02:00

workspace_reset_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

worktrees_controller.go

Move the menu for removing a worktree to BranchesHelper

2026-10-15 20:51:34 +02:00