From e3ed899b20c1e1cec25245bcb32c272ad02580fd Mon Sep 17 00:00:00 2001
From: Anthony HAMON <anthony.hamon@iadvize.com>
Date: Tue, 28 Aug 2018 21:09:56 +0200
Subject: [PATCH] refactor MergeStatusFiles

---
 pkg/commands/git.go | 37 +++++++++++++------------------------
 1 file changed, 13 insertions(+), 24 deletions(-)

diff --git a/pkg/commands/git.go b/pkg/commands/git.go
index 0cedb2150..619db05e7 100644
--- a/pkg/commands/git.go
+++ b/pkg/commands/git.go
@@ -121,28 +121,28 @@ func (c *GitCommand) MergeStatusFiles(oldFiles, newFiles []File) []File {
 		return newFiles
 	}
 
-	appendedIndexes := []int{}
+	headResults := []File{}
+	tailResults := []File{}
 
-	// retain position of files we already could see
-	result := []File{}
-	for _, oldFile := range oldFiles {
-		for newIndex, newFile := range newFiles {
+	for _, newFile := range newFiles {
+		var isHeadResult bool
+
+		for _, oldFile := range oldFiles {
 			if oldFile.Name == newFile.Name {
-				result = append(result, newFile)
-				appendedIndexes = append(appendedIndexes, newIndex)
+				isHeadResult = true
 				break
 			}
 		}
-	}
 
-	// append any new files to the end
-	for index, newFile := range newFiles {
-		if !includesInt(appendedIndexes, index) {
-			result = append(result, newFile)
+		if isHeadResult {
+			headResults = append(headResults, newFile)
+			continue
 		}
+
+		tailResults = append(tailResults, newFile)
 	}
 
-	return result
+	return append(headResults, tailResults...)
 }
 
 func (c *GitCommand) verifyInGitRepo() {
@@ -447,17 +447,6 @@ func includesString(list []string, a string) bool {
 	return false
 }
 
-// not sure how to genericise this because []interface{} doesn't accept e.g.
-// []int arguments
-func includesInt(list []int, a int) bool {
-	for _, b := range list {
-		if b == a {
-			return true
-		}
-	}
-	return false
-}
-
 // GetCommits obtains the commits of the current branch
 func (c *GitCommand) GetCommits() []Commit {
 	pushables := c.GetCommitsToPush()