From d74c817fd88144278118cf86465b1e58ad06633a Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Tue, 22 Aug 2023 13:55:05 +0200 Subject: [PATCH] Panic when trying to use RefreshOptions.Then with mode ASYNC This doesn't work, and since it took me a while of debugging to figure this out, alert other developers earlier when they try to do it. --- pkg/gui/controllers/helpers/refresh_helper.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/gui/controllers/helpers/refresh_helper.go b/pkg/gui/controllers/helpers/refresh_helper.go index 377319250..9e1489da4 100644 --- a/pkg/gui/controllers/helpers/refresh_helper.go +++ b/pkg/gui/controllers/helpers/refresh_helper.go @@ -51,6 +51,10 @@ func NewRefreshHelper( } func (self *RefreshHelper) Refresh(options types.RefreshOptions) error { + if options.Mode == types.ASYNC && options.Then != nil { + panic("RefreshOptions.Then doesn't work with mode ASYNC") + } + t := time.Now() defer func() { self.c.Log.Infof(fmt.Sprintf("Refresh took %s", time.Since(t)))