From c6db95c68d373f9dc9ed0d495158dfa40badf233 Mon Sep 17 00:00:00 2001 From: Stefan Haller Date: Mon, 2 Nov 2026 20:01:50 +0100 Subject: [PATCH] Add tests showing that lazygit instances lose each other's state changes Co-Authored-By: Claude Opus 5.5 --- pkg/config/app_state_test.go | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/pkg/config/app_state_test.go b/pkg/config/app_state_test.go index 6236d08cc..9d7a2d555 100644 --- a/pkg/config/app_state_test.go +++ b/pkg/config/app_state_test.go @@ -33,3 +33,46 @@ func TestStartupWithBrokenAppStateFile(t *testing.T) { _, err = newAppConfig(t) assert.NoError(t, err) } + +func addToHistory(command string) func(state *AppState) { + return func(state *AppState) { + state.ShellCommandsHistory = append([]string{command}, state.ShellCommandsHistory...) + } +} + +func TestAppStateReadSeesUpdatesOfOtherInstances(t *testing.T) { + useTempConfigDir(t) + instanceA, err := newAppConfig(t) + assert.NoError(t, err) + instanceB, err := newAppConfig(t) + assert.NoError(t, err) + + assert.NoError(t, instanceB.UpdateAppState(addToHistory("from B"))) + + appState, err := instanceA.ReadAppState() + assert.NoError(t, err) + /* EXPECTED: + assert.Equal(t, []string{"from B"}, appState.ShellCommandsHistory) + ACTUAL: */ + assert.Empty(t, appState.ShellCommandsHistory) +} + +func TestAppStateUpdateKeepsUpdatesOfOtherInstances(t *testing.T) { + useTempConfigDir(t) + instanceA, err := newAppConfig(t) + assert.NoError(t, err) + instanceB, err := newAppConfig(t) + assert.NoError(t, err) + + assert.NoError(t, instanceA.UpdateAppState(addToHistory("from A"))) + assert.NoError(t, instanceB.UpdateAppState(addToHistory("from B"))) + + instanceC, err := newAppConfig(t) + assert.NoError(t, err) + appState, err := instanceC.ReadAppState() + assert.NoError(t, err) + /* EXPECTED: + assert.Equal(t, []string{"from B", "from A"}, appState.ShellCommandsHistory) + ACTUAL: */ + assert.Equal(t, []string{"from B"}, appState.ShellCommandsHistory) +}