Provide two config keys for configuring the author length in commits view

One is for the normal view, the other for the expanded view.

pkg/gui/presentation/authors/authors.go

@@ -11,11 +11,16 @@ import (
 	"github.com/mattn/go-runewidth"
 )
 
+type authorNameCacheKey struct {
+	authorName string
+	truncateTo int
+}
+
 // if these being global variables causes trouble we can wrap them in a struct
 // attached to the gui state.
 var (
 	authorInitialCache = make(map[string]string)
-	authorNameCache    = make(map[string]string)
+	authorNameCache    = make(map[authorNameCacheKey]string)
 	authorStyleCache   = make(map[string]style.TextStyle)
 )
 
@@ -37,19 +42,37 @@ func ShortAuthor(authorName string) string {
 	return value
 }
 
-func LongAuthor(authorName string) string {
-	if value, ok := authorNameCache[authorName]; ok {
+func LongAuthor(authorName string, length int) string {
+	cacheKey := authorNameCacheKey{authorName: authorName, truncateTo: length}
+	if value, ok := authorNameCache[cacheKey]; ok {
 		return value
 	}
 
-	paddedAuthorName := utils.WithPadding(authorName, 17, utils.AlignLeft)
-	truncatedName := utils.TruncateWithEllipsis(paddedAuthorName, 17)
+	paddedAuthorName := utils.WithPadding(authorName, length, utils.AlignLeft)
+	truncatedName := utils.TruncateWithEllipsis(paddedAuthorName, length)
 	value := AuthorStyle(authorName).Sprint(truncatedName)
-	authorNameCache[authorName] = value
+	authorNameCache[cacheKey] = value
 
 	return value
 }
 
+// AuthorWithLength returns a representation of the author that fits into a
+// given maximum length:
+// - if the length is less than 2, it returns an empty string
+// - if the length is 2, it returns the initials
+// - otherwise, it returns the author name truncated to the maximum length
+func AuthorWithLength(authorName string, length int) string {
+	if length < 2 {
+		return ""
+	}
+
+	if length == 2 {
+		return ShortAuthor(authorName)
+	}
+
+	return LongAuthor(authorName, length)
+}
+
 func AuthorStyle(authorName string) style.TextStyle {
 	if value, ok := authorStyleCache[authorName]; ok {
 		return value

pkg/gui/presentation/authors/authors_test.go

@@ -1,6 +1,11 @@
 package authors
 
-import "testing"
+import (
+	"testing"
+
+	"github.com/jesseduffield/lazygit/pkg/utils"
+	"github.com/stretchr/testify/assert"
+)
 
 func TestGetInitials(t *testing.T) {
 	for input, expectedOutput := range map[string]string{
@@ -18,3 +23,21 @@ func TestGetInitials(t *testing.T) {
 		}
 	}
 }
+
+func TestAuthorWithLength(t *testing.T) {
+	scenarios := []struct {
+		authorName     string
+		length         int
+		expectedOutput string
+	}{
+		{"Jesse Duffield", 0, ""},
+		{"Jesse Duffield", 1, ""},
+		{"Jesse Duffield", 2, "JD"},
+		{"Jesse Duffield", 3, "Je…"},
+		{"Jesse Duffield", 10, "Jesse Duf…"},
+		{"Jesse Duffield", 14, "Jesse Duffield"},
+	}
+	for _, s := range scenarios {
+		assert.Equal(t, s.expectedOutput, utils.Decolorise(AuthorWithLength(s.authorName, s.length)))
+	}
+}

pkg/gui/presentation/commits.go

@@ -440,10 +440,11 @@ func displayCommit(
 		mark = fmt.Sprintf("%s ", willBeRebased)
 	}
 
-	authorFunc := authors.ShortAuthor
+	authorLength := common.UserConfig.Gui.CommitAuthorShortLength
 	if fullDescription {
-		authorFunc = authors.LongAuthor
+		authorLength = common.UserConfig.Gui.CommitAuthorLongLength
 	}
+	author := authors.AuthorWithLength(commit.AuthorName, authorLength)
 
 	cols := make([]string, 0, 7)
 	cols = append(
@@ -453,7 +454,7 @@ func displayCommit(
 		bisectString,
 		descriptionString,
 		actionString,
-		authorFunc(commit.AuthorName),
+		author,
 		graphLine+mark+tagString+theme.DefaultTextColor.Sprint(name),
 	)