sysutils/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-07-30 03:23:08 +03:00
Code Activity

Use searching, not filtering, in file tree views

Browse Source 
There's more work to be done to support filtering for these views so we're sticking with searching for now
This commit is contained in:
Jesse Duffield
2023-06-26 11:15:47 +10:00
parent cd989d8ebe
commit 8e46b8a275
7 changed files with 33 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
pkg/gui/context/commit_files_context.go
View File

@ -10,10 +10,10 @@ import (
)
type CommitFilesContext struct {
*FilteredList[*models.CommitFile]
*filetree.CommitFileTreeViewModel
*ListContextTrait
*DynamicTitleBuilder
*SearchTrait
}
var (
@ -22,13 +22,8 @@ var (
)
func NewCommitFilesContext(c *ContextCommon) *CommitFilesContext {
filteredList := NewFilteredList(
func() []*models.CommitFile { return c.Model().CommitFiles },
func(file *models.CommitFile) []string { return []string{file.GetPath()} },
)
viewModel := filetree.NewCommitFileTreeViewModel(
func() []*models.CommitFile { return filteredList.GetFilteredList() },
func() []*models.CommitFile { return c.Model().CommitFiles },
c.Log,
c.UserConfig.Gui.ShowFileTree,
)
@ -44,10 +39,10 @@ func NewCommitFilesContext(c *ContextCommon) *CommitFilesContext {
})
}
return &CommitFilesContext{
FilteredList: filteredList,
ctx := &CommitFilesContext{
CommitFileTreeViewModel: viewModel,
DynamicTitleBuilder: NewDynamicTitleBuilder(c.Tr.CommitFilesDynamicTitle),
SearchTrait: NewSearchTrait(c),
ListContextTrait: &ListContextTrait{
Context: NewSimpleContext(
NewBaseContext(NewBaseContextOpts{
@ -64,6 +59,13 @@ func NewCommitFilesContext(c *ContextCommon) *CommitFilesContext {
c: c,
},
}
ctx.GetView().SetOnSelectItem(ctx.SearchTrait.onSelectItemWrapper(func(selectedLineIdx int) error {
ctx.GetList().SetSelectedLineIdx(selectedLineIdx)
return ctx.HandleFocus(types.OnFocusOpts{})
}))
return ctx
}
func (self *CommitFilesContext) GetSelectedItemId() string {
@ -78,17 +80,3 @@ func (self *CommitFilesContext) GetSelectedItemId() string {
func (self *CommitFilesContext) GetDiffTerminals() []string {
return []string{self.GetRef().RefName()}
}
// used for type switch
func (self *CommitFilesContext) IsFilterableContext() {}
// TODO: see if we can just call SetTree() within HandleRender(). It doesn't seem
// right that we need to imperatively refresh the view model like this
func (self *CommitFilesContext) SetFilter(filter string) {
self.FilteredList.SetFilter(filter)
self.SetTree()
}
func (self *CommitFilesContext) ClearFilter() {
self.SetFilter("")
}