1
0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-07-30 03:23:08 +03:00

remove useless returned variable

This commit is contained in:
Anthony HAMON
2018-08-21 22:17:34 +02:00
parent a891bc90b7
commit 883fcf1083
3 changed files with 7 additions and 6 deletions

View File

@ -108,13 +108,13 @@ func (c *OSCommand) SublimeOpenFile(filename string) (*exec.Cmd, error) {
}
// OpenFile opens a file with the given
func (c *OSCommand) OpenFile(filename string) (*exec.Cmd, error) {
func (c *OSCommand) OpenFile(filename string) error {
cmdName, cmdTrail, err := c.GetOpenCommand()
if err != nil {
return nil, err
return err
}
err = c.RunCommand(cmdName + " " + c.Quote(filename) + cmdTrail) // TODO: test on linux
return nil, err
return c.RunCommand(cmdName + " " + c.Quote(filename) + cmdTrail) // TODO: test on linux
}
// EditFile opens a file in a subprocess using whatever editor is available,

View File

@ -256,7 +256,7 @@ func (gui *Gui) handleFileOpen(g *gocui.Gui, v *gocui.View) error {
if err != nil {
return err
}
return gui.genericFileOpen(g, v, file.Name, gui.OSCommand.OpenFile)
return gui.genericFileOpen(g, v, file.Name, func(filename string) (*exec.Cmd, error) { return nil, gui.OSCommand.OpenFile(filename) })
}
func (gui *Gui) handleSublimeFileOpen(g *gocui.Gui, v *gocui.View) error {

View File

@ -2,6 +2,7 @@ package gui
import (
"fmt"
"os/exec"
"github.com/fatih/color"
"github.com/jesseduffield/gocui"
@ -66,7 +67,7 @@ func (gui *Gui) handleStatusSelect(g *gocui.Gui, v *gocui.View) error {
func (gui *Gui) handleOpenConfig(g *gocui.Gui, v *gocui.View) error {
filename := gui.Config.GetUserConfig().ConfigFileUsed()
return gui.genericFileOpen(g, v, filename, gui.OSCommand.OpenFile)
return gui.genericFileOpen(g, v, filename, func(filename string) (*exec.Cmd, error) { return nil, gui.OSCommand.OpenFile(filename) })
}
func (gui *Gui) handleEditConfig(g *gocui.Gui, v *gocui.View) error {