From 6fb3b7430c1f1906e031264d66ff12cca069008f Mon Sep 17 00:00:00 2001 From: Chris McDonnell Date: Fri, 14 Mar 2025 00:08:52 -0400 Subject: [PATCH] refactor: Make commit.gpgSign match official capitalization The actual usage is case insensitive, so this doesn't actually matter. But if fills my heart with joy. The test is case sensitive, but the actual response to `git config commit.gpgSign` is equivalent to `git config commit.gppsign` --- pkg/commands/git_commands/config.go | 2 +- pkg/commands/git_commands/rebase_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/commands/git_commands/config.go b/pkg/commands/git_commands/config.go index 865315f11..b93cbf91a 100644 --- a/pkg/commands/git_commands/config.go +++ b/pkg/commands/git_commands/config.go @@ -66,7 +66,7 @@ func (self *ConfigCommands) NeedsGpgSubprocessForCommit() bool { return false } - return self.gitConfig.GetBool("commit.gpgsign") + return self.gitConfig.GetBool("commit.gpgSign") } func (self *ConfigCommands) GetCoreEditor() string { diff --git a/pkg/commands/git_commands/rebase_test.go b/pkg/commands/git_commands/rebase_test.go index 21ebdf365..d79bc0b6a 100644 --- a/pkg/commands/git_commands/rebase_test.go +++ b/pkg/commands/git_commands/rebase_test.go @@ -128,7 +128,7 @@ func TestRebaseDiscardOldFileChanges(t *testing.T) { }, { testName: "returns error when using gpg", - gitConfigMockResponses: map[string]string{"commit.gpgsign": "true"}, + gitConfigMockResponses: map[string]string{"commit.gpgSign": "true"}, commits: []*models.Commit{{Name: "commit", Hash: "123456"}}, commitIndex: 0, fileName: []string{"test999.txt"},