1
0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2026-10-24 02:09:03 +03:00
Files
ffmpeg/libavcodec/ac3dec_fixed.c
Ayoub Nabil 5ba2a2c841 avcodec/ac3dec_fixed: fix dither at exponent 24
the fixed decoder discarded fractional coefficient data before the imdct, causing low-level coefficients to be truncated at large exponents. dithered bap 0 coefficients at exponent 24 were consequently quantized with a negative bias.

keep ac-3 coefficients in q2, compensate during windowing, and round the affected dither symmetrically. keep the forced e-ac-3 path in q0.

add a synthetic fate test covering the corrected output.
2026-08-10 22:01:35 +00:00

246 lines
8.4 KiB
C

/*
* Copyright (c) 2012
* MIPS Technologies, Inc., California.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. Neither the name of the MIPS Technologies, Inc., nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE MIPS TECHNOLOGIES, INC. ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE MIPS TECHNOLOGIES, INC. BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* Author: Stanislav Ocovaj (socovaj@mips.com)
*
* AC3 fixed-point decoder for MIPS platforms
*
* This file is part of FFmpeg.
*
* FFmpeg is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* FFmpeg is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with FFmpeg; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include "config_components.h"
#define USE_FIXED 1
#include "ac3dec.h"
#include "codec_internal.h"
#define IMDCT_TYPE AV_TX_INT32_MDCT
#include "ac3dec.h"
/* Keep two fractional bits in fixed-point transform coefficients. */
#define AC3_FIXED_COEFF_BITS 2
#define AC3_FIXED_EXPONENT_MAX 24
static av_always_inline int fixed_coeff_bits(const AC3DecodeContext *s)
{
/* ac3_fixed normally decodes AC-3. Keep Q0 when it is explicitly forced
* to decode E-AC-3, whose AHT coefficient bounds are different. */
return s->eac3 ? 0 : AC3_FIXED_COEFF_BITS;
}
static const int end_freq_inv_tab[8] =
{
50529027, 44278013, 39403370, 32292987, 27356480, 23729101, 20951060, 18755316
};
static void scale_coefs (
int32_t *dst,
const int32_t *src,
int dynrng,
int len)
{
int i, shift;
unsigned mul, round;
int temp, temp1, temp2, temp3, temp4, temp5, temp6, temp7;
mul = (dynrng & 0x1f) + 0x20;
shift = 4 - (sign_extend(dynrng, 9) >> 5);
if (shift > 0 ) {
round = 1 << (shift-1);
for (i=0; i<len; i+=8) {
temp = src[i] * mul;
temp1 = src[i+1] * mul;
temp = temp + round;
temp2 = src[i+2] * mul;
temp1 = temp1 + round;
dst[i] = temp >> shift;
temp3 = src[i+3] * mul;
temp2 = temp2 + round;
dst[i+1] = temp1 >> shift;
temp4 = src[i + 4] * mul;
temp3 = temp3 + round;
dst[i+2] = temp2 >> shift;
temp5 = src[i+5] * mul;
temp4 = temp4 + round;
dst[i+3] = temp3 >> shift;
temp6 = src[i+6] * mul;
dst[i+4] = temp4 >> shift;
temp5 = temp5 + round;
temp7 = src[i+7] * mul;
temp6 = temp6 + round;
dst[i+5] = temp5 >> shift;
temp7 = temp7 + round;
dst[i+6] = temp6 >> shift;
dst[i+7] = temp7 >> shift;
}
} else {
shift = -shift;
mul <<= shift;
for (i=0; i<len; i+=8) {
dst[i] = src[i ] * mul;
dst[i+1] = src[i+1] * mul;
dst[i+2] = src[i+2] * mul;
dst[i+3] = src[i+3] * mul;
dst[i+4] = src[i+4] * mul;
dst[i+5] = src[i+5] * mul;
dst[i+6] = src[i+6] * mul;
dst[i+7] = src[i+7] * mul;
}
}
}
static void scale_coefs_q2(int32_t *dst, const int32_t *src, int dynrng,
int len)
{
int i, shift;
int mul;
mul = (dynrng & 0x1f) + 0x20;
shift = 4 - (sign_extend(dynrng, 9) >> 5);
/* AC-3 mantissas have magnitude at most 2^23, hence Q2 coefficients
* have magnitude at most 2^25. Coupling uses MULH(coeff * 2^4, coord)
* with coord < 2^31, so coupled coefficients are below 2^28.
* Rematrixing can at most double them, keeping src below 2^29. */
if (dynrng == 32) {
for (i = 0; i < len; i++)
dst[i] = src[i] * 4;
return;
}
if (shift >= 4) {
const int round = 1 << (shift - 1);
const int unit = 1 << shift;
/* With shift >= 4, quotient * mul is below 2^25 * 63. Splitting
* quotient and remainder therefore keeps both products in int32_t. */
for (i = 0; i < len; i++) {
int quotient = src[i] >> shift;
int remainder = src[i] - quotient * unit;
dst[i] = quotient * mul + ((remainder * mul + round) >> shift);
}
} else if (shift > 0) {
const int round = 1 << (shift - 1);
for (i = 0; i < len; i++)
dst[i] = av_clipl_int32(((int64_t)src[i] * mul + round) >> shift);
} else {
mul <<= -shift;
for (i = 0; i < len; i++)
dst[i] = av_clipl_int32((int64_t)src[i] * mul);
}
}
/**
* Downmix samples from original signal to stereo or mono (this is for 16-bit samples
* and fixed point decoder - original (for 32-bit samples) is in ac3dsp.c).
*/
static void ac3_downmix_c_fixed16(int16_t **samples, int16_t **matrix,
int out_ch, int in_ch, int len)
{
int i, j;
int v0, v1;
if (out_ch == 2) {
for (i = 0; i < len; i++) {
v0 = v1 = 0;
for (j = 0; j < in_ch; j++) {
v0 += samples[j][i] * matrix[0][j];
v1 += samples[j][i] * matrix[1][j];
}
samples[0][i] = (v0+2048)>>12;
samples[1][i] = (v1+2048)>>12;
}
} else if (out_ch == 1) {
for (i = 0; i < len; i++) {
v0 = 0;
for (j = 0; j < in_ch; j++)
v0 += samples[j][i] * matrix[0][j];
samples[0][i] = (v0+2048)>>12;
}
}
}
#if CONFIG_EAC3_DECODER
#include "eac3dec.c"
#endif
#include "ac3dec.c"
static const AVOption options[] = {
{ "cons_noisegen", "enable consistent noise generation", OFFSET(consistent_noise_generation), AV_OPT_TYPE_BOOL, {.i64 = 0 }, 0, 1, PAR },
{ "drc_scale", "percentage of dynamic range compression to apply", OFFSET(drc_scale), AV_OPT_TYPE_FLOAT, {.dbl = 1.0}, 0.0, 6.0, PAR },
{ "heavy_compr", "enable heavy dynamic range compression", OFFSET(heavy_compression), AV_OPT_TYPE_BOOL, {.i64 = 0 }, 0, 1, PAR },
{ "downmix", "Request a specific channel layout from the decoder", OFFSET(downmix_layout), AV_OPT_TYPE_CHLAYOUT, {.str = NULL}, .flags = PAR },
{ NULL},
};
static const AVClass ac3_decoder_class = {
.class_name = "Fixed-Point AC-3 Decoder",
.item_name = av_default_item_name,
.option = options,
.version = LIBAVUTIL_VERSION_INT,
};
const FFCodec ff_ac3_fixed_decoder = {
.p.name = "ac3_fixed",
CODEC_LONG_NAME("ATSC A/52A (AC-3)"),
.p.type = AVMEDIA_TYPE_AUDIO,
.p.id = AV_CODEC_ID_AC3,
.p.priv_class = &ac3_decoder_class,
.priv_data_size = sizeof (AC3DecodeContext),
.init = ac3_decode_init,
.flush = ac3_decode_flush,
.close = ac3_decode_end,
FF_CODEC_DECODE_CB(ac3_decode_frame),
.p.capabilities = AV_CODEC_CAP_CHANNEL_CONF |
AV_CODEC_CAP_DR1,
CODEC_SAMPLEFMTS(AV_SAMPLE_FMT_S16P),
.caps_internal = FF_CODEC_CAP_INIT_CLEANUP,
};