You've already forked node-redis
mirror of
https://github.com/redis/node-redis.git
synced 2025-08-07 13:22:56 +03:00
* init v4 * add .gitignore to benchmark * spawn redis-servers for tests, add some tests, fix client auth on connect * add tests coverage report * add tests workflow, replace nyc text reporter with text-summary * run tests with node 16.x & redis 6.x only (for now) * add socket events on client, stop reconnectiong when manually calling disconnect, remove abort signal listener when a command is written on the socket * add isOpen boolean getter on client, add maxLength option to command queue, add test for client.multi * move to use CommonJS * add MULTI and EXEC commands to when executing multi command, make client.multi return type innerit the module commands, clean some tests, exclute spec files from coverage report * missing file from commit61edd4f1b5
* exclude spec files from coverage report * add support for options in a command function (.get, .set, ...), add support for the SELECT command, implement a couple of commands, fix client socket reconnection strategy, add support for using replicas (RO) in cluster, and more.. * fix client.blPop test * use which to find redis-server path * change command options to work with Symbol rather then WeakSet * implement more commands * Add support for lua scripts in client & muilti, fix client socket initiator, implement simple cluster nodes discovery strategy * replace `callbackify` with `legacyMode` * add the SCAN command and client.scanIterator * rename scanIterator * init benchmark workflow * fix benchmark workflow * fix benchmark workflow * fix benchmark workflow * push coverage report to Coveralls * fix Coveralls * generator lcov (for Coveralls) * fix .nycrc.json * PubSub * add support for all set commands (including sScanIterator) * support pipeline * fix KEEPTTL in SET * remove console.log * add HyperLogLog commands * update README.md (thanks to @guyroyse) * add support for most of the "keys commands" * fix EXPIREAT.spec.ts * add support for date in both EXPIREAT & EXPIRE * add tests * better cluster nodes discorvery strategy after MOVED error, add PubSub test * fix PubSub UNSUBSCRIBE/PUNSUBSCRIBE without channel and/or listener * fix PubSub * add release-it to dev dependencies * Release 4.0.0-next.0 * fix .npmignore * Release 4.0.0-next.1 * fix links in README.md * fix .npmignore * Release 4.0.0-next.2 * add support for all sorted set commands * add support for most stream commands * add missing file from commit53de279afe
* lots of todo commends * make PubSub test more stable * clean ZPOPMAX * add support for lua scripts and modules in cluster, spawn cluster for tests, add some cluster tests, fix pubsub listener arguments * GET.spec.ts * add support for List commands, fix some Sorted Set commands, add some cluster commands, spawn cluster for testing, add support for command options in cluster, and more * add missing file from commitfaab94fab2
* clean ZRANK and ZREVRANK * add XREAD and XREADGROUP commands * remove unused files * implement a couple of more commands, make cluster random iterator be per node (instead of per slot) * Release 4.0.0-next.3 * app spec files to npmignore * fix some code analyzers (LGTM, deepsource, codeclimate) issues * fix CLUSTER_NODES, add some tests * add HSCAN, clean some commands, add tests for generic transformers * add missing files from0feb35a1fb
* update README.md (thanks to @guyroyse) * handle ASK errors, add some commands and tests * Release 4.0.0-next.4 * replace "modern" with "v4" * remove unused imports * add all ACL subcommands, all MODULE subcommands, and some other commands * remove 2 unused imports * fix BITFIELD command * fix XTRIM spec file * clean code * fix package.json types field * better modules support, fix some bugs in legacy mode, add some tests * remove unused function * add test for hScanIterator * change node mimimum version to 12 (latest LTS) * update tsconfig.json to support node 12, run tests on Redis 5 & 6 and on all node live versions * remove future node releases :P * remove "lib" from ts compiler options * Update tsconfig.json * fix build * run some tests only on supported redis versions, use coveralls parallel mode * fix tests * Do not use "timers/promises", fix "isRedisVersionGreaterThan" * skip AbortController tests when not available * use 'fs'.promises instead of 'fs/promises' * add some missing commands * run GETDEL tests only if the redis version is greater than 6.2 * implement some GEO commands, improve scan generic transformer, expose RPUSHX * fix GEOSEARCH & GEOSEARCHSTORE * use socket.setNoDelay and queueMicrotask to improve latency * commands-queue.ts: String length / byte length counting issue (#1630) * Update commands-queue.ts Hopefully fixing #1628 * Reverted 2fa5ea6, and implemented test for byte length check * Changed back to Buffer.byteLength, due to issue author input. Updated test to look for 4 bytes. * Fixed. There were two places that length was calculated. * Removed redundant string assignment * add 2 bytes test as well Co-authored-by: Leibale Eidelman <leibale1998@gmail.com> * fix scripts in multi * do not hide bugs in redis * fix fore7bf09644b
* remove unused import * implement WATCH command, fix ZRANGESTORE & GEOSEARCHSTORE tests * update README.md Co-authored-by: @GuyRoyse * use typedoc to auto generate documentation * run "npm install" before "npm run documentation" * clean documentation workflow * fix WATCH spec file * increase "CLUSTER_NODE_TIMEOUT" to 5000ms to avoid "CLUSTERDOWN" errors in tests * pull cluster state every 100 ms * await meetPromises before pulling the cluster state * enhance the way commanders (client/multi/cluster) get extended with modules and scripts * add test for socket retry strategy * implement more commands * set GETEX minimum version to 6.2 * remove unused imports * add support for multi in cluster * upgrade dependencies * Release 4.0.0-next.5 * remove unused imports * improve benchmarking * use the same Multi with duplicated clients * exclude some files from the documentation, add some exports, clean code * fix #1636 - handle null in multi.exec * remove unused import * add supoprt for tuples in HSET * add FIRST_KEY_INDEX to HSET * add a bunch of missing commands, fix MSET and HELLO, add some tests * add FIRST_KEY_INDEX to MSET and MSETNX * upgrade actions * fix coverallsapp/github-action version * Update documentation.yml * Update documentation.yml * clean code * remove unused imports * use "npm ci" instead of "npm install" * fix `self` binding on client modules, use connection pool for `duplicateConnection` * add client.executeIsolated, rename "duplicateConnection" to "isolated", update README.md (thanks to @GuyRoyse and @SimonPrickett) * update README (thanks to @GuyRoyse), add some tests * try to fix "cluster is down" errors in tests * try to fix "cluster is down" errors in tests * upgrade dependencies * update package-lock * Release 4.0.0-next.6 * fix #1636 - fix WatchError * fix forf1bf0beebf
- remove .only from multi tests * Release 4.0.0-next.7 * update README and other markdown files Co-authored-by: @GuyRoyse & @SimonPrickett * Doc updates. (#1640) * update docs, upgrade dependencies * fix README * Release 4.0.0-rc.0 * Update README.md * update docs, add `connectTimeout` options, fix tls Co-authored-by: Guy Royse <guy@guyroyse.com> * npm update, "fix" some tests, clean code * fix AssertionError import * fix #1642 - fix XREAD, XREADGROUP and XTRIM * fix #1644 - add the QUIT command * add socket.noDelay and socket.keepAlive configurations * Update README.md (#1645) * Update README.md Fixed issue with how connection string was specified. Now you can have user@host without having to specify a password, which just makes more sense * Update client-configuration.md as well Co-authored-by: Leibale Eidelman <leibale1998@gmail.com> * update socket.reconnectStrategy description * fix borken link in v3-to-v4.md * increase test coverage, fix bug in cluster redirection strategy, implement CLIENT_ID, remove unused EXEC command Co-authored-by: Nova <novaw@warrenservices.co.uk> Co-authored-by: Simon Prickett <simon@crudworks.org> Co-authored-by: Guy Royse <guy@guyroyse.com>
373 lines
10 KiB
TypeScript
373 lines
10 KiB
TypeScript
import { strict as assert } from 'assert';
|
|
import RedisClient, { RedisClientType } from './client';
|
|
import { RedisModules } from './commands';
|
|
import { RedisLuaScripts } from './lua-script';
|
|
import { execSync, spawn } from 'child_process';
|
|
import { once } from 'events';
|
|
import { RedisSocketOptions } from './socket';
|
|
import which from 'which';
|
|
import { SinonSpy } from 'sinon';
|
|
import RedisCluster, { RedisClusterType } from './cluster';
|
|
import { promises as fs } from 'fs';
|
|
import { Context as MochaContext } from 'mocha';
|
|
import { promiseTimeout } from './utils';
|
|
|
|
type RedisVersion = [major: number, minor: number, patch: number];
|
|
|
|
type PartialRedisVersion = RedisVersion | [major: number, minor: number] | [major: number];
|
|
|
|
const REDIS_PATH = which.sync('redis-server');
|
|
export const REDIS_VERSION = getRedisVersion();
|
|
|
|
function getRedisVersion(): RedisVersion {
|
|
const raw = execSync(`${REDIS_PATH} -v`).toString(),
|
|
indexOfVersion = raw.indexOf('v=');
|
|
|
|
if (indexOfVersion === -1) {
|
|
throw new Error('Unknown redis version');
|
|
}
|
|
|
|
const start = indexOfVersion + 2;
|
|
return raw.substring(
|
|
start,
|
|
raw.indexOf(' ', start)
|
|
).split('.', 3).map(Number) as RedisVersion;
|
|
}
|
|
|
|
export function isRedisVersionGreaterThan(minimumVersion: PartialRedisVersion | undefined): boolean {
|
|
if (minimumVersion === undefined) return true;
|
|
|
|
const lastIndex = minimumVersion.length - 1;
|
|
for (let i = 0; i < lastIndex; i++) {
|
|
if (REDIS_VERSION[i] > minimumVersion[i]) {
|
|
return true;
|
|
} else if (minimumVersion[i] > REDIS_VERSION[i]) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return REDIS_VERSION[lastIndex] >= minimumVersion[lastIndex];
|
|
}
|
|
|
|
export enum TestRedisServers {
|
|
OPEN,
|
|
PASSWORD
|
|
}
|
|
|
|
export const TEST_REDIS_SERVERS: Record<TestRedisServers, RedisSocketOptions> = <any>{};
|
|
|
|
export enum TestRedisClusters {
|
|
OPEN
|
|
}
|
|
|
|
export const TEST_REDIS_CLUSTERES: Record<TestRedisClusters, Array<RedisSocketOptions>> = <any>{};
|
|
|
|
let port = 6379;
|
|
|
|
interface SpawnRedisServerResult {
|
|
port: number;
|
|
cleanup: () => Promise<void>;
|
|
}
|
|
|
|
async function spawnRedisServer(args?: Array<string>): Promise<SpawnRedisServerResult> {
|
|
const currentPort = port++,
|
|
process = spawn(REDIS_PATH, [
|
|
'--save',
|
|
'',
|
|
'--port',
|
|
currentPort.toString(),
|
|
...(args ?? [])
|
|
]);
|
|
|
|
process
|
|
.once('error', err => console.error('Redis process error', err))
|
|
.once('close', code => console.error(`Redis process closed unexpectedly with code ${code}`));
|
|
|
|
for await (const chunk of process.stdout) {
|
|
if (chunk.toString().includes('Ready to accept connections')) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (process.exitCode !== null) {
|
|
throw new Error('Error while spawning redis server');
|
|
}
|
|
|
|
return {
|
|
port: currentPort,
|
|
async cleanup(): Promise<void> {
|
|
process.removeAllListeners('close');
|
|
assert.ok(process.kill());
|
|
await once(process, 'close');
|
|
}
|
|
};
|
|
}
|
|
|
|
async function spawnGlobalRedisServer(args?: Array<string>): Promise<number> {
|
|
const { port, cleanup } = await spawnRedisServer(args);
|
|
after(cleanup);
|
|
return port;
|
|
}
|
|
|
|
const SLOTS = 16384;
|
|
|
|
interface SpawnRedisClusterNodeResult extends SpawnRedisServerResult {
|
|
client: RedisClientType<RedisModules, RedisLuaScripts>
|
|
}
|
|
|
|
async function spawnRedisClusterNode(
|
|
type: TestRedisClusters | null,
|
|
nodeIndex: number,
|
|
fromSlot: number,
|
|
toSlot: number,
|
|
args?: Array<string>
|
|
): Promise<SpawnRedisClusterNodeResult> {
|
|
const clusterConfigFile = `/tmp/${type}-${nodeIndex}.conf`,
|
|
{ port, cleanup: originalCleanup } = await spawnRedisServer([
|
|
'--cluster-enabled',
|
|
'yes',
|
|
'--cluster-node-timeout',
|
|
'5000',
|
|
'--cluster-config-file',
|
|
clusterConfigFile,
|
|
...(args ?? [])
|
|
]);
|
|
|
|
const client = RedisClient.create({
|
|
socket: {
|
|
port
|
|
}
|
|
});
|
|
|
|
await client.connect();
|
|
|
|
const range = [];
|
|
for (let i = fromSlot; i < toSlot; i++) {
|
|
range.push(i);
|
|
}
|
|
|
|
await Promise.all([
|
|
client.clusterFlushSlots(),
|
|
client.clusterAddSlots(range)
|
|
]);
|
|
|
|
return {
|
|
port,
|
|
async cleanup(): Promise<void> {
|
|
await originalCleanup();
|
|
|
|
try {
|
|
await fs.unlink(clusterConfigFile);
|
|
} catch (err: any) {
|
|
if (err.code === 'ENOENT') return;
|
|
|
|
throw err;
|
|
}
|
|
},
|
|
client
|
|
};
|
|
}
|
|
|
|
export async function spawnRedisCluster(type: TestRedisClusters | null, numberOfNodes: number, args?: Array<string>): Promise<Array<SpawnRedisServerResult>> {
|
|
const spawnPromises = [],
|
|
slotsPerNode = Math.floor(SLOTS / numberOfNodes);
|
|
for (let i = 0; i < numberOfNodes; i++) {
|
|
const fromSlot = i * slotsPerNode;
|
|
spawnPromises.push(
|
|
spawnRedisClusterNode(
|
|
type,
|
|
i,
|
|
fromSlot,
|
|
i === numberOfNodes - 1 ? SLOTS : fromSlot + slotsPerNode,
|
|
args
|
|
)
|
|
);
|
|
}
|
|
|
|
const spawnResults = await Promise.all(spawnPromises),
|
|
meetPromises = [];
|
|
for (let i = 1; i < spawnResults.length; i++) {
|
|
meetPromises.push(
|
|
spawnResults[i].client.clusterMeet(
|
|
'127.0.0.1',
|
|
spawnResults[i - 1].port
|
|
)
|
|
);
|
|
}
|
|
|
|
await Promise.all(meetPromises);
|
|
|
|
while (!(await clusterIsReady(spawnResults))) {
|
|
await promiseTimeout(100);
|
|
}
|
|
|
|
await Promise.all(
|
|
spawnResults.map(result => result.client.disconnect())
|
|
);
|
|
|
|
return spawnResults;
|
|
}
|
|
|
|
async function clusterIsReady(spawnResults: Array<SpawnRedisClusterNodeResult>): Promise<boolean> {
|
|
const nodesClusetrInfo = await Promise.all(
|
|
spawnResults.map(result => result.client.clusterInfo())
|
|
);
|
|
|
|
return nodesClusetrInfo.every(({ state }) => state === 'ok');
|
|
}
|
|
|
|
export async function spawnGlobalRedisCluster(type: TestRedisClusters | null, numberOfNodes: number, args?: Array<string>): Promise<Array<number>> {
|
|
const results = await spawnRedisCluster(type, numberOfNodes, args);
|
|
|
|
after(() => Promise.all(
|
|
results.map(({ cleanup }) => cleanup())
|
|
));
|
|
|
|
return results.map(({ port }) => port);
|
|
}
|
|
|
|
async function spawnOpenServer(): Promise<void> {
|
|
TEST_REDIS_SERVERS[TestRedisServers.OPEN] = {
|
|
port: await spawnGlobalRedisServer()
|
|
};
|
|
}
|
|
|
|
async function spawnPasswordServer(): Promise<void> {
|
|
TEST_REDIS_SERVERS[TestRedisServers.PASSWORD] = {
|
|
port: await spawnGlobalRedisServer(['--requirepass', 'password']),
|
|
password: 'password'
|
|
};
|
|
|
|
if (isRedisVersionGreaterThan([6])) {
|
|
TEST_REDIS_SERVERS[TestRedisServers.PASSWORD].username = 'default';
|
|
}
|
|
}
|
|
|
|
async function spawnOpenCluster(): Promise<void> {
|
|
TEST_REDIS_CLUSTERES[TestRedisClusters.OPEN] = (await spawnGlobalRedisCluster(TestRedisClusters.OPEN, 3)).map(port => ({
|
|
port
|
|
}));
|
|
}
|
|
|
|
before(function () {
|
|
this.timeout(10000);
|
|
|
|
return Promise.all([
|
|
spawnOpenServer(),
|
|
spawnPasswordServer(),
|
|
spawnOpenCluster()
|
|
]);
|
|
});
|
|
|
|
interface RedisTestOptions {
|
|
minimumRedisVersion?: PartialRedisVersion;
|
|
}
|
|
|
|
export function handleMinimumRedisVersion(mochaContext: MochaContext, minimumVersion: PartialRedisVersion | undefined): boolean {
|
|
if (isRedisVersionGreaterThan(minimumVersion)) {
|
|
return false;
|
|
}
|
|
|
|
mochaContext.skip();
|
|
return true;
|
|
}
|
|
|
|
export function describeHandleMinimumRedisVersion(minimumVersion: PartialRedisVersion): void {
|
|
before(function () {
|
|
handleMinimumRedisVersion(this, minimumVersion);
|
|
});
|
|
}
|
|
|
|
export function itWithClient(
|
|
type: TestRedisServers,
|
|
title: string,
|
|
fn: (client: RedisClientType<RedisModules, RedisLuaScripts>) => Promise<void>,
|
|
options?: RedisTestOptions
|
|
): void {
|
|
it(title, async function () {
|
|
if (handleMinimumRedisVersion(this, options?.minimumRedisVersion)) return;
|
|
|
|
const client = RedisClient.create({
|
|
socket: TEST_REDIS_SERVERS[type]
|
|
});
|
|
|
|
await client.connect();
|
|
|
|
try {
|
|
await client.flushAll();
|
|
await fn(client);
|
|
} finally {
|
|
await client.flushAll();
|
|
await client.disconnect();
|
|
}
|
|
});
|
|
}
|
|
|
|
export function itWithCluster(
|
|
type: TestRedisClusters,
|
|
title: string,
|
|
fn: (cluster: RedisClusterType<RedisModules, RedisLuaScripts>) => Promise<void>,
|
|
options?: RedisTestOptions
|
|
): void {
|
|
it(title, async function () {
|
|
if (handleMinimumRedisVersion(this, options?.minimumRedisVersion)) return;
|
|
|
|
const cluster = RedisCluster.create({
|
|
rootNodes: TEST_REDIS_CLUSTERES[type]
|
|
});
|
|
|
|
await cluster.connect();
|
|
|
|
try {
|
|
await clusterFlushAll(cluster);
|
|
await fn(cluster);
|
|
} finally {
|
|
await clusterFlushAll(cluster);
|
|
await cluster.disconnect();
|
|
}
|
|
});
|
|
}
|
|
|
|
export function itWithDedicatedCluster(title: string, fn: (cluster: RedisClusterType<RedisModules, RedisLuaScripts>) => Promise<void>): void {
|
|
it(title, async function () {
|
|
this.timeout(10000);
|
|
|
|
const spawnResults = await spawnRedisCluster(null, 3),
|
|
cluster = RedisCluster.create({
|
|
rootNodes: [{
|
|
port: spawnResults[0].port
|
|
}]
|
|
});
|
|
|
|
await cluster.connect();
|
|
|
|
try {
|
|
await fn(cluster);
|
|
} finally {
|
|
await cluster.disconnect();
|
|
|
|
for (const { cleanup } of spawnResults) {
|
|
await cleanup();
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
async function clusterFlushAll(cluster: RedisCluster): Promise<void> {
|
|
await Promise.all(
|
|
cluster.getMasters().map(({ client }) => client.flushAll())
|
|
);
|
|
}
|
|
|
|
export async function waitTillBeenCalled(spy: SinonSpy): Promise<void> {
|
|
const start = process.hrtime.bigint(),
|
|
calls = spy.callCount;
|
|
|
|
do {
|
|
if (process.hrtime.bigint() - start > 1_000_000_000) {
|
|
throw new Error('Waiting for more than 1 second');
|
|
}
|
|
|
|
await promiseTimeout(1);
|
|
} while (spy.callCount === calls)
|
|
} |