1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Commit Graph

1649 Commits

Author SHA1 Message Date
Thanasis Polychronakis
802539b07e update docs for MULTI exception 2013-04-19 15:49:32 +03:00
Thanasis Polychronakis
a86720097e added test for MULTI exception 2013-04-19 15:40:53 +03:00
Bryce Baril
aa50c789df Merge branch 'master' of https://github.com/mciparelli/node_redis into mciparelli-master 2013-04-18 22:04:10 -07:00
Thanasis Polychronakis
ed57dcd9d5 handling of errors on multi, now returns 'err' array type 2013-04-18 22:25:58 +03:00
Thanasis Polychronakis
c7633bf738 fix unescaped exception in Multi.exec 2013-04-18 21:48:35 +03:00
Luke Plaster
e63947b0b6 Amended subscriber mode error message 2013-04-14 16:45:25 +01:00
Luke Plaster
f558cae049 Amended README to refer to 'pub/sub' mode as 'subscriber' mode; fixes mranney/node_redis#420 2013-04-14 16:32:35 +01:00
Bryce Baril
8feaf8d904 0.8.3 v0.8.3 2013-04-09 16:09:41 -07:00
Martín Ciparelli
2e4c178382 added tests for #404 2013-04-09 16:13:25 -03:00
englandpost
3e0762e6ec fix fwd errors test for node >= 0.9.1
it seems that listeners are no longer mutable
* events: Make emitter.listeners() side-effect free (isaacs, Joe Andaverde)
https://raw.github.com/joyent/node/v0.9.1/ChangeLog
2013-04-05 00:44:06 +04:00
Jeff Barczewski
383bafd2cf limit cbtests to 2.6.11 and above
Test hangs on older versions of Redis
2013-03-27 13:39:43 -05:00
继风
44526402dc fix bug when callback is undefined 2013-03-27 15:58:50 +08:00
Bryce Baril
b0f7760b19 Merge branch 'select_db_exception' of https://github.com/roamm/node_redis into roamm-select_db_exception 2013-03-26 21:47:09 -07:00
Jeff Barczewski
655681f790 fix empty unsub/punsub TypeError
When unsubscribe or punsubscribe is called and it has
no subscriptions, the reply[1] is a null which causes
`TypeError: Cannot call method 'toString' of null`

Check if reply[1] is null before calling toString otherwise
just pass null.
2013-03-26 10:49:13 -05:00
Jeff Barczewski
0c143a7299 failing tests for empty unsub and punsub
When unsubscribe or punsubscribe is called
and there is nothing to unsubscribe from, the reply[1]
argument is a null which causes a TypeError
Cannot call method 'toString' of null

```
TypeError: Cannot call method 'toString' of null
    at RedisClient.return_reply (/Users/barczewskij/projects/node_redis/index.js:633:65)
    at ReplyParser.RedisClient.init_parser (/Users/barczewskij/projects/node_redis/index.js:266:14)
    at ReplyParser.EventEmitter.emit (events.js:96:17)
    at ReplyParser.send_reply (/Users/barczewskij/projects/node_redis/lib/parser/javascript.js:300:10)
    at ReplyParser.execute (/Users/barczewskij/projects/node_redis/lib/parser/javascript.js:211:22)
    at RedisClient.on_data (/Users/barczewskij/projects/node_redis/index.js:483:27)
    at Socket.<anonymous> (/Users/barczewskij/projects/node_redis/index.js:82:14)
    at Socket.EventEmitter.emit (events.js:96:17)
    at TCP.onread (net.js:396:14)
```
2013-03-26 10:48:11 -05:00
Martín Ciparelli
859d2b1171 removed console.log line 2013-03-21 17:14:41 -03:00
Martín Ciparelli
92b7b6dd6d fixes #404 2013-03-21 16:07:05 -03:00
roam
290de97e18 Fixed a subtle error where commands issued within the idle event handler 2013-03-18 16:27:55 +08:00
roam
6fb7204ca5 Add a test case for reconnect_select_db_after_pubsub 2013-03-18 16:08:58 +08:00
Bryce Baril
3aab43e55a Spelling fix in the docs. 2013-03-17 16:31:05 -07:00
Bryce Baril
13d53695de Merge pull request #405 from tomaszdurka/issue-405
Add docu for options: max_attempts, connect_timeout
2013-03-17 16:28:35 -07:00
Tomasz Durka
c456315c1c Add docu for options: max_attemps connect_timeout 2013-03-18 00:16:58 +01:00
Bryce Baril
d03d747145 Merge branch 'add-retry-max' of https://github.com/tomaszdurka/node_redis into tomaszdurka-add-retry-max 2013-03-17 15:59:40 -07:00
Tomasz Durka
3759291034 Docu 2013-03-17 23:52:17 +01:00
Tomasz Durka
0698a5e627 Formatting 2013-03-17 23:45:51 +01:00
继风
78d8f9ef9c need not send message to server when set undefined value 2013-03-17 18:05:39 +08:00
Joffrey F
1ba5864a20 removed extra space 2013-03-16 09:13:40 -07:00
Joffrey F
ed2652f04c Added reproduction test for #344 in test.js 2013-03-16 09:13:40 -07:00
Joffrey F
98a190830b Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Joffrey F
229be2068c Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Bryce Baril
a5dc9898bb Merge pull request #401 from dohse/enable-client-command
Enable client command
2013-03-15 15:07:19 -07:00
Jonas Dohse
67e908ad55 Avoid collision between command and internal field 2013-03-15 22:34:32 +01:00
Jonas Dohse
de22a94edd Amend SCRIPT LOAD test cases 2013-03-14 15:55:13 +01:00
Bryce Baril
ccd4a2b8a3 Adding percentage outputs to diff_multi_bench_output.js
Adding missing dev dependencies to package.json
2013-03-12 21:00:37 -07:00
Tomasz Durka
38dbacac9f Add retry_max_delay option
- add option
- add test
2013-03-12 12:31:19 +01:00
Bryce Baril
92ed0befc1 In nested MULTIBULK buffers, correctly recurse on an incomplete read buffer.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-03-09 19:27:33 -05:00
Bryce Baril
9127f34393 Parser should only catch parser errors and bubble the rest to the caller.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-03-09 19:27:33 -05:00
Bryce Baril
0c172f425c Fix parser incorrect buffer skip for MULTI/EXEC transaction errors with WATCH.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-03-09 19:27:33 -05:00
Bryce Baril
87132e2b03 Add hiredis guard to INCR test
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-03-09 19:27:33 -05:00
DTrejo
405011b640 Revert "hmset throws/errors out on non-string values. fixes #218"
Reverting because this was a documentation problem, not a problem with
the code. Performance-wise, this is faster than the approach in #345, though
it may cause users more trouble. This is okay, if someone opens an issue we
can point them to the docs.

This reverts commit b60e001fa0.

Conflicts:

	index.js
	test.js
2013-02-23 22:56:08 -05:00
DTrejo
a02b0f57e4 test.js: early return if command not supported 2013-02-23 22:43:26 -05:00
Tom Leach
837cec36b6 Detect is an incoming "reply" is in fact a pubsub message. If so, do not pop the command queue.
This fixes an issue where the command queue gets popped prematurely by pubsub
messages, leading to callbacks for those commands not being invoked.

Close #360.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:42:34 -05:00
Jonas Dohse
f0ae6642f9 Use first word of multi word commands
Close #363.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:18:13 -05:00
DTrejo
938c0526a0 EVAL: allow parameters as an array. Close #368.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:05:34 -05:00
Bryce Baril
f3c298d088 Removing order requirement for KEYS test
Close #378.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 21:11:36 -05:00
Bryce Baril
2a12ca39aa Fixing tests for Redis version 2.6.5+ MULTI/EXEC transaction failure compatibility.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 21:08:18 -05:00
DTrejo
92ac62541d Fix #381. slowlog test failure on first run. 2013-02-23 21:06:36 -05:00
Nitesh
0f5b43a68c test.js: slowlog. Closes #295
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-17 20:30:18 -05:00
Garrett Johnson
b5a57b40f7 test.js: smembers reply should not assume order, b/c sets do not ensure order
Closes #326.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-17 19:50:14 -05:00
DTrejo
6a09b2d1a3 fix require in examples/eval.js 2013-02-17 19:06:36 -05:00