1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Commit Graph

115 Commits

Author SHA1 Message Date
Ruben Bridgewater
d39f6961e6 Add tests and emit UNCERTAIN_STATE errors 2015-10-28 23:53:10 +01:00
Ruben Bridgewater
ebea0872a9 Add regression test 2015-10-28 23:53:10 +01:00
Ruben Bridgewater
1cb158b5da Add zscan test 2015-10-28 23:53:10 +01:00
Ruben Bridgewater
2a65ee48dd Fix some minor issues and add more tests
Do not mutate the options object and add some more tests
2015-10-17 21:56:16 +02:00
Ruben Bridgewater
0d4d4d7416 Fix multi not being executed on node 0.10 if not yet ready. Closes #889 2015-10-14 02:24:11 +02:00
Ruben Bridgewater
60e9d0fdd6 Fix multi regression. Closes #889
Allow commands being executed after a Multi / Batch was initiated but not yet executed
2015-10-14 00:58:27 +02:00
Ruben Bridgewater
f0e28bf0f7 Minor improvement for .batch and .multi for small values
Improve the speed by round about 5% for small values

Add Multi.exec_atomic
2015-10-12 08:26:46 +02:00
Ruben Bridgewater
ed2fc95444 Fix should_buffer return values and empty .batch and .auth return value being sync
Fix test
2015-10-11 03:38:41 +02:00
Ruben Bridgewater
d59d6cf114 Add .batch tests 2015-10-11 03:35:22 +02:00
Ruben Bridgewater
f8c245e04f Add .batch with better pipeline implementation 2015-10-11 03:35:22 +02:00
Ruben Bridgewater
146d88154c Fix send_command always returning should_buffer boolean
Fix .auth, .select and .exec to return the should_buffer boolean
2015-10-11 03:35:22 +02:00
Ruben Bridgewater
e0b9f0de79 Fix race condition in tests 2015-10-11 03:31:45 +02:00
Ruben Bridgewater
2ca42417bf Fix explicitly passing undefined as callback 2015-10-02 20:20:56 +02:00
Ruben Bridgewater
3c39a8bdfc Remove .only 2015-09-30 02:12:28 +02:00
Ruben Bridgewater
afcd760b18 Fix a test and add some more 2015-09-30 02:04:56 +02:00
Ruben Bridgewater
fba050802b Move command out of the index.js 2015-09-30 02:03:37 +02:00
Ruben Bridgewater
29b31f749a Add a better promise documentation and add some tests 2015-09-30 01:57:58 +02:00
Ruben Bridgewater
db8c6e3bc2 Skip test until the issue is fixed 2015-09-25 02:23:41 +02:00
Ruben Bridgewater
5f261c5823 Minor changes
Move utility functions in lib/utils.js
Improve the js parser in cases the buffer is incomplete
Rename lib/parser to lib/parsers

Fix smaller issues with test suite and fix parser errors not being catched

Fixed wrong test for the new .end flush parameter
Fixed test suite options being partly mutated
Add some more tests
2015-09-25 02:12:48 +02:00
Ruben Bridgewater
bd4fca130d Make .end flush optional and add some tests 2015-09-24 13:27:32 +02:00
Ruben Bridgewater
38281c20b2 Fix small issues with hmset & multi constructor 2015-09-24 12:08:25 +02:00
Ruben Bridgewater
7be7128b2b Arguments passed as arrays should not be mutated. Fixes #866 2015-09-24 00:31:55 +02:00
Ruben Bridgewater
6958c1854b Increase the coverage by adding tests and fix a failing ready check 2015-09-21 02:38:27 +02:00
Ruben Bridgewater
c60a3b65fe Rename .command_used to .command and add the used command to more errors 2015-09-20 18:56:21 +02:00
Ruben Bridgewater
959b0ee093 Fix error codes for multi.exec and add more tests 2015-09-19 18:26:44 +02:00
Ruben Bridgewater
2293f7ff85 Add some more tests 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
40c037eaf4 Add redis error codes to the errors 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
f543d45d1f Fix and add more tests 2015-09-19 17:48:25 +02:00
Ruben Bridgewater
46e2dc2de5 Fix memory leak. See #723 and thx to @rahar 2015-09-18 00:57:29 +02:00
Ruben Bridgewater
c846ed71d1 Merge pull request #826 from fintura/multi
Fix multi error handling
2015-09-18 00:38:05 +02:00
Ruben Bridgewater
8b7d4a8449 Remove bad .eval implementation
The implementation is not really good as mentioned in #722 and we pipline our commands.
That way we can't just replace the eval function as it was. This could result in violating the order of execution!

If we want to include a function like this we should not break the order of execution and also not recalculate the sha1 hash each time.
2015-09-17 22:51:42 +02:00
Ruben Bridgewater
21d8bdbbcb Refactor multi to have a consistent error handling
Ignore *.log files
2015-09-17 20:30:11 +02:00
Ruben Bridgewater
f92f4d0df9 Merge pull request #850 from fintura/fix-late-commands
Fix commands not being rejected after calling .quit

Fixes #791
2015-09-16 05:43:55 +02:00
Ruben Bridgewater
a0c906256c Fix commands not being rejected after calling .quit as reported in #791 2015-09-16 05:29:34 +02:00
Ruben Bridgewater
0b8705abe9 Do not run all tests with every single connection (if one connection works, the others are going to be fine too) 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
a0c92b0756 Add a lot more tests to indicate that the everything is consistent
Add a test for #390

More special cases
2015-09-15 04:14:40 +02:00
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
2015-09-15 04:00:02 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
4f0443cdd4 Emit errors instead of throwing them
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
2015-09-14 21:28:40 +02:00
Ruben Bridgewater
c6ae7832a3 Remove try callbacks and emit an error in case of no callback has been provided 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
1b261fcaad Revert "added test for multi.hmset's array handling"
This reverts commit bb221adec4.
The test is broken and only passes because there's a bug with multi hmset using arrays.
See #686 and #838 for more details
2015-09-14 21:23:47 +02:00
Benjamin Coe
bb221adec4 added test for multi.hmset's array handling 2015-09-14 00:09:38 -07:00
Benjamin Coe
68936c5eb2 based on code-review added back check for error 2015-09-13 19:17:52 -07:00
Benjamin Coe
b717c8154b added windows badge, made changes based on @BrideAr's code-review 2015-09-13 10:00:50 -07:00
Benjamin Coe
224aff9cee found another difference on Windows CI 2015-09-13 01:05:50 -07:00
Benjamin Coe
71ea42f1bd fix linting and timeout issue 2015-09-12 22:59:47 -07:00
Benjamin Coe
0b46a69c7e fix merge, run linting as part of the test suite 2015-09-12 18:44:01 -07:00
Benjamin Coe
77e8552374 down to one failing test on Windows, time to rebase 2015-09-12 18:31:25 -07:00
Benjamin Coe
a0bf9e2314 tweaks based on running test-suite on Windows on an older Redis 2015-09-12 18:29:50 -07:00
Ruben Bridgewater
06121a65c4 Increase the coverage 2015-09-13 02:21:21 +02:00