redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity
1,100 Commits 23 Branches 298 Tags
uncork
Commit Graph

399 Commits

Author SHA1 Message Date
Bryan English
4672479b91 If there's an error in SELECT and there's no callback, emit the error. 2014-02-18 22:03:25 -08:00
Robert Sköld
0367a64bff Handle undefined redis_version 
Apparently some servers don't send the redis_version with the INFO command (*cough* redis cloud *cough*). This causes the app to crash violently (yay node!).
 2014-02-17 13:26:16 +01:00
Bryce Baril
6a3ccf64f4 Client to emit errors now instead of throwing them asynchronously where they're uncatchable. 2013-12-21 11:08:00 -08:00
William Hockey
313fd7f65b only re-initializing retry variables if the connection is really connected 2013-12-12 12:05:38 -08:00
William Hockey
355bea1e3b Removing attempts reset - will be set to 1 in initialize_retry_vars 2013-12-12 12:04:34 -08:00
Bryce Baril
813cada02f Merge branch 'master' of https://github.com/kwangsu61/node_redis into kwangsu61-master 2013-11-23 11:30:20 -08:00
Alex Stokes
2fbbe26127 removed trailing whitespace 2013-11-20 23:10:14 -06:00
Alex Stokes
a2695f3d17 updated RedisClient.prototype.hmset to accept string or numeric keys when calling client.hmset(key, {key1: val1, key2: val2}) 2013-11-20 16:53:47 -06:00
Forrest L Norvell
2e8c6dae85 exit the domain after emitting. Thanks, cxreg! 2013-10-17 11:46:34 -07:00
Forrest L Norvell
e7099717aa Don't bind the RedisClient to the domain; callback should suffice. 2013-10-17 11:41:37 -07:00
Forrest L Norvell
0b6870be5c Added direct support for domains. 
There are three pieces to this support, all of them small, and none of
them with large overhead:

  1. When sending a command, ensure that any callback is bound to the
     current domain, if one is present.
  2. Also add the RedisClient to the current domain so that error
     events bubble properly.
  3. In try_callback, when a domain is in play, instead of throwing
     on the next tick, emit the error on the domain. The parser can
     still finish processing the response and the error ends up in
     the correct place.
 2013-10-17 11:41:37 -07:00
Mathieu M-Gosselin
75cf487d73 When handling the "error reply" event from the parser, we now bubble up the Error object if it's one instead of wrapping it in another Error. 2013-10-02 22:21:01 -07:00
Bryce Baril
d5c7a2ce2e Formatting 2013-10-02 22:12:56 -07:00
David Barshow
a4f266684e Make retry_max_delay option work correctly when retry_backoff becomes greater than one 2013-10-02 21:56:02 -07:00
bobrik
31c22be6b9 String is not an error 2013-10-02 21:35:51 -07:00
Bryce Baril
b12c49a207 Add unref() method to RedisClient that will call unref() on the socket connection, allowing it to close when unused. This is experimental because it does not yet understand the Redis protocol, so subscriptions or blocking operations will not work correctly. 2013-10-02 16:10:26 -07:00
Bryce Baril
5f125b51d4 Issue #439 (and others): Stop assuming all "message" or "pmessage" replies are pubsub replies. Check pub_sub_mode as well. 2013-10-02 14:04:28 -07:00
Bryce Baril
8f71003009 Add test for auth_pass option submitted by hpeinar 2013-07-24 08:21:28 -07:00
Kwangsu Kim
46cd9329b1 Fix TypeError when handling multi exception 
When errors occurs using multi/exec, avoid "TypeError: Cannot read property 'length' of undefined"
 2013-06-26 02:48:15 +09:00
Henrik Peinar
4dcfa0f92a Auth_pass should be part of options 2013-05-31 10:54:11 -07:00
Jonathan Bergknoff
35001fec76 If password is supplied but redis server does not require it, continue without throwing an error 2013-05-09 10:46:26 -07:00
Bryce Baril
515e975539 Switching RedisClient.prototype.end to call .destroySoon() vs .end() on the stream to have compatible behavior between 0.8 and 0.10. Fixes #419 2013-05-05 10:43:17 -07:00
Bryce Baril
50b1c90bf2 Merge branch 'master' of https://github.com/squamos/node_redis into squamos-master 2013-05-05 09:50:58 -07:00
Bryce Baril
19c918db51 Revert "Deprecate end() by having it call quit() instead. Marked for eventual removal. Fixes #419" 
A hard client-side quit is useful for test purposes, and some other rare use cases.

This reverts commit a8ee9cdb13.
 2013-05-05 09:33:47 -07:00
Bryce Baril
747cd1f10f Merge branch 'jifeng-master' 2013-04-27 08:25:39 -07:00
Bryce Baril
cfd10ac46d Merge branch 'jeffbski-0.8.2-unsub-empty' 2013-04-27 08:23:45 -07:00
Bryce Baril
b321af5cfc Merge branch 'thanpolas-fix-exception-in-multi-exec' 2013-04-27 08:15:17 -07:00
Bryce Baril
a8ee9cdb13 Deprecate end() by having it call quit() instead. Marked for eventual removal. Fixes #419 2013-04-27 08:10:37 -07:00
Amos Barreto
b30efac476 Protect connection retries from application exceptions 2013-04-24 14:11:02 -07:00
Bryce Baril
aa50c789df Merge branch 'master' of https://github.com/mciparelli/node_redis into mciparelli-master 2013-04-18 22:04:10 -07:00
Thanasis Polychronakis
ed57dcd9d5 handling of errors on multi, now returns 'err' array type 2013-04-18 22:25:58 +03:00
Thanasis Polychronakis
c7633bf738 fix unescaped exception in Multi.exec 2013-04-18 21:48:35 +03:00
Luke Plaster
e63947b0b6 Amended subscriber mode error message 2013-04-14 16:45:25 +01:00
继风
44526402dc fix bug when callback is undefined 2013-03-27 15:58:50 +08:00
Bryce Baril
b0f7760b19 Merge branch 'select_db_exception' of https://github.com/roamm/node_redis into roamm-select_db_exception 2013-03-26 21:47:09 -07:00
Jeff Barczewski
655681f790 fix empty unsub/punsub TypeError 
When unsubscribe or punsubscribe is called and it has
no subscriptions, the reply[1] is a null which causes
`TypeError: Cannot call method 'toString' of null`

Check if reply[1] is null before calling toString otherwise
just pass null.
 2013-03-26 10:49:13 -05:00
Martín Ciparelli
859d2b1171 removed console.log line 2013-03-21 17:14:41 -03:00
Martín Ciparelli
92b7b6dd6d fixes #404 2013-03-21 16:07:05 -03:00
roam
290de97e18 Fixed a subtle error where commands issued within the idle event handler 2013-03-18 16:27:55 +08:00
Bryce Baril
d03d747145 Merge branch 'add-retry-max' of https://github.com/tomaszdurka/node_redis into tomaszdurka-add-retry-max 2013-03-17 15:59:40 -07:00
Tomasz Durka
0698a5e627 Formatting 2013-03-17 23:45:51 +01:00
继风
78d8f9ef9c need not send message to server when set undefined value 2013-03-17 18:05:39 +08:00
Joffrey F
1ba5864a20 removed extra space 2013-03-16 09:13:40 -07:00
Joffrey F
98a190830b Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Joffrey F
229be2068c Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Jonas Dohse
67e908ad55 Avoid collision between command and internal field 2013-03-15 22:34:32 +01:00
Tomasz Durka
38dbacac9f Add retry_max_delay option 
- add option
- add test
 2013-03-12 12:31:19 +01:00
DTrejo
405011b640 Revert "hmset throws/errors out on non-string values. fixes #218" 
Reverting because this was a documentation problem, not a problem with
the code. Performance-wise, this is faster than the approach in #345, though
it may cause users more trouble. This is okay, if someone opens an issue we
can point them to the docs.

This reverts commit b60e001fa0.

Conflicts:

	index.js
	test.js
 2013-02-23 22:56:08 -05:00
Tom Leach
837cec36b6 Detect is an incoming "reply" is in fact a pubsub message. If so, do not pop the command queue. 
This fixes an issue where the command queue gets popped prematurely by pubsub
messages, leading to callbacks for those commands not being invoked.

Close #360.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
 2013-02-23 22:42:34 -05:00
Jonas Dohse
f0ae6642f9 Use first word of multi word commands 
Close #363.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
 2013-02-23 22:18:13 -05:00