1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-07 13:22:56 +03:00
Commit Graph

1888 Commits

Author SHA1 Message Date
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
2015-09-15 04:00:02 +02:00
Ruben Bridgewater
e24f056b2d Merge pull request #841 from fintura/command
Add .command_used to errors returned by the parser.

Fix authentication failure being emitted instead of returned by a callback if present. Fixes #427
2015-09-15 03:57:00 +02:00
Ruben Bridgewater
ebbb0146b9 Fix auth emitting the error even though a callback is present
Fix auth manipulating the returned error
And this is also removing some dead code
2015-09-15 03:50:47 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
e4bd9bf0c5 Merge pull request #839 from fintura/statements
Small stuff like: let v8 inline instead of doing in manually
2015-09-15 03:44:47 +02:00
Ruben Bridgewater
6ea70271d6 v8 is going to inline a couple of things that were necessary a few years ago 2015-09-15 03:39:33 +02:00
Ruben Bridgewater
4bdcf8a598 Fix regression: version detection in tests did not work properly anymore 2015-09-14 23:53:52 +02:00
Ruben Bridgewater
785af29385 Merge pull request #842 from fintura/speedup
Small speedup: do not call data.toString() on debug messages
2015-09-14 23:13:19 +02:00
Ruben Bridgewater
4a8da6dce5 Merge pull request #823 from fintura/debug
Refactor debug mode not to break old code and to work with NODE_DEBUG too
2015-09-14 23:12:50 +02:00
Ruben Bridgewater
4f79370887 Merge pull request #816 from fintura/callback
Remove try callback and emit errors if no callback is present. Fixes #456, #591, #522 and #755
2015-09-14 23:11:26 +02:00
Ruben Bridgewater
4f0443cdd4 Emit errors instead of throwing them
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
2015-09-14 21:28:40 +02:00
Ruben Bridgewater
c6ae7832a3 Remove try callbacks and emit an error in case of no callback has been provided 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
1b261fcaad Revert "added test for multi.hmset's array handling"
This reverts commit bb221adec4.
The test is broken and only passes because there's a bug with multi hmset using arrays.
See #686 and #838 for more details
2015-09-14 21:23:47 +02:00
Benjamin E. Coe
bf2ccd9580 Merge pull request #837 from NodeRedis/windows-tests
retrofit tests so that they work on Windows
2015-09-14 08:43:12 -07:00
Ruben Bridgewater
656706a263 Reduce the reauthenticate timeout to 333ms
It should not take all that long to load everything into redis
2015-09-14 15:46:17 +02:00
Benjamin Coe
bb221adec4 added test for multi.hmset's array handling 2015-09-14 00:09:38 -07:00
Benjamin Coe
be708906fa add test for providing auth after client is created 2015-09-13 22:21:03 -07:00
Benjamin Coe
68936c5eb2 based on code-review added back check for error 2015-09-13 19:17:52 -07:00
Ruben Bridgewater
e6aa3826f7 Small speedup: do not call data.toString() on debug messages 2015-09-13 23:51:36 +02:00
Benjamin Coe
bb1ab1498b fix badge markdown, address code-review concerns 2015-09-13 10:05:58 -07:00
Benjamin Coe
b717c8154b added windows badge, made changes based on @BrideAr's code-review 2015-09-13 10:00:50 -07:00
Benjamin Coe
224aff9cee found another difference on Windows CI 2015-09-13 01:05:50 -07:00
Benjamin Coe
40f535b6c6 trying to find an incantation that actually boots Redis 2015-09-13 00:09:06 -07:00
Benjamin Coe
a3ffc3a125 move redis to the install stanza 2015-09-12 23:42:27 -07:00
Benjamin Coe
d5ccb3965d add appveyor configuration 2015-09-12 23:21:14 -07:00
Benjamin Coe
71ea42f1bd fix linting and timeout issue 2015-09-12 22:59:47 -07:00
Benjamin Coe
20bc05abb5 test suite should now run on Windows 2015-09-12 22:56:17 -07:00
Benjamin Coe
0b46a69c7e fix merge, run linting as part of the test suite 2015-09-12 18:44:01 -07:00
Benjamin Coe
77e8552374 down to one failing test on Windows, time to rebase 2015-09-12 18:31:25 -07:00
Benjamin Coe
65b26ed9aa remove hiredis from dev-dependencies 2015-09-12 18:30:07 -07:00
Benjamin Coe
a0bf9e2314 tweaks based on running test-suite on Windows on an older Redis 2015-09-12 18:29:50 -07:00
Benjamin Coe
b4da975785 prep for getting tests to work on appveyor 2015-09-12 18:24:14 -07:00
Ruben Bridgewater
06121a65c4 Increase the coverage 2015-09-13 02:21:21 +02:00
Ruben Bridgewater
8fa5b93c93 Merge pull request #836 from fintura/fix-errors
Do not wrap errors into other errors.
2015-09-12 22:03:24 +02:00
Ruben Bridgewater
0925885a88 Do not wrap errors into other errors. The trace is going to be manipulated that way. 2015-09-12 21:59:17 +02:00
Ruben Bridgewater
4e42fb70f3 Merge pull request #814 from fintura/commands
Update commands list and remove unecessary code
2015-09-12 19:51:01 +02:00
Ruben Bridgewater
b06985a219 Update commands list and remove unecessary code
Add use strict

Add changelog entry
2015-09-12 19:47:25 +02:00
Ruben Bridgewater
feb1faa824 Merge pull request #824 from fintura/async
Remove async dependency
2015-09-12 19:39:27 +02:00
Ruben Bridgewater
43e25e73c9 Remove async dependency 2015-09-12 19:36:07 +02:00
Ruben Bridgewater
c947e8ff3a Merge pull request #817 from fintura/speedup
Tiny speedup by removing command.toLowerCase(). Fixes #605
2015-09-12 19:23:42 +02:00
Ruben Bridgewater
1c1c4ea446 Update readme about lower case commands 2015-09-12 19:17:02 +02:00
Ruben Bridgewater
4c6b84315e Tiny speedup by removing command.toLowerCase()
This is not necessary as the command itself is only used from inside the code and as they are (now) all lower case it is safe to remove the toLowerCase
2015-09-12 19:17:02 +02:00
Ruben Bridgewater
b63e980913 Merge pull request #825 from fintura/emitter
Remove event emitters from the parsers
2015-09-12 19:15:38 +02:00
Ruben Bridgewater
62f9a0cf63 Merge pull request #807 from fintura/master
Add jshint and fix some tests
2015-09-12 19:08:35 +02:00
Ruben Bridgewater
da8c2603c4 Reduce timeouts 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
463c7fd062 Remove unused dependencies 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
fef3891184 Coverage task and jshintignore file added 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
5cbd5b8ffc Run jshint before starting the tests 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
1ae280dcec Fix some tests and deactivate broken ones 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
ba779ac361 Some small code style changes
Revert some done stuff
2015-09-12 18:56:49 +02:00