redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity
1,055 Commits 23 Branches 305 Tags
internal
Commit Graph

1055 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ruben Bridgewater
55d0036eae Add test and fix keeping the offline queue 
Use a new delay after reconnecting
 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
3c2ba8c373 Try exactly until the connection timeout has been reached 
Fixes #587
 2015-09-16 05:22:07 +02:00
Chris Hamant
a9e7663aff removing flush_and_error from on_error handler 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
03e8c03503 Add connection timeout and max attempts tests 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
0b8705abe9 Do not run all tests with every single connection (if one connection works, the others are going to be fine too) 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
1e0421ac3b Emit errors if the connection timeout / maximum retry attempts have been exceeded 
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
f2ee8dbc9e Add a connection timeout of 24h as new default for maximum reconnecting 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
04c986a4cd Lowering the first retry_delay and begin from that value 
Earlier the first value was never used, as it was first multiplied by 1.7
 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
cd5cfb4a8e Emit an error when connection permanently goes down 
Closes #724 and #615
 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
403bfb0200 Merge pull request #835 from fintura/remove-stuff 
Remove send_command safety checks. Fixes #629
 2015-09-16 05:21:18 +02:00
Ruben Bridgewater
eea9d2af76 Merge pull request #847 from fintura/check-password 
Check that the password is from type string
 2015-09-16 05:20:43 +02:00
Ruben Bridgewater
30f227b7b1 Merge pull request #846 from fintura/parser 
Improve js parser
 2015-09-16 05:19:50 +02:00
Ruben Bridgewater
aab1fc8f4f Merge pull request #838 from fintura/consistent-commands 
Consistent commands arguments. All commands are from now on behaving the same no matter if they are on multi or no and they all take an array as either the first or second argument.

Fixes #686 #369 #422 #390 and Closes #634
 2015-09-16 05:17:22 +02:00
Ruben Bridgewater
005e869d83 Remove send_command safety checks 
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that

Fix #629 and insert tests
 2015-09-16 05:10:39 +02:00
Ruben Bridgewater
013831c00f Improve js parser 2015-09-15 23:18:26 +02:00
Ruben Bridgewater
c269b7539c Check that the password is from type string 2015-09-15 22:35:25 +02:00
Ruben Bridgewater
a0c92b0756 Add a lot more tests to indicate that the everything is consistent 
Add a test for #390

More special cases
 2015-09-15 04:14:40 +02:00
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling 
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
 2015-09-15 04:00:02 +02:00
Ruben Bridgewater
e24f056b2d Merge pull request #841 from fintura/command 
Add .command_used to errors returned by the parser.

Fix authentication failure being emitted instead of returned by a callback if present. Fixes #427
 2015-09-15 03:57:00 +02:00
Ruben Bridgewater
ebbb0146b9 Fix auth emitting the error even though a callback is present 
Fix auth manipulating the returned error
And this is also removing some dead code
 2015-09-15 03:50:47 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
e4bd9bf0c5 Merge pull request #839 from fintura/statements 
Small stuff like: let v8 inline instead of doing in manually
 2015-09-15 03:44:47 +02:00
Ruben Bridgewater
6ea70271d6 v8 is going to inline a couple of things that were necessary a few years ago 2015-09-15 03:39:33 +02:00
Ruben Bridgewater
4bdcf8a598 Fix regression: version detection in tests did not work properly anymore 2015-09-14 23:53:52 +02:00
Ruben Bridgewater
785af29385 Merge pull request #842 from fintura/speedup 
Small speedup: do not call data.toString() on debug messages
 2015-09-14 23:13:19 +02:00
Ruben Bridgewater
4a8da6dce5 Merge pull request #823 from fintura/debug 
Refactor debug mode not to break old code and to work with NODE_DEBUG too
 2015-09-14 23:12:50 +02:00
Ruben Bridgewater
4f79370887 Merge pull request #816 from fintura/callback 
Remove try callback and emit errors if no callback is present. Fixes #456, #591, #522 and #755
 2015-09-14 23:11:26 +02:00
Ruben Bridgewater
4f0443cdd4 Emit errors instead of throwing them 
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
c6ae7832a3 Remove try callbacks and emit an error in case of no callback has been provided 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
1b261fcaad Revert "added test for multi.hmset's array handling" 
This reverts commit bb221adec4.
The test is broken and only passes because there's a bug with multi hmset using arrays.
See #686 and #838 for more details
 2015-09-14 21:23:47 +02:00
Benjamin E. Coe
bf2ccd9580 Merge pull request #837 from NodeRedis/windows-tests 
retrofit tests so that they work on Windows
 2015-09-14 08:43:12 -07:00
Ruben Bridgewater
656706a263 Reduce the reauthenticate timeout to 333ms 
It should not take all that long to load everything into redis
 2015-09-14 15:46:17 +02:00
Benjamin Coe
bb221adec4 added test for multi.hmset's array handling 2015-09-14 00:09:38 -07:00
Benjamin Coe
be708906fa add test for providing auth after client is created 2015-09-13 22:21:03 -07:00
Benjamin Coe
68936c5eb2 based on code-review added back check for error 2015-09-13 19:17:52 -07:00
Ruben Bridgewater
e6aa3826f7 Small speedup: do not call data.toString() on debug messages 2015-09-13 23:51:36 +02:00
Benjamin Coe
bb1ab1498b fix badge markdown, address code-review concerns 2015-09-13 10:05:58 -07:00
Benjamin Coe
b717c8154b added windows badge, made changes based on @BrideAr's code-review 2015-09-13 10:00:50 -07:00
Benjamin Coe
224aff9cee found another difference on Windows CI 2015-09-13 01:05:50 -07:00
Benjamin Coe
40f535b6c6 trying to find an incantation that actually boots Redis 2015-09-13 00:09:06 -07:00
Benjamin Coe
a3ffc3a125 move redis to the install stanza 2015-09-12 23:42:27 -07:00
Benjamin Coe
d5ccb3965d add appveyor configuration 2015-09-12 23:21:14 -07:00
Benjamin Coe
71ea42f1bd fix linting and timeout issue 2015-09-12 22:59:47 -07:00
Benjamin Coe
20bc05abb5 test suite should now run on Windows 2015-09-12 22:56:17 -07:00
Benjamin Coe
0b46a69c7e fix merge, run linting as part of the test suite 2015-09-12 18:44:01 -07:00
Benjamin Coe
77e8552374 down to one failing test on Windows, time to rebase 2015-09-12 18:31:25 -07:00
Benjamin Coe
65b26ed9aa remove hiredis from dev-dependencies 2015-09-12 18:30:07 -07:00
Benjamin Coe
a0bf9e2314 tweaks based on running test-suite on Windows on an older Redis 2015-09-12 18:29:50 -07:00
Benjamin Coe
b4da975785 prep for getting tests to work on appveyor 2015-09-12 18:24:14 -07:00
Ruben Bridgewater
06121a65c4 Increase the coverage 2015-09-13 02:21:21 +02:00