redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Code Activity
1,055 Commits 23 Branches 298 Tags
internal
Commit Graph

219 Commits

Author SHA1 Message Date
Ruben Bridgewater
0b8705abe9 Do not run all tests with every single connection (if one connection works, the others are going to be fine too) 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
1e0421ac3b Emit errors if the connection timeout / maximum retry attempts have been exceeded 
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
403bfb0200 Merge pull request #835 from fintura/remove-stuff 
Remove send_command safety checks. Fixes #629
 2015-09-16 05:21:18 +02:00
Ruben Bridgewater
eea9d2af76 Merge pull request #847 from fintura/check-password 
Check that the password is from type string
 2015-09-16 05:20:43 +02:00
Ruben Bridgewater
005e869d83 Remove send_command safety checks 
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that

Fix #629 and insert tests
 2015-09-16 05:10:39 +02:00
Ruben Bridgewater
c269b7539c Check that the password is from type string 2015-09-15 22:35:25 +02:00
Ruben Bridgewater
a0c92b0756 Add a lot more tests to indicate that the everything is consistent 
Add a test for #390

More special cases
 2015-09-15 04:14:40 +02:00
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling 
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
 2015-09-15 04:00:02 +02:00
Ruben Bridgewater
ebbb0146b9 Fix auth emitting the error even though a callback is present 
Fix auth manipulating the returned error
And this is also removing some dead code
 2015-09-15 03:50:47 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
4bdcf8a598 Fix regression: version detection in tests did not work properly anymore 2015-09-14 23:53:52 +02:00
Ruben Bridgewater
4f0443cdd4 Emit errors instead of throwing them 
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
c6ae7832a3 Remove try callbacks and emit an error in case of no callback has been provided 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
1b261fcaad Revert "added test for multi.hmset's array handling" 
This reverts commit bb221adec4.
The test is broken and only passes because there's a bug with multi hmset using arrays.
See #686 and #838 for more details
 2015-09-14 21:23:47 +02:00
Benjamin Coe
bb221adec4 added test for multi.hmset's array handling 2015-09-14 00:09:38 -07:00
Benjamin Coe
be708906fa add test for providing auth after client is created 2015-09-13 22:21:03 -07:00
Benjamin Coe
68936c5eb2 based on code-review added back check for error 2015-09-13 19:17:52 -07:00
Benjamin Coe
b717c8154b added windows badge, made changes based on @BrideAr's code-review 2015-09-13 10:00:50 -07:00
Benjamin Coe
224aff9cee found another difference on Windows CI 2015-09-13 01:05:50 -07:00
Benjamin Coe
71ea42f1bd fix linting and timeout issue 2015-09-12 22:59:47 -07:00
Benjamin Coe
20bc05abb5 test suite should now run on Windows 2015-09-12 22:56:17 -07:00
Benjamin Coe
0b46a69c7e fix merge, run linting as part of the test suite 2015-09-12 18:44:01 -07:00
Benjamin Coe
77e8552374 down to one failing test on Windows, time to rebase 2015-09-12 18:31:25 -07:00
Benjamin Coe
a0bf9e2314 tweaks based on running test-suite on Windows on an older Redis 2015-09-12 18:29:50 -07:00
Benjamin Coe
b4da975785 prep for getting tests to work on appveyor 2015-09-12 18:24:14 -07:00
Ruben Bridgewater
06121a65c4 Increase the coverage 2015-09-13 02:21:21 +02:00
Ruben Bridgewater
0925885a88 Do not wrap errors into other errors. The trace is going to be manipulated that way. 2015-09-12 21:59:17 +02:00
Ruben Bridgewater
43e25e73c9 Remove async dependency 2015-09-12 19:36:07 +02:00
Ruben Bridgewater
4c6b84315e Tiny speedup by removing command.toLowerCase() 
This is not necessary as the command itself is only used from inside the code and as they are (now) all lower case it is safe to remove the toLowerCase
 2015-09-12 19:17:02 +02:00
Ruben Bridgewater
b63e980913 Merge pull request #825 from fintura/emitter 
Remove event emitters from the parsers
 2015-09-12 19:15:38 +02:00
Ruben Bridgewater
da8c2603c4 Reduce timeouts 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
1ae280dcec Fix some tests and deactivate broken ones 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
ba779ac361 Some small code style changes 
Revert some done stuff
 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
9acbd6c860 Add simicolons and remove trailing whitespace 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
06c5f1922b Add jshint and fix errors accordingly (including broken tests) 2015-09-12 18:56:49 +02:00
Benjamin E. Coe
a31a4e29e9 Merge pull request #819 from NodeRedis/815-tweaks 
minor tweaks to how we spawn tests in #815
 2015-09-11 21:40:48 -07:00
Ruben Bridgewater
0170145f74 Remove event emitters from the parser as they are overhead that is not needed 2015-09-05 17:10:27 +02:00
Ruben Bridgewater
9b1d262cdf Accept hmset being used without a callback. Closes #694 2015-09-04 15:21:59 +02:00
Benjamin Coe
d976bbcb2d some small tweaks to #815, so that we don't use two differnt approaches for spawning redis 2015-09-03 22:51:25 -07:00
Ruben Bridgewater
89e1f6f067 Improve code coverage by adding tests and removing unnecessary code 2015-09-03 22:26:01 +02:00
Ruben Bridgewater
1eb30add66 Use util.debuglog instead of using different indidivudal styles for debugging 2015-09-02 21:49:11 +02:00
Ruben Bridgewater
a5938f3ade Refactor the test suite and remove duplicated code 2015-09-01 23:28:41 +02:00
Benjamin Coe
417c8c1247 had descriptions of tests swapped around 2015-08-29 14:55:01 -07:00
Daniel Price
575ade907c Issue #512 send_command("monitoring") is doomed to fail 2015-08-21 14:57:48 -07:00
Benjamin Coe
d1558eddc2 add test demonstrating psubscribe, and pmessage 2015-08-16 18:02:26 -07:00
Benjamin Coe
5d83e64d00 fixed up our one commented out test, based on @erinspice's code review 2015-08-15 13:25:03 -07:00
Benjamin Coe
51b1ba2bef finished porting blpop, expire, mset, slowlog, sunionstore, ttl 2015-08-15 13:00:05 -07:00
Erin Spiceland
65db5dbefe Clarify this one test is only applicable for IPv4. 2015-08-15 11:51:37 -05:00
Benjamin Coe
2fd3b46835 ported sdiff, sdiffstore, sinterstore, smembers, smove, spop, sunion, client.monitor 2015-08-14 22:30:58 -07:00
Benjamin Coe
ce7f21fc34 ported sdiff, sdiffstore, sinterstore, smembers, smove, spop, sunion, client.monitor 2015-08-14 22:30:51 -07:00