1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00

380 Commits

Author SHA1 Message Date
Henrik Peinar
4dcfa0f92a Auth_pass should be part of options 2013-05-31 10:54:11 -07:00
Jonathan Bergknoff
35001fec76 If password is supplied but redis server does not require it, continue without throwing an error 2013-05-09 10:46:26 -07:00
Bryce Baril
515e975539 Switching RedisClient.prototype.end to call .destroySoon() vs .end() on the stream to have compatible behavior between 0.8 and 0.10. Fixes #419 2013-05-05 10:43:17 -07:00
Bryce Baril
50b1c90bf2 Merge branch 'master' of https://github.com/squamos/node_redis into squamos-master 2013-05-05 09:50:58 -07:00
Bryce Baril
19c918db51 Revert "Deprecate end() by having it call quit() instead. Marked for eventual removal. Fixes #419"
A hard client-side quit is useful for test purposes, and some other rare use cases.

This reverts commit a8ee9cdb13.
2013-05-05 09:33:47 -07:00
Bryce Baril
747cd1f10f Merge branch 'jifeng-master' 2013-04-27 08:25:39 -07:00
Bryce Baril
cfd10ac46d Merge branch 'jeffbski-0.8.2-unsub-empty' 2013-04-27 08:23:45 -07:00
Bryce Baril
b321af5cfc Merge branch 'thanpolas-fix-exception-in-multi-exec' 2013-04-27 08:15:17 -07:00
Bryce Baril
a8ee9cdb13 Deprecate end() by having it call quit() instead. Marked for eventual removal. Fixes #419 2013-04-27 08:10:37 -07:00
Amos Barreto
b30efac476 Protect connection retries from application exceptions 2013-04-24 14:11:02 -07:00
Bryce Baril
aa50c789df Merge branch 'master' of https://github.com/mciparelli/node_redis into mciparelli-master 2013-04-18 22:04:10 -07:00
Thanasis Polychronakis
ed57dcd9d5 handling of errors on multi, now returns 'err' array type 2013-04-18 22:25:58 +03:00
Thanasis Polychronakis
c7633bf738 fix unescaped exception in Multi.exec 2013-04-18 21:48:35 +03:00
Luke Plaster
e63947b0b6 Amended subscriber mode error message 2013-04-14 16:45:25 +01:00
继风
44526402dc fix bug when callback is undefined 2013-03-27 15:58:50 +08:00
Bryce Baril
b0f7760b19 Merge branch 'select_db_exception' of https://github.com/roamm/node_redis into roamm-select_db_exception 2013-03-26 21:47:09 -07:00
Jeff Barczewski
655681f790 fix empty unsub/punsub TypeError
When unsubscribe or punsubscribe is called and it has
no subscriptions, the reply[1] is a null which causes
`TypeError: Cannot call method 'toString' of null`

Check if reply[1] is null before calling toString otherwise
just pass null.
2013-03-26 10:49:13 -05:00
Martín Ciparelli
859d2b1171 removed console.log line 2013-03-21 17:14:41 -03:00
Martín Ciparelli
92b7b6dd6d fixes #404 2013-03-21 16:07:05 -03:00
roam
290de97e18 Fixed a subtle error where commands issued within the idle event handler 2013-03-18 16:27:55 +08:00
Bryce Baril
d03d747145 Merge branch 'add-retry-max' of https://github.com/tomaszdurka/node_redis into tomaszdurka-add-retry-max 2013-03-17 15:59:40 -07:00
Tomasz Durka
0698a5e627 Formatting 2013-03-17 23:45:51 +01:00
继风
78d8f9ef9c need not send message to server when set undefined value 2013-03-17 18:05:39 +08:00
Joffrey F
1ba5864a20 removed extra space 2013-03-16 09:13:40 -07:00
Joffrey F
98a190830b Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Joffrey F
229be2068c Support null values in arrays in reply_to_strings() 2013-03-16 09:13:40 -07:00
Jonas Dohse
67e908ad55 Avoid collision between command and internal field 2013-03-15 22:34:32 +01:00
Tomasz Durka
38dbacac9f Add retry_max_delay option
- add option
- add test
2013-03-12 12:31:19 +01:00
DTrejo
405011b640 Revert "hmset throws/errors out on non-string values. fixes #218"
Reverting because this was a documentation problem, not a problem with
the code. Performance-wise, this is faster than the approach in #345, though
it may cause users more trouble. This is okay, if someone opens an issue we
can point them to the docs.

This reverts commit b60e001fa0.

Conflicts:

	index.js
	test.js
2013-02-23 22:56:08 -05:00
Tom Leach
837cec36b6 Detect is an incoming "reply" is in fact a pubsub message. If so, do not pop the command queue.
This fixes an issue where the command queue gets popped prematurely by pubsub
messages, leading to callbacks for those commands not being invoked.

Close #360.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:42:34 -05:00
Jonas Dohse
f0ae6642f9 Use first word of multi word commands
Close #363.

Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:18:13 -05:00
DTrejo
938c0526a0 EVAL: allow parameters as an array. Close #368.
Signed-off-by: DTrejo <david.daniel.trejo@gmail.com>
2013-02-23 22:05:34 -05:00
roam
11db346e73 Fixed an unexpected exception bug when reconnecting in pub/sub mode if selected_db is not null
RedisClient might enter pub/sub mode after at least one SELECT command issued.
When reconnecting, the SELECT command is issued after restoring pub_sub_command to true, which causes an exception.
2012-12-19 15:04:07 +08:00
Matt Ranney
c3ea30ebea Merge pull request #303 from mowaken/master
fixed RedisClient.prototype.end()
2012-11-02 15:01:53 -07:00
Jan Matousek
cc3a1da543 fix whitespace usage 2012-10-18 19:38:39 +02:00
Jan Matousek
71070d84fb Remove unused variable reference 2012-10-18 19:37:37 +02:00
Richard Mok
a9626578df RedisClient.prototype.end function bug fixed.
An uncaught exception will be raised when the retry timer tries to
reconnect and encounter an error, for all event listeners of the stream
were removed in line 826. It should set closing varable to be true.
2012-10-11 16:07:36 +08:00
Matt Ranney
670c256e35 Whitespace and other JSHint changes. 2012-09-10 22:50:54 -07:00
Martín Ciparelli
124ea082b9 fixes #218 by expanding last argument array only for sadd command
Also adds a test that uses SADD in caps. Nicely enough, this makes
multi_bench.js run just a tiny bit faster :)

Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-08-17 15:33:32 -07:00
Kevin Ingersoll
c8103928b4 Attempt evalsha before eval
Fix #253

Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-08-16 13:51:32 -07:00
Ignacio Burgueño
50914baa7f Save and clear client state. Restore it after the connection is ready.
This change stores the connection state regarding subscriptions,
selected db and monitoring. When the connection to Redis drops, the state
is reestablished after a succesful reconnect. Fixes #241. Fixes #210.

Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-07-12 17:19:16 -07:00
DTrejo
1b0b2dc87d index.js: fix enable_offline_queue default. tests pass 2012-07-05 19:18:26 -07:00
Shankar Karuppiah
71a52638de Added checking for callback before attempting to execute the callback
Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-07-05 19:04:19 -07:00
Shankar Karuppiah
83dc4c999b Added option to disable offline queue
Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-07-05 19:04:10 -07:00
Trae Robrock
eb005b10df Forgot a comma
Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-07-05 17:09:26 -07:00
Trae Robrock
2224767c4c Moving some logic that should fix the idle event
Signed-off-by: DTrejo <david.trejo@voxer.com>
2012-07-05 17:09:26 -07:00
DTrejo
b60e001fa0 hmset throws/errors out on non-string values. fixes #218 2012-06-04 16:13:56 -07:00
DTrejo
7734fb63b4 fix #222 hmset object expansion by @kartikrao 2012-06-04 13:43:10 -07:00
Matt Ranney
9e76387f59 Merge pull request #190 from bnoguchi/pub_sub_mode-fix
Pub sub mode fix
2012-04-29 17:56:01 -07:00
TEHEK Firefox
02b62e56bd Fix for [GH-165] - createClient to properly assign parser_module
Signed-off-by: David Trejo <david.daniel.trejo@gmail.com>
2012-04-27 13:41:42 -04:00