8b7d4a8449
Remove bad .eval implementation
...
The implementation is not really good as mentioned in #722 and we pipline our commands.
That way we can't just replace the eval function as it was. This could result in violating the order of execution!
If we want to include a function like this we should not break the order of execution and also not recalculate the sha1 hash each time.
2015-09-17 22:51:42 +02:00
21d8bdbbcb
Refactor multi to have a consistent error handling
...
Ignore *.log files
2015-09-17 20:30:11 +02:00
95a2c373a2
Fix broken build. The merge had a small conflict
2015-09-16 05:58:29 +02:00
f92f4d0df9
Merge pull request #850 from fintura/fix-late-commands
...
Fix commands not being rejected after calling .quit
Fixes #791
2015-09-16 05:43:55 +02:00
a0c906256c
Fix commands not being rejected after calling .quit as reported in #791
2015-09-16 05:29:34 +02:00
89c8dd056b
Do not emit the broken mode twice if exec is called
...
Add more tests
2015-09-16 05:22:43 +02:00
55d0036eae
Add test and fix keeping the offline queue
...
Use a new delay after reconnecting
2015-09-16 05:22:07 +02:00
3c2ba8c373
Try exactly until the connection timeout has been reached
...
Fixes #587
2015-09-16 05:22:07 +02:00
03e8c03503
Add connection timeout and max attempts tests
2015-09-16 05:22:07 +02:00
0b8705abe9
Do not run all tests with every single connection (if one connection works, the others are going to be fine too)
2015-09-16 05:22:07 +02:00
1e0421ac3b
Emit errors if the connection timeout / maximum retry attempts have been exceeded
...
Accept setting max_attempts to zero.
The reconnection event is now emitted when trying to reconnect instead of earlier.
The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
2015-09-16 05:22:07 +02:00
403bfb0200
Merge pull request #835 from fintura/remove-stuff
...
Remove send_command safety checks. Fixes #629
2015-09-16 05:21:18 +02:00
eea9d2af76
Merge pull request #847 from fintura/check-password
...
Check that the password is from type string
2015-09-16 05:20:43 +02:00
005e869d83
Remove send_command safety checks
...
This checks are only important for users who use send_command directly instead of using the convience method.
As the readme clearly stats how send_command should work and any user would have run into errors if misused, these checks can be removed. If any user might misuse the function anyway, it is very likely that another error will be thrown because of that
Fix #629 and insert tests
2015-09-16 05:10:39 +02:00
c269b7539c
Check that the password is from type string
2015-09-15 22:35:25 +02:00
a0c92b0756
Add a lot more tests to indicate that the everything is consistent
...
Add a test for #390
More special cases
2015-09-15 04:14:40 +02:00
c522ca1264
Fix inconsistent command argument handling
...
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
2015-09-15 04:00:02 +02:00
ebbb0146b9
Fix auth emitting the error even though a callback is present
...
Fix auth manipulating the returned error
And this is also removing some dead code
2015-09-15 03:50:47 +02:00
1a06cfb6ec
Add .command_used to errors thrown by the parser
2015-09-15 03:50:46 +02:00
4bdcf8a598
Fix regression: version detection in tests did not work properly anymore
2015-09-14 23:53:52 +02:00
4f0443cdd4
Emit errors instead of throwing them
...
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
2015-09-14 21:28:40 +02:00
c6ae7832a3
Remove try callbacks and emit an error in case of no callback has been provided
2015-09-14 21:28:40 +02:00
1b261fcaad
Revert "added test for multi.hmset's array handling"
...
This reverts commit bb221adec4#686 and #838 for more details
2015-09-14 21:23:47 +02:00
bb221adec4
added test for multi.hmset's array handling
2015-09-14 00:09:38 -07:00
be708906fa
add test for providing auth after client is created
2015-09-13 22:21:03 -07:00
68936c5eb2
based on code-review added back check for error
2015-09-13 19:17:52 -07:00
b717c8154b
added windows badge, made changes based on @BrideAr's code-review
2015-09-13 10:00:50 -07:00
224aff9cee
found another difference on Windows CI
2015-09-13 01:05:50 -07:00
71ea42f1bd
fix linting and timeout issue
2015-09-12 22:59:47 -07:00
20bc05abb5
test suite should now run on Windows
2015-09-12 22:56:17 -07:00
0b46a69c7e
fix merge, run linting as part of the test suite
2015-09-12 18:44:01 -07:00
77e8552374
down to one failing test on Windows, time to rebase
2015-09-12 18:31:25 -07:00
a0bf9e2314
tweaks based on running test-suite on Windows on an older Redis
2015-09-12 18:29:50 -07:00
b4da975785
prep for getting tests to work on appveyor
2015-09-12 18:24:14 -07:00
06121a65c4
Increase the coverage
2015-09-13 02:21:21 +02:00
0925885a88
Do not wrap errors into other errors. The trace is going to be manipulated that way.
2015-09-12 21:59:17 +02:00
43e25e73c9
Remove async dependency
2015-09-12 19:36:07 +02:00
4c6b84315e
Tiny speedup by removing command.toLowerCase()
...
This is not necessary as the command itself is only used from inside the code and as they are (now) all lower case it is safe to remove the toLowerCase
2015-09-12 19:17:02 +02:00
b63e980913
Merge pull request #825 from fintura/emitter
...
Remove event emitters from the parsers
2015-09-12 19:15:38 +02:00
da8c2603c4
Reduce timeouts
2015-09-12 18:56:49 +02:00
1ae280dcec
Fix some tests and deactivate broken ones
2015-09-12 18:56:49 +02:00
ba779ac361
Some small code style changes
...
Revert some done stuff
2015-09-12 18:56:49 +02:00
9acbd6c860
Add simicolons and remove trailing whitespace
2015-09-12 18:56:49 +02:00
06c5f1922b
Add jshint and fix errors accordingly (including broken tests)
2015-09-12 18:56:49 +02:00
a31a4e29e9
Merge pull request #819 from NodeRedis/815-tweaks
...
minor tweaks to how we spawn tests in #815
2015-09-11 21:40:48 -07:00
0170145f74
Remove event emitters from the parser as they are overhead that is not needed
2015-09-05 17:10:27 +02:00
9b1d262cdf
Accept hmset being used without a callback. Closes #694
2015-09-04 15:21:59 +02:00
d976bbcb2d
some small tweaks to #815 , so that we don't use two differnt approaches for spawning redis
2015-09-03 22:51:25 -07:00
89e1f6f067
Improve code coverage by adding tests and removing unnecessary code
2015-09-03 22:26:01 +02:00
1eb30add66
Use util.debuglog instead of using different indidivudal styles for debugging
2015-09-02 21:49:11 +02:00
