1
0
mirror of https://github.com/redis/node-redis.git synced 2025-08-04 15:02:09 +03:00
Commit Graph

91 Commits

Author SHA1 Message Date
Ruben Bridgewater
959b0ee093 Fix error codes for multi.exec and add more tests 2015-09-19 18:26:44 +02:00
Ruben Bridgewater
2293f7ff85 Add some more tests 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
40c037eaf4 Add redis error codes to the errors 2015-09-19 18:17:40 +02:00
Ruben Bridgewater
f543d45d1f Fix and add more tests 2015-09-19 17:48:25 +02:00
Ruben Bridgewater
46e2dc2de5 Fix memory leak. See #723 and thx to @rahar 2015-09-18 00:57:29 +02:00
Ruben Bridgewater
c846ed71d1 Merge pull request #826 from fintura/multi
Fix multi error handling
2015-09-18 00:38:05 +02:00
Ruben Bridgewater
8b7d4a8449 Remove bad .eval implementation
The implementation is not really good as mentioned in #722 and we pipline our commands.
That way we can't just replace the eval function as it was. This could result in violating the order of execution!

If we want to include a function like this we should not break the order of execution and also not recalculate the sha1 hash each time.
2015-09-17 22:51:42 +02:00
Ruben Bridgewater
21d8bdbbcb Refactor multi to have a consistent error handling
Ignore *.log files
2015-09-17 20:30:11 +02:00
Ruben Bridgewater
f92f4d0df9 Merge pull request #850 from fintura/fix-late-commands
Fix commands not being rejected after calling .quit

Fixes #791
2015-09-16 05:43:55 +02:00
Ruben Bridgewater
a0c906256c Fix commands not being rejected after calling .quit as reported in #791 2015-09-16 05:29:34 +02:00
Ruben Bridgewater
0b8705abe9 Do not run all tests with every single connection (if one connection works, the others are going to be fine too) 2015-09-16 05:22:07 +02:00
Ruben Bridgewater
a0c92b0756 Add a lot more tests to indicate that the everything is consistent
Add a test for #390

More special cases
2015-09-15 04:14:40 +02:00
Ruben Bridgewater
c522ca1264 Fix inconsistent command argument handling
Earlier multi.command and client.command diverged a lot in the way they accepted arguments. This is now consistent
This will also fix some bugs like using multi.hmset with arrays
2015-09-15 04:00:02 +02:00
Ruben Bridgewater
1a06cfb6ec Add .command_used to errors thrown by the parser 2015-09-15 03:50:46 +02:00
Ruben Bridgewater
4f0443cdd4 Emit errors instead of throwing them
Thrown errors might kill the users app. By emitting the errors the user is able to catch all errors in one place without the app going down
2015-09-14 21:28:40 +02:00
Ruben Bridgewater
c6ae7832a3 Remove try callbacks and emit an error in case of no callback has been provided 2015-09-14 21:28:40 +02:00
Ruben Bridgewater
1b261fcaad Revert "added test for multi.hmset's array handling"
This reverts commit bb221adec4.
The test is broken and only passes because there's a bug with multi hmset using arrays.
See #686 and #838 for more details
2015-09-14 21:23:47 +02:00
Benjamin Coe
bb221adec4 added test for multi.hmset's array handling 2015-09-14 00:09:38 -07:00
Benjamin Coe
68936c5eb2 based on code-review added back check for error 2015-09-13 19:17:52 -07:00
Benjamin Coe
b717c8154b added windows badge, made changes based on @BrideAr's code-review 2015-09-13 10:00:50 -07:00
Benjamin Coe
224aff9cee found another difference on Windows CI 2015-09-13 01:05:50 -07:00
Benjamin Coe
71ea42f1bd fix linting and timeout issue 2015-09-12 22:59:47 -07:00
Benjamin Coe
0b46a69c7e fix merge, run linting as part of the test suite 2015-09-12 18:44:01 -07:00
Benjamin Coe
77e8552374 down to one failing test on Windows, time to rebase 2015-09-12 18:31:25 -07:00
Benjamin Coe
a0bf9e2314 tweaks based on running test-suite on Windows on an older Redis 2015-09-12 18:29:50 -07:00
Ruben Bridgewater
06121a65c4 Increase the coverage 2015-09-13 02:21:21 +02:00
Ruben Bridgewater
0925885a88 Do not wrap errors into other errors. The trace is going to be manipulated that way. 2015-09-12 21:59:17 +02:00
Ruben Bridgewater
43e25e73c9 Remove async dependency 2015-09-12 19:36:07 +02:00
Ruben Bridgewater
4c6b84315e Tiny speedup by removing command.toLowerCase()
This is not necessary as the command itself is only used from inside the code and as they are (now) all lower case it is safe to remove the toLowerCase
2015-09-12 19:17:02 +02:00
Ruben Bridgewater
da8c2603c4 Reduce timeouts 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
1ae280dcec Fix some tests and deactivate broken ones 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
ba779ac361 Some small code style changes
Revert some done stuff
2015-09-12 18:56:49 +02:00
Ruben Bridgewater
9acbd6c860 Add simicolons and remove trailing whitespace 2015-09-12 18:56:49 +02:00
Ruben Bridgewater
06c5f1922b Add jshint and fix errors accordingly (including broken tests) 2015-09-12 18:56:49 +02:00
Benjamin E. Coe
a31a4e29e9 Merge pull request #819 from NodeRedis/815-tweaks
minor tweaks to how we spawn tests in #815
2015-09-11 21:40:48 -07:00
Ruben Bridgewater
9b1d262cdf Accept hmset being used without a callback. Closes #694 2015-09-04 15:21:59 +02:00
Ruben Bridgewater
89e1f6f067 Improve code coverage by adding tests and removing unnecessary code 2015-09-03 22:26:01 +02:00
Ruben Bridgewater
a5938f3ade Refactor the test suite and remove duplicated code 2015-09-01 23:28:41 +02:00
Benjamin Coe
51b1ba2bef finished porting blpop, expire, mset, slowlog, sunionstore, ttl 2015-08-15 13:00:05 -07:00
Benjamin Coe
2fd3b46835 ported sdiff, sdiffstore, sinterstore, smembers, smove, spop, sunion, client.monitor 2015-08-14 22:30:58 -07:00
Benjamin Coe
a0832c3744 slight refactor from code review
smoke test large list of commands

ported more tests to mocha, some slight cleanup in tests

move sinon and uuid to dev dependencies

finished porting eval tests over to mocha

rebased mocha testing branch with master

ported client and script tests

ported watch tests

ported detect_buffers tests

ported unref tests

ported auth tests over to mocha

ported idle and no_delay tests

ported hlen, hset

continuing marching forward

ported hincrby, sinter, sort, pubsub tests. improved logic in redis-process, I was still occasionally having issues where redis failed to exit.

switch back to default test command

ported del, exists, hlen, keys, randomkey, type

cleanup based on what I've learned so far from refactor. we now start and stop redis less often. moved tests to their final resting place

finished porting node_redis client tests

ported hgetall, mget, msetnx, rename, renamenx, setex, setnx

ported hgetall, mget, msetnx, rename, renamenx, setex, setnx

ported queue tests to mocha

amalgamated some of the helper logic

ported sadd, scard, sismember, srem, utf-8
2015-08-14 21:31:18 -07:00