redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Fix cluster-slots discover race condition again (#2867)

Browse Source
This commit is contained in:
Jeremy
2024-11-25 14:36:33 -06:00
committed by GitHub
parent 9a3e1c5e03
commit ffa7d2525c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/client/lib/cluster/cluster-slots.ts
View File

@@ -164,13 +164,14 @@ export default class RedisClusterSlots<
} }
async #discover(rootNode: RedisClusterClientOptions) { async #discover(rootNode: RedisClusterClientOptions) {
this.#resetSlots();
try { try {
const addressesInUse = new Set<string>(), const addressesInUse = new Set<string>(),
promises: Array<Promise<unknown>> = [], promises: Array<Promise<unknown>> = [],
eagerConnect = this.#options.minimizeConnections !== true; eagerConnect = this.#options.minimizeConnections !== true;
for (const { from, to, master, replicas } of await this.#getShards(rootNode)) { const shards = await this.#getShards(rootNode);
this.#resetSlots(); // Reset slots AFTER shards have been fetched to prevent a race condition
for (const { from, to, master, replicas } of shards) {
const shard: Shard<M, F, S, RESP, TYPE_MAPPING> = { const shard: Shard<M, F, S, RESP, TYPE_MAPPING> = {
master: this.#initiateSlotNode(master, false, eagerConnect, addressesInUse, promises) master: this.#initiateSlotNode(master, false, eagerConnect, addressesInUse, promises)
}; };