From f500398cabe52213e8075a86ed297856e903c7dc Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 19 Apr 2016 00:17:58 +0200 Subject: [PATCH] Run tests only with the js parser instead of hiredis and js parser from now on This removes the optional-dev-dependency as this is not needed from now on anymore --- package.json | 2 -- test/helper.js | 9 +++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 2c4ea07519..d92511f621 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,6 @@ "coverage": "nyc report --reporter=html", "benchmark": "node benchmarks/multi_bench.js", "test": "nyc --cache mocha ./test/*.js ./test/commands/*.js --timeout=8000", - "pretest": "optional-dev-dependency hiredis", "posttest": "eslint . --fix" }, "dependencies": { @@ -40,7 +39,6 @@ "metrics": "^0.1.9", "mocha": "^2.3.2", "nyc": "^6.0.0", - "optional-dev-dependency": "^1.1.0", "tcp-port-used": "^0.1.2", "uuid": "^2.0.1", "win-spawn": "^2.0.0" diff --git a/test/helper.js b/test/helper.js index bb408a19fd..e851b7f7b3 100644 --- a/test/helper.js +++ b/test/helper.js @@ -163,10 +163,11 @@ module.exports = { } var parsers = ['javascript']; var protocols = ['IPv4']; - try { - require('hiredis'); - parsers.push('hiredis'); - } catch (e) {/* ignore eslint */} + // The js parser works the same as the hiredis parser, just activate this if you want to be on the safe side + // try { + // require('hiredis'); + // parsers.push('hiredis'); + // } catch (e) {/* ignore eslint */} if (process.platform !== 'win32') { protocols.push('IPv6', '/tmp/redis.sock'); }