From ed6aca7d03339a84515b2cf30b17161bcdb375f5 Mon Sep 17 00:00:00 2001
From: Manuel Spigolon <behemoth89@gmail.com>
Date: Mon, 18 Aug 2025 10:22:44 +0200
Subject: [PATCH] fix(ts): xtrim threshold accepts string (#3058)

* fix(ts): xtrim threshold accepts string

* test: check MINID with text id
---
 packages/client/lib/commands/XTRIM.spec.ts | 15 +++++++++++++++
 packages/client/lib/commands/XTRIM.ts      |  2 +-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/packages/client/lib/commands/XTRIM.spec.ts b/packages/client/lib/commands/XTRIM.spec.ts
index b88cf84676..38254d565e 100644
--- a/packages/client/lib/commands/XTRIM.spec.ts
+++ b/packages/client/lib/commands/XTRIM.spec.ts
@@ -18,6 +18,11 @@ describe('XTRIM', () => {
         parseArgs(XTRIM, 'key', 'MINID', 123),
         ['XTRIM', 'key', 'MINID', '123']
       );
+
+      assert.deepEqual(
+        parseArgs(XTRIM, 'key', 'MINID', '0-0'),
+        ['XTRIM', 'key', 'MINID', '0-0']
+      );
     });
 
     it('with strategyModifier', () => {
@@ -89,6 +94,16 @@ describe('XTRIM', () => {
     cluster: GLOBAL.CLUSTERS.OPEN,
   });
 
+  testUtils.testAll('xTrim with string MINID', async client => {
+    assert.equal(
+      typeof await client.xTrim('key', 'MINID', '0-0'),
+      'number'
+    );
+  }, {
+    client: GLOBAL.SERVERS.OPEN,
+    cluster: GLOBAL.CLUSTERS.OPEN,
+  });
+
   testUtils.testAll(
     'xTrim with LIMIT',
     async (client) => {
diff --git a/packages/client/lib/commands/XTRIM.ts b/packages/client/lib/commands/XTRIM.ts
index 34171d4611..8d40824d79 100644
--- a/packages/client/lib/commands/XTRIM.ts
+++ b/packages/client/lib/commands/XTRIM.ts
@@ -37,7 +37,7 @@ export default {
     parser: CommandParser,
     key: RedisArgument,
     strategy: 'MAXLEN' | 'MINID',
-    threshold: number,
+    threshold: number | string,
     options?: XTrimOptions
   ) {
     parser.push('XTRIM')