redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

fix XACK

Browse Source
This commit is contained in:
dovi
2023-05-01 19:20:45 -04:00
parent e58562be4d
commit ea87a6767f
3 changed files with 45 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
packages/client/lib/commands/XACK.spec.ts
View File

@@ -1,28 +1,31 @@
// import { strict as assert } from 'assert';
// import testUtils, { GLOBAL } from '../test-utils';
// import { transformArguments } from './XACK';
import { strict as assert } from 'assert';
import testUtils, { GLOBAL } from '../test-utils';
import XACK from './XACK';
// describe('XACK', () => {
// describe('transformArguments', () => {
// it('string', () => {
// assert.deepEqual(
// transformArguments('key', 'group', '1-0'),
// ['XACK', 'key', 'group', '1-0']
// );
// });
describe('XACK', () => {
describe('transformArguments', () => {
it('string', () => {
assert.deepEqual(
XACK.transformArguments('key', 'group', '1-0'),
['XACK', 'key', 'group', '1-0']
);
});
// it('array', () => {
// assert.deepEqual(
// transformArguments('key', 'group', ['1-0', '2-0']),
// ['XACK', 'key', 'group', '1-0', '2-0']
// );
// });
// });
it('array', () => {
assert.deepEqual(
XACK.transformArguments('key', 'group', ['1-0', '2-0']),
['XACK', 'key', 'group', '1-0', '2-0']
);
});
});
// testUtils.testWithClient('client.xAck', async client => {
// assert.equal(
// await client.xAck('key', 'group', '1-0'),
// 0
// );
// }, GLOBAL.SERVERS.OPEN);
// });
testUtils.testAll('xAck', async client => {
assert.equal(
await client.xAck('key', 'group', '1-0'),
0
);
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN
});
});

27
packages/client/lib/commands/XACK.ts
View File

@@ -1,14 +1,15 @@
// import { RedisCommandArgument, RedisCommandArguments } from '.';
// import { pushVariadicArguments } from './generic-transformers';
import { NumberReply, Command, RedisArgument } from '../RESP/types';
import { RedisVariadicArgument, pushVariadicArguments } from './generic-transformers';
// export const FIRST_KEY_INDEX = 1;
// export function transformArguments(
// key: RedisCommandArgument,
// group: RedisCommandArgument,
// id: RedisCommandArgument | Array<RedisCommandArgument>
// ): RedisCommandArguments {
// return pushVariadicArguments(['XACK', key, group], id);
// }
// export declare function transformReply(): number;
export default {
FIRST_KEY_INDEX: 1,
IS_READ_ONLY: false,
transformArguments(
key: RedisArgument,
group: RedisArgument,
id: RedisVariadicArgument
) {
return pushVariadicArguments(['XACK', key, group], id);
},
transformReply: undefined as unknown as () => NumberReply
} as const satisfies Command;

3
packages/client/lib/commands/index.ts
View File

@@ -141,6 +141,7 @@ import UNLINK from './UNLINK';
import UNWATCH from './UNWATCH';
import WAIT from './WAIT';
import WATCH from './WATCH';
import XACK from './XACK';
import XADD_NOMKSTREAM from './XADD_NOMKSTREAM';
import XADD from './XADD';
import XLEN from './XLEN';
@@ -456,6 +457,8 @@ export default {
wait: WAIT,
WATCH,
watch: WATCH,
XACK,
xAck: XACK,
XADD_NOMKSTREAM,
xAddNoMkStream: XADD_NOMKSTREAM,
XADD,