redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Fix: XAUTOCLAIM after a TRIM with pending messages returns nil (#2565)

Browse Source 
* fix(client): XCLAIM & XAUTOCLAIM after a TRIM might return nils

* fix(client): Fix race condition in specs

* revert test utils changes

* make tests faster

---------

Co-authored-by: Leibale Eidelman <me@leibale.com>
This commit is contained in:
Charley DAVID
2023-09-19 23:37:16 +02:00
committed by GitHub
parent 4ec97be4f0
commit e00041e0eb
6 changed files with 154 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
packages/client/lib/commands/XAUTOCLAIM.spec.ts
View File

@@ -23,20 +23,76 @@ describe('XAUTOCLAIM', () => {
});
});
testUtils.testWithClient('client.xAutoClaim', async client => {
await Promise.all([
client.xGroupCreate('key', 'group', '$', {
MKSTREAM: true
}),
testUtils.testWithClient('client.xAutoClaim without messages', async client => {
const [,, reply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', { MKSTREAM: true }),
client.xGroupCreateConsumer('key', 'group', 'consumer'),
client.xAutoClaim('key', 'group', 'consumer', 1, '0-0')
]);
assert.deepEqual(
await client.xAutoClaim('key', 'group', 'consumer', 1, '0-0'),
{
nextId: '0-0',
messages: []
}
);
assert.deepEqual(reply, {
nextId: '0-0',
messages: []
});
}, GLOBAL.SERVERS.OPEN);
testUtils.testWithClient('client.xAutoClaim with messages', async client => {
const [,, id,, reply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', { MKSTREAM: true }),
client.xGroupCreateConsumer('key', 'group', 'consumer'),
client.xAdd('key', '*', { foo: 'bar' }),
client.xReadGroup('group', 'consumer', { key: 'key', id: '>' }),
client.xAutoClaim('key', 'group', 'consumer', 0, '0-0')
]);
assert.deepEqual(reply, {
nextId: '0-0',
messages: [{
id,
message: Object.create(null, {
foo: {
value: 'bar',
configurable: true,
enumerable: true
}
})
}]
});
}, GLOBAL.SERVERS.OPEN);
testUtils.testWithClient('client.xAutoClaim with trimmed messages', async client => {
const [,,,,, id,, reply] = await Promise.all([
client.xGroupCreate('key', 'group', '$', { MKSTREAM: true }),
client.xGroupCreateConsumer('key', 'group', 'consumer'),
client.xAdd('key', '*', { foo: 'bar' }),
client.xReadGroup('group', 'consumer', { key: 'key', id: '>' }),
client.xTrim('key', 'MAXLEN', 0),
client.xAdd('key', '*', { bar: 'baz' }),
client.xReadGroup('group', 'consumer', { key: 'key', id: '>' }),
client.xAutoClaim('key', 'group', 'consumer', 0, '0-0')
]);
assert.deepEqual(reply, {
nextId: '0-0',
messages: testUtils.isVersionGreaterThan([7, 0]) ? [{
id,
message: Object.create(null, {
bar: {
value: 'baz',
configurable: true,
enumerable: true
}
})
}] : [null, {
id,
message: Object.create(null, {
bar: {
value: 'baz',
configurable: true,
enumerable: true
}
})
}]
});
}, GLOBAL.SERVERS.OPEN);
});