redis/node-redis
1
0
Fork 0
mirror of https://github.com/redis/node-redis.git synced 2025-08-06 02:15:48 +03:00
Code Activity

Add Redis 8.2 New Stream Commands (#3029)

Browse Source 
* chore: update Redis version from 8.2-RC1-pre to 8.2-rc1

* feat: implement XDELEX command for Redis 8.2

* feat: implement XACKDEL command for Redis 8.2

* refactor: create shared stream deletion types
  for Redis 8.2 commands

* feat: add Redis 8.2 deletion policies to XTRIM
  command

* feat: add Redis 8.2 deletion policies to XADD commands

* fix: correct XDELEX command method name and test parameter
This commit is contained in:
Pavel Pashov
2025-07-25 17:58:28 +03:00
committed by GitHub
parent ff8319d2d7
commit d941ec5a4c
19 changed files with 746 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

196
packages/client/lib/commands/XACKDEL.spec.ts Normal file
View File

@@ -0,0 +1,196 @@
import { strict as assert } from "node:assert";
import XACKDEL from "./XACKDEL";
import { parseArgs } from "./generic-transformers";
import testUtils, { GLOBAL } from "../test-utils";
import {
STREAM_DELETION_POLICY,
STREAM_DELETION_REPLY_CODES,
} from "./common-stream.types";
describe("XACKDEL", () => {
describe("transformArguments", () => {
it("string - without policy", () => {
assert.deepEqual(parseArgs(XACKDEL, "key", "group", "0-0"), [
"XACKDEL",
"key",
"group",
"IDS",
"1",
"0-0",
]);
});
it("string - with policy", () => {
assert.deepEqual(
parseArgs(
XACKDEL,
"key",
"group",
"0-0",
STREAM_DELETION_POLICY.KEEPREF
),
["XACKDEL", "key", "group", "KEEPREF", "IDS", "1", "0-0"]
);
});
it("array - without policy", () => {
assert.deepEqual(parseArgs(XACKDEL, "key", "group", ["0-0", "1-0"]), [
"XACKDEL",
"key",
"group",
"IDS",
"2",
"0-0",
"1-0",
]);
});
it("array - with policy", () => {
assert.deepEqual(
parseArgs(
XACKDEL,
"key",
"group",
["0-0", "1-0"],
STREAM_DELETION_POLICY.DELREF
),
["XACKDEL", "key", "group", "DELREF", "IDS", "2", "0-0", "1-0"]
);
});
});
testUtils.testAll(
`XACKDEL non-existing key - without policy`,
async (client) => {
const reply = await client.xAckDel("{tag}stream-key", "testgroup", "0-0");
assert.deepEqual(reply, [STREAM_DELETION_REPLY_CODES.NOT_FOUND]);
},
{
client: { ...GLOBAL.SERVERS.OPEN, minimumDockerVersion: [8, 2] },
cluster: { ...GLOBAL.CLUSTERS.OPEN, minimumDockerVersion: [8, 2] },
}
);
testUtils.testAll(
`XACKDEL existing key - without policy`,
async (client) => {
const streamKey = "{tag}stream-key";
const groupName = "testgroup";
// create consumer group, stream and message
await client.xGroupCreate(streamKey, groupName, "0", { MKSTREAM: true });
const messageId = await client.xAdd(streamKey, "*", { field: "value" });
// read message
await client.xReadGroup(groupName, "testconsumer", {
key: streamKey,
id: ">",
});
const reply = await client.xAckDel(streamKey, groupName, messageId);
assert.deepEqual(reply, [STREAM_DELETION_REPLY_CODES.DELETED]);
},
{
client: { ...GLOBAL.SERVERS.OPEN, minimumDockerVersion: [8, 2] },
cluster: { ...GLOBAL.CLUSTERS.OPEN, minimumDockerVersion: [8, 2] },
}
);
testUtils.testAll(
`XACKDEL existing key - with policy`,
async (client) => {
const streamKey = "{tag}stream-key";
const groupName = "testgroup";
// create consumer group, stream and message
await client.xGroupCreate(streamKey, groupName, "0", { MKSTREAM: true });
const messageId = await client.xAdd(streamKey, "*", { field: "value" });
// read message
await client.xReadGroup(groupName, "testconsumer", {
key: streamKey,
id: ">",
});
const reply = await client.xAckDel(
streamKey,
groupName,
messageId,
STREAM_DELETION_POLICY.DELREF
);
assert.deepEqual(reply, [STREAM_DELETION_REPLY_CODES.DELETED]);
},
{
client: { ...GLOBAL.SERVERS.OPEN, minimumDockerVersion: [8, 2] },
cluster: { ...GLOBAL.CLUSTERS.OPEN, minimumDockerVersion: [8, 2] },
}
);
testUtils.testAll(
`XACKDEL acknowledge policy - with consumer group`,
async (client) => {
const streamKey = "{tag}stream-key";
const groupName = "testgroup";
// create consumer groups, stream and message
await client.xGroupCreate(streamKey, groupName, "0", { MKSTREAM: true });
await client.xGroupCreate(streamKey, "some-other-group", "0");
const messageId = await client.xAdd(streamKey, "*", { field: "value" });
// read message
await client.xReadGroup(groupName, "testconsumer", {
key: streamKey,
id: ">",
});
const reply = await client.xAckDel(
streamKey,
groupName,
messageId,
STREAM_DELETION_POLICY.ACKED
);
assert.deepEqual(reply, [STREAM_DELETION_REPLY_CODES.DANGLING_REFS]);
},
{
client: { ...GLOBAL.SERVERS.OPEN, minimumDockerVersion: [8, 2] },
cluster: { ...GLOBAL.CLUSTERS.OPEN, minimumDockerVersion: [8, 2] },
}
);
testUtils.testAll(
`XACKDEL multiple keys`,
async (client) => {
const streamKey = "{tag}stream-key";
const groupName = "testgroup";
// create consumer groups, stream and add messages
await client.xGroupCreate(streamKey, groupName, "0", { MKSTREAM: true });
const messageIds = await Promise.all([
client.xAdd(streamKey, "*", { field: "value1" }),
client.xAdd(streamKey, "*", { field: "value2" }),
]);
// read messages
await client.xReadGroup(groupName, "testconsumer", {
key: streamKey,
id: ">",
});
const reply = await client.xAckDel(
streamKey,
groupName,
[...messageIds, "0-0"],
STREAM_DELETION_POLICY.DELREF
);
assert.deepEqual(reply, [
STREAM_DELETION_REPLY_CODES.DELETED,
STREAM_DELETION_REPLY_CODES.DELETED,
STREAM_DELETION_REPLY_CODES.NOT_FOUND,
]);
},
{
client: { ...GLOBAL.SERVERS.OPEN, minimumDockerVersion: [8, 2] },
cluster: { ...GLOBAL.CLUSTERS.OPEN, minimumDockerVersion: [8, 2] },
}
);
});